Upgrade rails to 7.2.2 so that we can proceed with the rails 8 upgrade afterwards # Changelog - `.circleci/config.yml` — align CI DB setup with GitHub Actions (`db:create` + `db:schema:load`) to avoid trigger-dependent prep steps. - `.rubocop.yml` — add `rubocop-rspec_rails` and disable new cops that don't match existing spec style. - `AGENTS.md` — document that specs should run without `.env` (rename temporarily when present). - `Gemfile` — upgrade to Rails 7.2, switch Azure storage gem, pin `commonmarker`, bump `sidekiq-cron`, add `rubocop-rspec_rails`, and relax some gem pins. - `Gemfile.lock` — dependency lockfile updates from the Rails 7.2 and gem changes. - `app/controllers/api/v1/accounts/integrations/linear_controller.rb` — stringify params before passing to the Linear service to keep key types stable. - `app/controllers/super_admin/instance_statuses_controller.rb` — use `MigrationContext` API for migration status in Rails 7.2. - `app/models/installation_config.rb` — add commentary on YAML serialization and future JSONB migration (no behavior change). - `app/models/integrations/hook.rb` — ensure hook type is set on create only and guard against missing app. - `app/models/user.rb` — update enum syntax for Rails 7.2 deprecation, serialize OTP backup codes with JSON, and use Ruby `alias`. - `app/services/crm/leadsquared/setup_service.rb` — stringify hook settings keys before merge to keep JSON shape consistent. - `app/services/macros/execution_service.rb` — remove macro-specific assignee activity workaround; rely on standard assignment handlers. - `config/application.rb` — load Rails 7.2 defaults. - `config/storage.yml` — update Azure Active Storage service name to `AzureBlob`. - `db/migrate/20230515051424_update_article_image_keys.rb` — use credentials `secret_key_base` with fallback to legacy secrets. - `docker/Dockerfile` — add `yaml-dev` and `pkgconf` packages for native extensions (Ruby 3.4 / psych). - `lib/seeders/reports/message_creator.rb` — add parentheses for clarity in range calculation. - `package.json` — pin Vite version and bump `vite-plugin-ruby`. - `pnpm-lock.yaml` — lockfile changes from JS dependency updates. - `spec/builders/v2/report_builder_spec.rb` — disable transactional fixtures; truncate tables per example via Rails `truncate_tables` so after_commit callbacks run with clean isolation; keep builder spec metadata minimal. - `spec/builders/v2/reports/label_summary_builder_spec.rb` — disable transactional fixtures + truncate tables via Rails `truncate_tables`; revert to real `resolved!`/`open!`/`resolved!` flow for multiple resolution events; align date range to `Time.zone` to avoid offset gaps; keep builder spec metadata minimal. - `spec/controllers/api/v1/accounts/macros_controller_spec.rb` — assert `assignee_id` instead of activity message to avoid transaction-timing flakes. - `spec/services/telegram/incoming_message_service_spec.rb` — reference the contact tied to the created conversation instead of `Contact.all.first` to avoid order-dependent failures when other specs leave data behind. - `spec/mailers/administrator_notifications/shared/smtp_config_shared.rb` — use `with_modified_env` instead of stubbing mailer internals. - `spec/services/account/sign_up_email_validation_service_spec.rb` — compare error `class.name` for parallel/reload-safe assertions.
61 lines
1.7 KiB
Ruby
61 lines
1.7 KiB
Ruby
class ArticleKeyConverter
|
|
def initialize(article)
|
|
@article = article
|
|
end
|
|
|
|
def process
|
|
new_content = replace(@article.content)
|
|
@article.update(content: new_content)
|
|
end
|
|
|
|
private
|
|
|
|
def convert_key(id)
|
|
verifier_name = 'ActiveStorage'
|
|
secret_key_base = Rails.application.credentials.secret_key_base ||
|
|
Rails.application.secrets.secret_key_base
|
|
key_generator = ActiveSupport::KeyGenerator.new(secret_key_base,
|
|
iterations: 1000,
|
|
hash_digest_class: OpenSSL::Digest::SHA1)
|
|
key_generator = ActiveSupport::CachingKeyGenerator.new(key_generator)
|
|
secret = key_generator.generate_key(verifier_name.to_s)
|
|
verifier = ActiveSupport::MessageVerifier.new(secret)
|
|
|
|
begin
|
|
ActiveStorage::Blob.find(verifier.verify(id, purpose: :blob_id))
|
|
.try(:signed_id)
|
|
rescue StandardError
|
|
nil
|
|
end
|
|
end
|
|
|
|
def replace(text)
|
|
keys = get_keys(text)
|
|
keys.each do |key|
|
|
new_key = convert_key(key)
|
|
text = text.gsub(key, new_key) if new_key
|
|
end
|
|
text
|
|
end
|
|
|
|
def get_keys(text)
|
|
uris = text.scan(URI::DEFAULT_PARSER.make_regexp).flatten.select do |x|
|
|
x.to_s.include?('rails/active_storage')
|
|
end
|
|
|
|
uris.map { |x| x.split('/')[-2] }
|
|
end
|
|
end
|
|
|
|
# rubocop:disable Style/OneClassPerFile
|
|
class UpdateArticleImageKeys < ActiveRecord::Migration[7.0]
|
|
def change
|
|
# Iterate through all articles
|
|
Article.find_each do |article|
|
|
# Run the ArticleKeyConverter for each one
|
|
ArticleKeyConverter.new(article).process
|
|
end
|
|
end
|
|
end
|
|
# rubocop:enable Style/OneClassPerFile
|