c884cdefde
Introduce a daily cap on non-channel outbound emails to prevent abuse. Fixes https://linear.app/chatwoot/issue/CW-6418/ses-incident-jan-28 ## Type of change - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality not to work as expected) ## Summary - Adds a Redis-based daily counter to rate limit outbound emails per account, preventing email abuse - Covers continuity emails (WebWidget/API), conversation transcripts, and agent notifications - Email channel replies are excluded (paid feature, not abusable) - Adds account suspension check in `ConversationReplyMailer` to block already-queued emails for suspended accounts ## Limit Resolution Hierarchy 1. Per-account override (`account.limits['emails']`) — SuperAdmin configurable 2. Enterprise plan-based (`ACCOUNT_EMAILS_PLAN_LIMITS` InstallationConfig) 3. Global default (`ACCOUNT_EMAILS_LIMIT` InstallationConfig, default: 100) 4. Fallback (`ChatwootApp.max_limit` — effectively unlimited) ## Enforcement Points | Path | Where | Behavior | |------|-------|----------| | WebWidget/API continuity | `SendEmailNotificationService#should_send_email_notification?` | Silently skipped | | Widget transcript | `Widget::ConversationsController#transcript` | Returns 429 | | API transcript | `ConversationsController#transcript` | Returns 429 | | Agent notifications | `Notification::EmailNotificationService#perform` | Silently skipped | | Email channel replies | Not rate limited | Paid feature | | Suspended accounts | `ConversationReplyMailer` | Blocked at mailer level |
33 lines
1.1 KiB
Ruby
33 lines
1.1 KiB
Ruby
class Notification::EmailNotificationService
|
|
pattr_initialize [:notification!]
|
|
|
|
def perform
|
|
# don't send emails if user read the push notification already
|
|
return if notification.read_at.present?
|
|
# don't send emails if user is not confirmed
|
|
return if notification.user.confirmed_at.nil?
|
|
return unless user_subscribed_to_notification?
|
|
return unless notification.account.within_email_rate_limit?
|
|
|
|
send_notification_email
|
|
notification.account.increment_email_sent_count
|
|
end
|
|
|
|
private
|
|
|
|
# TODO : Clean up whatever happening over here
|
|
# Segregate the mailers properly
|
|
def send_notification_email
|
|
AgentNotifications::ConversationNotificationsMailer.with(account: notification.account).public_send(
|
|
notification.notification_type.to_s, notification.primary_actor, notification.user, notification.secondary_actor
|
|
).deliver_later
|
|
end
|
|
|
|
def user_subscribed_to_notification?
|
|
notification_setting = notification.user.notification_settings.find_by(account_id: notification.account.id)
|
|
return true if notification_setting.public_send("email_#{notification.notification_type}?")
|
|
|
|
false
|
|
end
|
|
end
|