Petterson
6e46be36c8
fix: Add fix to only allow confirmed agents to used in Agent Assingments at Macros/Automations ( #13225 )
...
# Pull Request Template
## Description
Unconfirmed agents (pending email verification) were incorrectly
appearing in the "assign agent" dropdown for macros and automations.
This fix filters out unconfirmed agents from these dropdowns and adds
backend validation to prevent assignment of unconfirmed agents.
Fixes #13223
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
**Backend tests:**
```bash
docker compose run --rm rails bundle exec rspec spec/services/action_service_spec.rb
```
- Added tests for confirmed agent assignment (should succeed)
- Added tests for unconfirmed agent assignment (should be skipped)
**Frontend tests:**
```bash
docker compose run --rm rails pnpm test app/javascript/dashboard/composables/spec/useMacros.spec.js
```
- Updated mocks to use `getVerifiedAgents` getter
**Manual testing:**
1. Create an unconfirmed agent via platform
2. Navigate to Settings → Macros → New Macro → Add "Assign Agent" action
3. Verify unconfirmed agent does NOT appear in dropdown
4. Navigate to Settings → Automations → New Automation → Add "Assign
Agent" action
5. Verify unconfirmed agent does NOT appear in dropdown
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [ ] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
---------
Co-authored-by: Sojan Jose <sojan@pepalo.com >
2026-03-11 02:01:53 -07:00
Vishnu Narayanan
00ed074d72
fix: disable email transcript for free plans ( #13509 )
...
- Block email transcript functionality for accounts without a paid plan
to prevent SES abuse.
2026-02-11 21:21:36 +05:30
Vishnu Narayanan
0a910c3763
fix: Add email rate limiting to automation rule actions ( #13474 )
2026-02-07 10:02:40 -08:00
Shivam Mishra
133fb1bcf6
feat: add mark pending action to automation ( #13378 )
2026-02-02 11:59:51 +05:30
Pranav
ef591f848a
chore: Add open conversation option ( #11828 )
...
Added conversation_status, assignee_id, team_id, and priority to the
message_created event to allow users to build automations based on
conversation details. Also introduced a new open_conversation action.
---------
Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com >
2025-07-02 10:01:50 +05:30
Clairton Rodrigo Heinzen
96f4f50d2d
feat: Add the ability to un-assign teams using automation ( #9668 )
...
Co-authored-by: Pranav <pranavrajs@gmail.com >
2024-06-26 12:40:36 -07:00
Vishnu Narayanan
23230e0143
feat: sla-7 ensure applied_sla uniqueness ( #8938 )
...
* feat: refactor fetching sla in action service
* chore: modify spec
* chore: ensure applied_sla uniqueness
* chore: review fixes
* feat: add unique index on applied_sla
* chore: fix spec
* chore: add new specs to improve coverage
* chore: improve spec
* Update spec/enterprise/services/enterprise/action_service_spec.rb
---------
Co-authored-by: Sojan Jose <sojan@pepalo.com >
2024-02-20 21:59:49 +05:30
Vishnu Narayanan
b8047f0912
feat: sla-2 add automation backend support for SLA ( #8775 )
...
* feat: add automation support for SLA
* feat: add sla action in automtion UI
* chore: revert frontend changes
* chore: refactor to ee namespace
* chore: refactor automation rule to ee namespace
* feat: create applied_sla table entry
* chore: add applied_sla spec
* chore: rubocop fixes
---------
Co-authored-by: Sojan <sojan@pepalo.com >
2024-02-01 15:42:12 +05:30
Vishnu Narayanan
e7e14f01e4
fix: undefined method 'zero?' for nil:NilClass ( #8689 )
2024-01-15 15:07:36 +05:30
Muhsin Keloth
2d4ef0c328
feat: Add None option in automation assign agent actions ( #7900 )
2023-09-14 09:01:58 +05:30
Tejaswini Chile
99dfe1d5af
feat: Enable template variables in channel greeting messages ( #6971 )
2023-04-26 20:23:46 +05:30
Muhsin Keloth
d1584eea72
feat: Add an action on automation to change the priority ( #6925 )
2023-04-20 11:31:33 +05:30
Tejaswini Chile
5cdc7d654a
feat: Support multiple emails in email transcript automation ( #6924 )
2023-04-19 16:55:25 +05:30
Tejaswini Chile
9bfbd528ef
feat: Assign team with teams none option ( #5871 )
2022-11-17 14:15:16 +05:30
Tejaswini Chile
e85f998a08
feat: Remove labels in macro ( #5875 )
2022-11-17 12:30:47 +05:30
Tejaswini Chile
826a735cdb
fix: Assign agent action changes ( #5827 )
2022-11-15 13:15:27 +05:30
Fayaz Ahmed
9eb861a3b7
feat: Custom attributes in automations and refactor ( #4548 )
...
* Custom attributes
* Custom Attrs Manifest
* Fix dropdown values for custom attributes
* Handle edit mode for custom attributes
* Ported duplicate logic to a mixin
* fix Code climate issue
* Fix Codeclimate complexity warning
* Bug fix - Custom attributes getting duplicated
* Bug fixes and Code Climate issue fix
* Code Climate Issues Breakdown
* Fix test spec
* Add labels for Custom attributes in dropdown
* Refactor
* Refactor Automion mixin
* Refactor Mixin
* Refactor getOperator
* Fix getOperatorType
* File name method refactor
* Refactor appendNewCondition
* spec update
* Refactor methods
* Mixin Spec update
* Automation Mixins Test Specs
* Mixin Spec Rerun
* Automation validations mixin spec
* Automation helper test spec
* Send custom_attr key
* Fix spec fixtures
* fix: Changes for custom attribute type and lower case search
* fix: Specs
* fix: Specs
* fix: Ruby version change
* fix: Ruby version change
* Removes Lowercased values and fix label value in api payload
* Fix specs
* Fixed Query Spec
* Removed disabled labels if no attributes are present
* Code Climate Fixes
* fix: custom attribute with indifferent access
* fix: custom attribute with indifferent access
* Fix specs
* Minor label fix
* REtrigger circle ci build
* Update app/javascript/shared/mixins/specs/automationMixin.spec.js
* Update app/javascript/shared/mixins/specs/automationMixin.spec.js
* fix: Custom attribute case insensitivity search
* Add missing reset action method to input
* Set team_input to single select instead of multiple
* fix: remove value case check for date,boolean and number data type
* fix: cognitive complexity
* fix: cognitive complexity
* fix: Fixed activity message for automation system
* fix: Fixed activity message for automation system
* fix: Fixed activity message for automation system
* fix: codeclimate
* fix: codeclimate
* fix: action cable events for label update
* fix: codeclimate, conversation modela number of methods
* fix: codeclimate, conversation modela number of methods
* fix: codeclimate, conversation modela number of methods
* fix: codeclimate, conversation modela number of methods
* Fix margin bottom for attachment button
* Remove margin bottom to avoid conflict from macros
* Fix automation action query generator using the right key
* fix: not running message created event for activity message
* fix: not running message created event for activity message
* codeclimate fix
* codeclimate fix
* codeclimate fix
* Update app/javascript/dashboard/mixins/automations/methodsMixin.js
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
* Update app/javascript/shared/mixins/specs/automationHelper.spec.js
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
* Update app/javascript/dashboard/helper/automationHelper.js
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
* Update app/javascript/dashboard/mixins/automations/methodsMixin.js
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
Co-authored-by: Pranav Raj S <pranav@chatwoot.com >
Co-authored-by: Tejaswini <tejaswini@chatwoot.com >
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
Co-authored-by: Sojan Jose <sojan@pepalo.com >
Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com >
2022-11-10 10:53:29 +05:30
Tejaswini Chile
a274a1702a
chore: Macros enhancement ( #5609 )
...
- Fixed send_attachment and send_email_transcript
- Fixed duplicate activity messages
- Fixed Order of execution
Fixes : #5584
2022-10-20 19:41:48 -07:00
Tejaswini Chile
6a4c0a1578
feat: Execute macro actions, for the conversation ( #5066 )
2022-07-26 12:41:22 +05:30
