chore: Discard activities from email notifiable messages (#3989)
This commit is contained in:
@@ -137,7 +137,8 @@ class Message < ApplicationRecord
|
|||||||
end
|
end
|
||||||
|
|
||||||
def email_notifiable_message?
|
def email_notifiable_message?
|
||||||
return false if private? || incoming?
|
return false if private?
|
||||||
|
return false if %w[outgoing template].exclude?(message_type)
|
||||||
return false if template? && %w[input_csat text].exclude?(content_type)
|
return false if template? && %w[input_csat text].exclude?(content_type)
|
||||||
|
|
||||||
true
|
true
|
||||||
|
|||||||
@@ -111,6 +111,7 @@ RSpec.describe Message, type: :model do
|
|||||||
|
|
||||||
it 'return false if private message' do
|
it 'return false if private message' do
|
||||||
message.private = true
|
message.private = true
|
||||||
|
message.message_type = 'outgoing'
|
||||||
expect(message.email_notifiable_message?).to be false
|
expect(message.email_notifiable_message?).to be false
|
||||||
end
|
end
|
||||||
|
|
||||||
@@ -120,6 +121,12 @@ RSpec.describe Message, type: :model do
|
|||||||
expect(message.email_notifiable_message?).to be false
|
expect(message.email_notifiable_message?).to be false
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it 'return false if activity message' do
|
||||||
|
message.private = false
|
||||||
|
message.message_type = 'activity'
|
||||||
|
expect(message.email_notifiable_message?).to be false
|
||||||
|
end
|
||||||
|
|
||||||
it 'return false if message type is template and content type is not input_csat or text' do
|
it 'return false if message type is template and content type is not input_csat or text' do
|
||||||
message.private = false
|
message.private = false
|
||||||
message.message_type = 'template'
|
message.message_type = 'template'
|
||||||
|
|||||||
Reference in New Issue
Block a user