chore: Discard activities from email notifiable messages (#3989)

This commit is contained in:
Sojan Jose
2022-02-15 18:15:45 +05:30
committed by GitHub
parent 505c93c467
commit 5ad7e93059
2 changed files with 9 additions and 1 deletions

View File

@@ -137,7 +137,8 @@ class Message < ApplicationRecord
end
def email_notifiable_message?
return false if private? || incoming?
return false if private?
return false if %w[outgoing template].exclude?(message_type)
return false if template? && %w[input_csat text].exclude?(content_type)
true

View File

@@ -111,6 +111,7 @@ RSpec.describe Message, type: :model do
it 'return false if private message' do
message.private = true
message.message_type = 'outgoing'
expect(message.email_notifiable_message?).to be false
end
@@ -120,6 +121,12 @@ RSpec.describe Message, type: :model do
expect(message.email_notifiable_message?).to be false
end
it 'return false if activity message' do
message.private = false
message.message_type = 'activity'
expect(message.email_notifiable_message?).to be false
end
it 'return false if message type is template and content type is not input_csat or text' do
message.private = false
message.message_type = 'template'