fix: Check body exists before deleting null bytes in Twilio (#7910)
This commit is contained in:
@@ -47,7 +47,7 @@ class Twilio::IncomingMessageService
|
|||||||
end
|
end
|
||||||
|
|
||||||
def message_body
|
def message_body
|
||||||
params[:Body].delete("\u0000")
|
params[:Body]&.delete("\u0000")
|
||||||
end
|
end
|
||||||
|
|
||||||
def set_contact
|
def set_contact
|
||||||
|
|||||||
@@ -37,6 +37,18 @@ describe Twilio::IncomingMessageService do
|
|||||||
expect(conversation.reload.messages.last.content).to eq('remove null bytes')
|
expect(conversation.reload.messages.last.content).to eq('remove null bytes')
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it 'wont throw error when the body is empty' do
|
||||||
|
params = {
|
||||||
|
SmsSid: 'SMxx',
|
||||||
|
From: '+12345',
|
||||||
|
AccountSid: 'ACxxx',
|
||||||
|
MessagingServiceSid: twilio_channel.messaging_service_sid
|
||||||
|
}
|
||||||
|
|
||||||
|
described_class.new(params: params).perform
|
||||||
|
expect(conversation.reload.messages.last.content).to be_nil
|
||||||
|
end
|
||||||
|
|
||||||
it 'creates a new conversation' do
|
it 'creates a new conversation' do
|
||||||
params = {
|
params = {
|
||||||
SmsSid: 'SMxx',
|
SmsSid: 'SMxx',
|
||||||
|
|||||||
Reference in New Issue
Block a user