fix: Check body exists before deleting null bytes in Twilio (#7910)

This commit is contained in:
Muhsin Keloth
2023-09-13 13:40:26 +05:30
committed by GitHub
parent 0245e01763
commit 18e9e771b5
2 changed files with 13 additions and 1 deletions

View File

@@ -47,7 +47,7 @@ class Twilio::IncomingMessageService
end
def message_body
params[:Body].delete("\u0000")
params[:Body]&.delete("\u0000")
end
def set_contact

View File

@@ -37,6 +37,18 @@ describe Twilio::IncomingMessageService do
expect(conversation.reload.messages.last.content).to eq('remove null bytes')
end
it 'wont throw error when the body is empty' do
params = {
SmsSid: 'SMxx',
From: '+12345',
AccountSid: 'ACxxx',
MessagingServiceSid: twilio_channel.messaging_service_sid
}
described_class.new(params: params).perform
expect(conversation.reload.messages.last.content).to be_nil
end
it 'creates a new conversation' do
params = {
SmsSid: 'SMxx',