LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Feature: Conversation Continuity with Email (#770)

Browse Source 
* Added POC for mail inbox reply email
* created mailbox and migratuion for the same
* cleaned up sidekiq queues and added the queues for action mailbox and active storage
* created conversation mailbox and functionlaity to create a message on the conversation when it's replied

* Added UUID to conversation to be used in email replies

* added migration to add uuid for conversation
* changed parsing and resource fetching to reflect matching uuid and
  loading conversation alone
* cleaned up conversation mailbox.rb

* Added content type & attribute for message

* Added the new reply email to outgoing emails
* Added migration to accounts for adding domain and settings
* Modified seeds to reflect this changes
* Added the flag based column on account for boolean settings
* Added the new reply to email in outgoing conversation emails based on conditions

* Added dynamic email routing in application mailbox
* Added dynamic email routing in application mailbox
* Added a catch all deafult empty mailbox
* Added annotation for account

* Added the complete email details & attachments to the message
* Added the complete email details to the message in content_attributes, like subject, to, cc, bcc etc
* Modified the mail extractor to give a serilaized version of email
* Handled storing attachments of email on the message

* Added incoming email settings, env variables

* [#138] Added documentation regarding different email settings and variables

* Fixed the mail attachments blob issue (#138)
* Decoided attachments were strings and had to construct blobs out fo them to work with active storage
* Fixed the content encoding issue with mail body
* Fixed issue with Proc used in apllication mailbox routing
* Fixed couple of typos and silly mistakes

* Set appropriate from email for conversation reply mails (#138)
* From email was taken from a env variable, changed it to take from account settings if enabled
* Set the reply to email correctly based on conversation UUID
* Added commented config ind development.rb for mailbox ingress

* Added account settings for domain and support email (#138)
* Added the new attributes in accounts controller params whitelisting, api responses
* Added options for the the new fields in account settings

* Fixed typos in email continuity docs and warnings

* Added specs for conversation reply mailer changes (#138)
* Added specs for
  * conversation reply mailer
  * Accounts controller
  * Account and Conversation models

* Added tests for email presenter (#138)

* Specs for inbound email routing and mailboxes (#138)
This commit is contained in:
Sony Mathew
2020-04-30 20:20:26 +05:30
committed by GitHub
parent 0cb7333977
commit 0b65526b85
34 changed files with 1858 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/api/v1/accounts/accounts_controller.rb
View File

@@ -31,7 +31,7 @@ class Api::V1::Accounts::AccountsController < Api::BaseController
end
def update
@account.update!(account_params.slice(:name, :locale))
@account.update!(account_params.slice(:name, :locale, :domain, :support_email, :domain_emails_enabled))
end
private
@@ -45,7 +45,7 @@ class Api::V1::Accounts::AccountsController < Api::BaseController
end
def account_params
params.permit(:account_name, :email, :name, :locale)
params.permit(:account_name, :email, :name, :locale, :domain, :support_email, :domain_emails_enabled)
end
def check_signup_enabled

19
app/javascript/dashboard/i18n/locale/en/generalSettings.json
View File

@@ -21,6 +21,25 @@
"LABEL": "Site language (Beta)",
"PLACEHOLDER": "Your account name",
"ERROR": ""
},
"DOMAIN": {
"LABEL": "Domain",
"PLACEHOLDER": "Your website domain",
"ERROR": ""
},
"SUPPORT_EMAIL": {
"LABEL": "Support Email",
"PLACEHOLDER": "Your company's support email",
"ERROR": ""
},
"ENABLE_DOMAIN_EMAIL": {
"LABEL": "Enable domain email",
"PLACEHOLDER": "Enable the custom domain email",
"ERROR": "",
"OPTIONS": {
"ENABLED": "Enabled",
"DISABLED": "Disabled"
}
}
}
}

58
app/javascript/dashboard/routes/dashboard/settings/account/Index.vue
View File

@@ -33,6 +33,46 @@
{{ $t('GENERAL_SETTINGS.FORM.LANGUAGE.ERROR') }}
</span>
</label>
<label>
{{ $t('GENERAL_SETTINGS.FORM.DOMAIN.LABEL') }}
<input
v-model="domain"
type="text"
:placeholder="$t('GENERAL_SETTINGS.FORM.DOMAIN.PLACEHOLDER')"
/>
</label>
<label>
{{ $t('GENERAL_SETTINGS.FORM.ENABLE_DOMAIN_EMAIL.LABEL') }}
<select v-model="domainEmailsEnabled">
<option value="true">
{{
$t(
'GENERAL_SETTINGS.FORM.ENABLE_DOMAIN_EMAIL.OPTIONS.ENABLED'
)
}}
</option>
<option value="false">
{{
$t(
'GENERAL_SETTINGS.FORM.ENABLE_DOMAIN_EMAIL.OPTIONS.DISABLED'
)
}}
</option>
</select>
<p class="help-text">
{{ $t('GENERAL_SETTINGS.FORM.ENABLE_DOMAIN_EMAIL.PLACEHOLDER') }}
</p>
</label>
<label>
{{ $t('GENERAL_SETTINGS.FORM.SUPPORT_EMAIL.LABEL') }}
<input
v-model="supportEmail"
type="text"
:placeholder="
$t('GENERAL_SETTINGS.FORM.SUPPORT_EMAIL.PLACEHOLDER')
"
/>
</label>
</div>
</div>
<woot-submit-button
@@ -59,6 +99,9 @@ export default {
id: '',
name: '',
locale: 'en',
domain: '',
domainEmailsEnabled: false,
supportEmail: '',
};
},
validations: {
@@ -91,12 +134,22 @@ export default {
if (accountId) {
await this.$store.dispatch('accounts/get');
const { name, locale, id } = this.getAccount(accountId);
const {
name,
locale,
id,
domain,
support_email,
domain_emails_enabled,
} = this.getAccount(accountId);
Vue.config.lang = locale;
this.name = name;
this.locale = locale;
this.id = id;
this.domain = domain;
this.supportEmail = support_email;
this.domainEmailsEnabled = domain_emails_enabled;
}
},
@@ -110,6 +163,9 @@ export default {
await this.$store.dispatch('accounts/update', {
locale: this.locale,
name: this.name,
domain: this.domain,
support_email: this.supportEmail,
domain_emails_enabled: this.domainEmailsEnabled,
});
Vue.config.lang = this.locale;
this.showAlert(this.$t('GENERAL_SETTINGS.UPDATE.SUCCESS'));

28
app/mailboxes/application_mailbox.rb Normal file
View File

@@ -0,0 +1,28 @@
class ApplicationMailbox < ActionMailbox::Base
# Last part is the regex for the UUID
# Eg: email should be something like : reply+to+6bdc3f4d-0bec-4515-a284-5d916fdde489@domain.com
REPLY_EMAIL_USERNAME_PATTERN = /^reply\+to\+([0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12})$/i.freeze
def self.reply_match_proc
proc do |inbound_mail_obj|
is_a_reply_email = false
inbound_mail_obj.mail.to.each do |email|
username = email.split('@')[0]
match_result = username.match(REPLY_EMAIL_USERNAME_PATTERN)
if match_result
is_a_reply_email = true
break
end
end
is_a_reply_email
end
end
def self.default_mail_proc
proc { |_mail| true }
end
# routing should be defined below the referenced procs
routing(reply_match_proc => :conversation)
routing(default_mail_proc => :default)
end

76
app/mailboxes/conversation_mailbox.rb Normal file
View File

@@ -0,0 +1,76 @@
class ConversationMailbox < ApplicationMailbox
attr_accessor :conversation_uuid, :processed_mail
# Last part is the regex for the UUID
# Eg: email should be something like : reply+to+6bdc3f4d-0bec-4515-a284-5d916fdde489@domain.com
EMAIL_PART_PATTERN = /^reply\+to\+([0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12})$/i.freeze
before_processing :conversation_uuid_from_to_address,
:verify_decoded_params,
:find_conversation,
:decorate_mail
def process
create_message
add_attachments_to_message
end
private
def create_message
@message = @conversation.messages.create(
account_id: @conversation.account_id,
contact_id: @conversation.contact_id,
content: processed_mail.content,
inbox_id: @conversation.inbox_id,
message_type: 'incoming',
content_type: 'incoming_email',
source_id: processed_mail.message_id,
content_attributes: {
email: processed_mail.serialized_data
}
)
end
def add_attachments_to_message
processed_mail.attachments.each do |mail_attachment|
attachment = @message.attachments.new(
account_id: @conversation.account_id,
file_type: 'file'
)
attachment.file.attach(mail_attachment[:blob])
end
@message.save!
end
def conversation_uuid_from_to_address
mail.to.each do |email|
username = email.split('@')[0]
match_result = username.match(ApplicationMailbox::REPLY_EMAIL_USERNAME_PATTERN)
if match_result
@conversation_uuid = match_result.captures
break
end
end
@conversation_uuid
end
def verify_decoded_params
raise 'Conversation uuid not found' if conversation_uuid.nil?
end
def find_conversation
@conversation = Conversation.find_by(uuid: conversation_uuid)
validate_resource @conversation
end
def validate_resource(resource)
raise "#{resource.class.name} not found" if resource.nil?
resource
end
def decorate_mail
@processed_mail = MailPresenter.new(mail)
end
end

3
app/mailboxes/default_mailbox.rb Normal file
View File

@@ -0,0 +1,3 @@
class DefaultMailbox < ApplicationMailbox
def process; end
end

22
app/mailers/conversation_reply_mailer.rb
View File

@@ -15,7 +15,7 @@ class ConversationReplyMailer < ApplicationMailer
@messages = recap_messages + new_messages
@messages = @messages.select(&:reportable?)
mail(to: @contact&.email, reply_to: @agent&.email, subject: mail_subject(@messages.last))
mail(to: @contact&.email, from: from_email, reply_to: reply_email, subject: mail_subject(@messages.last))
end
private
@@ -24,4 +24,24 @@ class ConversationReplyMailer < ApplicationMailer
subject_line = last_message&.content&.truncate(trim_length) || 'New messages on this conversation'
"[##{@conversation.display_id}] #{subject_line}"
end
def reply_email
if custom_domain_email_enabled?
"reply+to+#{@conversation.uuid}@#{@conversation.account.domain}"
else
@agent&.email
end
end
def from_email
if custom_domain_email_enabled? && @conversation.account.support_email.present?
@conversation.account.support_email
else
ENV.fetch('MAILER_SENDER_EMAIL', 'accounts@chatwoot.com')
end
end
def custom_domain_email_enabled?
@custom_domain_email_enabled ||= @conversation.account.domain_emails_enabled? && @conversation.account.domain.present?
end
end

25
app/models/account.rb
View File

@@ -2,17 +2,31 @@
#
# Table name: accounts
#
# id :integer not null, primary key
# locale :integer default("en")
# name :string not null
# created_at :datetime not null
# updated_at :datetime not null
# id :integer not null, primary key
# domain :string(100)
# locale :integer default("en")
# name :string not null
# settings_flags :integer default(0), not null
# support_email :string(100)
# created_at :datetime not null
# updated_at :datetime not null
#
class Account < ApplicationRecord
# used for single column multi flags
include FlagShihTzu
include Events::Types
include Reportable
DEFAULT_QUERY_SETTING = {
flag_query_mode: :bit_operator
}.freeze
ACCOUNT_SETTINGS_FLAGS = {
1 => :domain_emails_enabled
}.freeze
validates :name, presence: true
has_many :account_users, dependent: :destroy
@@ -31,6 +45,7 @@ class Account < ApplicationRecord
has_many :webhooks, dependent: :destroy
has_one :subscription, dependent: :destroy
has_many :notification_settings, dependent: :destroy
has_flags ACCOUNT_SETTINGS_FLAGS.merge(column: 'settings_flags').merge(DEFAULT_QUERY_SETTING)
enum locale: LANGUAGES_CONFIG.map { |key, val| [val[:iso_639_1_code], key] }.to_h

1
app/models/conversation.rb
View File

@@ -8,6 +8,7 @@
# locked :boolean default(FALSE)
# status :integer default("open"), not null
# user_last_seen_at :datetime
# uuid :uuid not null
# created_at :datetime not null
# updated_at :datetime not null
# account_id :integer not null

5
app/models/message.rb
View File

@@ -51,10 +51,11 @@ class Message < ApplicationRecord
input_select: 4,
cards: 5,
form: 6,
article: 7
article: 7,
incoming_email: 8
}
enum status: { sent: 0, delivered: 1, read: 2, failed: 3 }
store :content_attributes, accessors: [:submitted_email, :items, :submitted_values], coder: JSON
store :content_attributes, accessors: [:submitted_email, :items, :submitted_values, :email], coder: JSON
# .succ is a hack to avoid https://makandracards.com/makandra/1057-why-two-ruby-time-objects-are-not-equal-although-they-appear-to-be
scope :unread_since, ->(datetime) { where('EXTRACT(EPOCH FROM created_at) > (?)', datetime.to_i.succ) }

59
app/presenters/mail_presenter.rb Normal file
View File

@@ -0,0 +1,59 @@
class MailPresenter < SimpleDelegator
attr_accessor :mail
def initialize(mail)
super(mail)
@mail = mail
end
def subject
encode_to_unicode(@mail.subject)
end
def content
return @decoded_content if @decoded_content
@decoded_content = parts.present? ? parts[0].body.decoded : decoded
@decoded_content = encode_to_unicode(@decoded_content)
@decoded_content
end
def attachments
# ref : https://github.com/gorails-screencasts/action-mailbox-action-text/blob/master/app/mailboxes/posts_mailbox.rb
mail.attachments.map do |attachment|
blob = ActiveStorage::Blob.create_after_upload!(
io: StringIO.new(attachment.body.to_s),
filename: attachment.filename,
content_type: attachment.content_type
)
{ original: attachment, blob: blob }
end
end
def number_of_attachments
mail.attachments.count
end
def serialized_data
{
content: content,
number_of_attachments: number_of_attachments,
subject: subject,
date: date,
to: to,
from: from,
in_reply_to: in_reply_to,
cc: cc,
bcc: bcc,
message_id: message_id
}
end
private
# forcing the encoding of the content to UTF-8 so as to be compatible with database and serializers
def encode_to_unicode(str)
current_encoding = str.encoding.name
str.encode(current_encoding, 'UTF-8', invalid: :replace, undef: :replace, replace: '?')
end
end

3
app/views/api/v1/accounts/show.json.jbuilder
View File

@@ -1,3 +1,6 @@
json.id @account.id
json.name @account.name
json.locale @account.locale
json.domain @account.domain
json.domain_emails_enabled @account.domain_emails_enabled
json.support_email @account.support_email

3
app/views/api/v1/accounts/update.json.jbuilder
View File

@@ -1,3 +1,6 @@
json.id @account.id
json.name @account.name
json.locale @account.locale
json.domain @account.domain
json.domain_emails_enabled @account.domain_emails_enabled
json.support_email @account.support_email