bd732f1fa9
# Pull Request Template ## Description Reply suggestions uses `search_documentation`. While this is useful, there is a subtle bug, a user's message may be in a different language (say spanish) than the FAQs present (english). This results in embedding search in spanish and compared against english vectors, which results in poor retrieval and poor suggestions. Fixes # (issue) This PR fixes the above behaviour by making a small llm call translate the query before searching in the search documentation tool ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. before: <img width="894" height="157" alt="image" src="https://github.com/user-attachments/assets/83871ee5-511e-4432-8b99-39e803759f63" /> after: <img width="1149" height="294" alt="image" src="https://github.com/user-attachments/assets/f9617d7a-6d48-4ca1-ad1c-2181e16c1f3d" /> test on rails console: <img width="2094" height="380" alt="image" src="https://github.com/user-attachments/assets/159fdaa5-8808-49d2-be5d-304d69fa97f7" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
52 lines
2.1 KiB
Ruby
52 lines
2.1 KiB
Ruby
module Captain::ToolInstrumentation
|
|
extend ActiveSupport::Concern
|
|
include Integrations::LlmInstrumentationConstants
|
|
|
|
private
|
|
|
|
# Custom instrumentation for tool flows - outputs just the message (not full hash)
|
|
def instrument_tool_session(params)
|
|
return yield unless ChatwootApp.otel_enabled?
|
|
|
|
response = nil
|
|
executed = false
|
|
tracer.in_span(params[:span_name]) do |span|
|
|
set_tool_session_attributes(span, params)
|
|
response = yield
|
|
executed = true
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_OUTPUT, response[:message] || response.to_json)
|
|
end
|
|
response
|
|
rescue StandardError => e
|
|
ChatwootExceptionTracker.new(e, account: account).capture_exception
|
|
executed ? response : yield
|
|
end
|
|
|
|
def set_tool_session_attributes(span, params)
|
|
span.set_attribute(ATTR_LANGFUSE_USER_ID, params[:account_id].to_s) if params[:account_id]
|
|
span.set_attribute(ATTR_LANGFUSE_SESSION_ID, "#{params[:account_id]}_#{params[:conversation_id]}") if params[:conversation_id].present?
|
|
span.set_attribute(ATTR_LANGFUSE_TAGS, [params[:feature_name]].to_json)
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_INPUT, params[:messages].to_json)
|
|
end
|
|
|
|
def record_generation(chat, message, model)
|
|
return unless ChatwootApp.otel_enabled?
|
|
return unless message.respond_to?(:role) && message.role.to_s == 'assistant'
|
|
|
|
tracer.in_span("llm.#{event_name}.generation") do |span|
|
|
span.set_attribute(ATTR_GEN_AI_PROVIDER, 'openai')
|
|
span.set_attribute(ATTR_GEN_AI_REQUEST_MODEL, model)
|
|
span.set_attribute(ATTR_GEN_AI_USAGE_INPUT_TOKENS, message.input_tokens)
|
|
span.set_attribute(ATTR_GEN_AI_USAGE_OUTPUT_TOKENS, message.output_tokens) if message.respond_to?(:output_tokens)
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_INPUT, format_chat_messages(chat))
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_OUTPUT, message.content.to_s) if message.respond_to?(:content)
|
|
end
|
|
rescue StandardError => e
|
|
Rails.logger.warn "Failed to record generation: #{e.message}"
|
|
end
|
|
|
|
def format_chat_messages(chat)
|
|
chat.messages[0...-1].map { |m| { role: m.role.to_s, content: m.content.to_s } }.to_json
|
|
end
|
|
end
|