b4b308336f
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
101 lines
2.5 KiB
Vue
101 lines
2.5 KiB
Vue
<script>
|
|
import Modal from 'dashboard/components/Modal.vue';
|
|
import { useVuelidate } from '@vuelidate/core';
|
|
import { required, minLength } from '@vuelidate/validators';
|
|
|
|
export default {
|
|
components: {
|
|
Modal,
|
|
},
|
|
props: {
|
|
show: {
|
|
type: Boolean,
|
|
default: true,
|
|
},
|
|
isCreating: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
},
|
|
setup() {
|
|
return { v$: useVuelidate() };
|
|
},
|
|
data() {
|
|
return {
|
|
attributeValue: '',
|
|
attributeName: '',
|
|
};
|
|
},
|
|
validations: {
|
|
attributeName: {
|
|
required,
|
|
minLength: minLength(2),
|
|
},
|
|
},
|
|
computed: {
|
|
attributeNameError() {
|
|
if (this.v$.attributeName.$error) {
|
|
return this.$t('CUSTOM_ATTRIBUTES.FORM.NAME.ERROR');
|
|
}
|
|
return '';
|
|
},
|
|
},
|
|
methods: {
|
|
addCustomAttribute() {
|
|
this.$emit('create', {
|
|
attributeValue: this.attributeValue,
|
|
attributeName: this.attributeName || '',
|
|
});
|
|
this.reset();
|
|
this.$emit('cancel');
|
|
},
|
|
onClose() {
|
|
this.reset();
|
|
this.$emit('cancel');
|
|
},
|
|
reset() {
|
|
this.attributeValue = '';
|
|
this.attributeName = '';
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<!-- eslint-disable vue/no-mutating-props -->
|
|
<template>
|
|
<Modal :show.sync="show" :on-close="onClose">
|
|
<woot-modal-header
|
|
:header-title="$t('CUSTOM_ATTRIBUTES.ADD.TITLE')"
|
|
:header-content="$t('CUSTOM_ATTRIBUTES.ADD.DESC')"
|
|
/>
|
|
<form class="w-full" @submit.prevent="addCustomAttribute">
|
|
<woot-input
|
|
v-model.trim="attributeName"
|
|
:class="{ error: v$.attributeName.$error }"
|
|
class="w-full"
|
|
:error="attributeNameError"
|
|
:label="$t('CUSTOM_ATTRIBUTES.FORM.NAME.LABEL')"
|
|
:placeholder="$t('CUSTOM_ATTRIBUTES.FORM.NAME.PLACEHOLDER')"
|
|
@input="v$.attributeName.$touch"
|
|
/>
|
|
<woot-input
|
|
v-model.trim="attributeValue"
|
|
class="w-full"
|
|
:label="$t('CUSTOM_ATTRIBUTES.FORM.VALUE.LABEL')"
|
|
:placeholder="$t('CUSTOM_ATTRIBUTES.FORM.VALUE.PLACEHOLDER')"
|
|
/>
|
|
<div class="flex items-center justify-end gap-2 px-0 py-2">
|
|
<woot-button
|
|
:is-disabled="v$.attributeName.$invalid || isCreating"
|
|
:is-loading="isCreating"
|
|
>
|
|
{{ $t('CUSTOM_ATTRIBUTES.FORM.CREATE') }}
|
|
</woot-button>
|
|
<woot-button variant="clear" @click.prevent="onClose">
|
|
{{ $t('CUSTOM_ATTRIBUTES.FORM.CANCEL') }}
|
|
</woot-button>
|
|
</div>
|
|
</form>
|
|
</Modal>
|
|
</template>
|