# Pull Request Template ## Description This addresses #10842. It exposes `additional_attributes` in the conversations search endpoint, uses it in `SearchResultConversationsList` to pass `conversation.additional_attributes?.mail_subject` down to `SearchResultConversationItem`, which in turn displays it. Fixes #10842 ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? I have tested this locally by searching for conversations. See this screenshot where I searched for "noreply":  I would love to add automated tests but I’m not sure how to do that. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Co-authored-by: iamsivin <iamsivin@gmail.com>
31 lines
906 B
JSON
31 lines
906 B
JSON
{
|
|
"SEARCH": {
|
|
"TABS": {
|
|
"ALL": "All",
|
|
"CONTACTS": "Contacts",
|
|
"CONVERSATIONS": "Conversations",
|
|
"MESSAGES": "Messages"
|
|
},
|
|
"SECTION": {
|
|
"CONTACTS": "Contacts",
|
|
"CONVERSATIONS": "Conversations",
|
|
"MESSAGES": "Messages"
|
|
},
|
|
"VIEW_MORE": "View more",
|
|
"LOAD_MORE": "Load more",
|
|
"SEARCHING_DATA": "Searching",
|
|
"LOADING_DATA": "Loading",
|
|
"EMPTY_STATE": "No {item} found for query '{query}'",
|
|
"EMPTY_STATE_FULL": "No results found for query '{query}'",
|
|
"PLACEHOLDER_KEYBINDING": "/ to focus",
|
|
"INPUT_PLACEHOLDER": "Type 3 or more characters to search",
|
|
"EMPTY_STATE_DEFAULT": "Search by conversation id, email, phone number, messages for better search results. ",
|
|
"BOT_LABEL": "Bot",
|
|
"READ_MORE": "Read more",
|
|
"WROTE": "wrote:",
|
|
"FROM": "from",
|
|
"EMAIL": "email",
|
|
"EMAIL_SUBJECT": "subject"
|
|
}
|
|
}
|