ef6ba8aabd
Upgrade rails to 7.2.2 so that we can proceed with the rails 8 upgrade afterwards # Changelog - `.circleci/config.yml` — align CI DB setup with GitHub Actions (`db:create` + `db:schema:load`) to avoid trigger-dependent prep steps. - `.rubocop.yml` — add `rubocop-rspec_rails` and disable new cops that don't match existing spec style. - `AGENTS.md` — document that specs should run without `.env` (rename temporarily when present). - `Gemfile` — upgrade to Rails 7.2, switch Azure storage gem, pin `commonmarker`, bump `sidekiq-cron`, add `rubocop-rspec_rails`, and relax some gem pins. - `Gemfile.lock` — dependency lockfile updates from the Rails 7.2 and gem changes. - `app/controllers/api/v1/accounts/integrations/linear_controller.rb` — stringify params before passing to the Linear service to keep key types stable. - `app/controllers/super_admin/instance_statuses_controller.rb` — use `MigrationContext` API for migration status in Rails 7.2. - `app/models/installation_config.rb` — add commentary on YAML serialization and future JSONB migration (no behavior change). - `app/models/integrations/hook.rb` — ensure hook type is set on create only and guard against missing app. - `app/models/user.rb` — update enum syntax for Rails 7.2 deprecation, serialize OTP backup codes with JSON, and use Ruby `alias`. - `app/services/crm/leadsquared/setup_service.rb` — stringify hook settings keys before merge to keep JSON shape consistent. - `app/services/macros/execution_service.rb` — remove macro-specific assignee activity workaround; rely on standard assignment handlers. - `config/application.rb` — load Rails 7.2 defaults. - `config/storage.yml` — update Azure Active Storage service name to `AzureBlob`. - `db/migrate/20230515051424_update_article_image_keys.rb` — use credentials `secret_key_base` with fallback to legacy secrets. - `docker/Dockerfile` — add `yaml-dev` and `pkgconf` packages for native extensions (Ruby 3.4 / psych). - `lib/seeders/reports/message_creator.rb` — add parentheses for clarity in range calculation. - `package.json` — pin Vite version and bump `vite-plugin-ruby`. - `pnpm-lock.yaml` — lockfile changes from JS dependency updates. - `spec/builders/v2/report_builder_spec.rb` — disable transactional fixtures; truncate tables per example via Rails `truncate_tables` so after_commit callbacks run with clean isolation; keep builder spec metadata minimal. - `spec/builders/v2/reports/label_summary_builder_spec.rb` — disable transactional fixtures + truncate tables via Rails `truncate_tables`; revert to real `resolved!`/`open!`/`resolved!` flow for multiple resolution events; align date range to `Time.zone` to avoid offset gaps; keep builder spec metadata minimal. - `spec/controllers/api/v1/accounts/macros_controller_spec.rb` — assert `assignee_id` instead of activity message to avoid transaction-timing flakes. - `spec/services/telegram/incoming_message_service_spec.rb` — reference the contact tied to the created conversation instead of `Contact.all.first` to avoid order-dependent failures when other specs leave data behind. - `spec/mailers/administrator_notifications/shared/smtp_config_shared.rb` — use `with_modified_env` instead of stubbing mailer internals. - `spec/services/account/sign_up_email_validation_service_spec.rb` — compare error `class.name` for parallel/reload-safe assertions.
107 lines
5.0 KiB
Ruby
107 lines
5.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe ContactInbox do
|
|
describe 'pubsub_token' do
|
|
let(:contact_inbox) { create(:contact_inbox) }
|
|
|
|
it 'gets created on object create' do
|
|
obj = contact_inbox
|
|
expect(obj.pubsub_token).not_to be_nil
|
|
end
|
|
|
|
it 'does not get updated on object update' do
|
|
obj = contact_inbox
|
|
old_token = obj.pubsub_token
|
|
obj.update(source_id: '234234323')
|
|
expect(obj.pubsub_token).to eq(old_token)
|
|
end
|
|
|
|
it 'backfills pubsub_token on call for older objects' do
|
|
obj = create(:contact_inbox)
|
|
# to replicate an object with out pubsub_token
|
|
# rubocop:disable Rails/SkipsModelValidations
|
|
obj.update_column(:pubsub_token, nil)
|
|
# rubocop:enable Rails/SkipsModelValidations
|
|
|
|
obj.reload
|
|
|
|
# ensure the column is nil in database
|
|
expect(described_class.where(id: obj.id).pick(:pubsub_token)).to be_nil
|
|
|
|
new_token = obj.pubsub_token
|
|
obj.update(source_id: '234234323')
|
|
# the generated token shoul be persisted in db
|
|
expect(obj.pubsub_token).to eq(new_token)
|
|
end
|
|
end
|
|
|
|
describe 'validations' do
|
|
context 'when source_id' do
|
|
it 'allows source_id longer than 255 characters for channels without format restrictions' do
|
|
long_source_id = 'a' * 300
|
|
email_inbox = create(:inbox, channel: create(:channel_email))
|
|
contact = create(:contact, account: email_inbox.account)
|
|
contact_inbox = build(:contact_inbox, contact: contact, inbox: email_inbox, source_id: long_source_id)
|
|
|
|
expect(contact_inbox.valid?).to be(true)
|
|
expect { contact_inbox.save! }.not_to raise_error
|
|
expect(contact_inbox.reload.source_id).to eq(long_source_id)
|
|
expect(contact_inbox.source_id.length).to eq(300)
|
|
end
|
|
|
|
it 'validates whatsapp channel source_id' do
|
|
whatsapp_inbox = create(:channel_whatsapp, sync_templates: false, validate_provider_config: false).inbox
|
|
contact = create(:contact)
|
|
valid_source_id = build(:contact_inbox, contact: contact, inbox: whatsapp_inbox, source_id: '1234567890')
|
|
ci_character_in_source_id = build(:contact_inbox, contact: contact, inbox: whatsapp_inbox, source_id: '1234567890aaa')
|
|
ci_plus_in_source_id = build(:contact_inbox, contact: contact, inbox: whatsapp_inbox, source_id: '+1234567890')
|
|
expect(valid_source_id.valid?).to be(true)
|
|
expect(ci_character_in_source_id.valid?).to be(false)
|
|
expect(ci_character_in_source_id.errors.full_messages).to eq(
|
|
['Source invalid source id for whatsapp inbox. valid Regex (?-mix:^\\d{1,15}\\z)']
|
|
)
|
|
expect(ci_plus_in_source_id.valid?).to be(false)
|
|
expect(ci_plus_in_source_id.errors.full_messages).to eq(
|
|
['Source invalid source id for whatsapp inbox. valid Regex (?-mix:^\\d{1,15}\\z)']
|
|
)
|
|
end
|
|
|
|
it 'validates twilio sms channel source_id' do
|
|
twilio_sms_inbox = create(:channel_twilio_sms).inbox
|
|
contact = create(:contact)
|
|
valid_source_id = build(:contact_inbox, contact: contact, inbox: twilio_sms_inbox, source_id: '+1234567890')
|
|
ci_character_in_source_id = build(:contact_inbox, contact: contact, inbox: twilio_sms_inbox, source_id: '+1234567890aaa')
|
|
ci_without_plus_in_source_id = build(:contact_inbox, contact: contact, inbox: twilio_sms_inbox, source_id: '1234567890')
|
|
expect(valid_source_id.valid?).to be(true)
|
|
expect(ci_character_in_source_id.valid?).to be(false)
|
|
expect(ci_character_in_source_id.errors.full_messages).to eq(
|
|
['Source invalid source id for twilio sms inbox. valid Regex (?-mix:^\\+\\d{1,15}\\z)']
|
|
)
|
|
expect(ci_without_plus_in_source_id.valid?).to be(false)
|
|
expect(ci_without_plus_in_source_id.errors.full_messages).to eq(
|
|
['Source invalid source id for twilio sms inbox. valid Regex (?-mix:^\\+\\d{1,15}\\z)']
|
|
)
|
|
end
|
|
|
|
it 'validates twilio whatsapp channel source_id' do
|
|
twilio_whatsapp_inbox = create(:channel_twilio_sms, medium: :whatsapp).inbox
|
|
contact = create(:contact)
|
|
valid_source_id = build(:contact_inbox, contact: contact, inbox: twilio_whatsapp_inbox, source_id: 'whatsapp:+1234567890')
|
|
ci_character_in_source_id = build(:contact_inbox, contact: contact, inbox: twilio_whatsapp_inbox, source_id: 'whatsapp:+1234567890aaa')
|
|
ci_without_plus_in_source_id = build(:contact_inbox, contact: contact, inbox: twilio_whatsapp_inbox, source_id: 'whatsapp:1234567890')
|
|
expect(valid_source_id.valid?).to be(true)
|
|
expect(ci_character_in_source_id.valid?).to be(false)
|
|
expect(ci_character_in_source_id.errors.full_messages).to eq(
|
|
['Source invalid source id for twilio whatsapp inbox. valid Regex (?-mix:^whatsapp:\\+\\d{1,15}\\z)']
|
|
)
|
|
expect(ci_without_plus_in_source_id.valid?).to be(false)
|
|
expect(ci_without_plus_in_source_id.errors.full_messages).to eq(
|
|
['Source invalid source id for twilio whatsapp inbox. valid Regex (?-mix:^whatsapp:\\+\\d{1,15}\\z)']
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|