ef6ba8aabd
Upgrade rails to 7.2.2 so that we can proceed with the rails 8 upgrade afterwards # Changelog - `.circleci/config.yml` — align CI DB setup with GitHub Actions (`db:create` + `db:schema:load`) to avoid trigger-dependent prep steps. - `.rubocop.yml` — add `rubocop-rspec_rails` and disable new cops that don't match existing spec style. - `AGENTS.md` — document that specs should run without `.env` (rename temporarily when present). - `Gemfile` — upgrade to Rails 7.2, switch Azure storage gem, pin `commonmarker`, bump `sidekiq-cron`, add `rubocop-rspec_rails`, and relax some gem pins. - `Gemfile.lock` — dependency lockfile updates from the Rails 7.2 and gem changes. - `app/controllers/api/v1/accounts/integrations/linear_controller.rb` — stringify params before passing to the Linear service to keep key types stable. - `app/controllers/super_admin/instance_statuses_controller.rb` — use `MigrationContext` API for migration status in Rails 7.2. - `app/models/installation_config.rb` — add commentary on YAML serialization and future JSONB migration (no behavior change). - `app/models/integrations/hook.rb` — ensure hook type is set on create only and guard against missing app. - `app/models/user.rb` — update enum syntax for Rails 7.2 deprecation, serialize OTP backup codes with JSON, and use Ruby `alias`. - `app/services/crm/leadsquared/setup_service.rb` — stringify hook settings keys before merge to keep JSON shape consistent. - `app/services/macros/execution_service.rb` — remove macro-specific assignee activity workaround; rely on standard assignment handlers. - `config/application.rb` — load Rails 7.2 defaults. - `config/storage.yml` — update Azure Active Storage service name to `AzureBlob`. - `db/migrate/20230515051424_update_article_image_keys.rb` — use credentials `secret_key_base` with fallback to legacy secrets. - `docker/Dockerfile` — add `yaml-dev` and `pkgconf` packages for native extensions (Ruby 3.4 / psych). - `lib/seeders/reports/message_creator.rb` — add parentheses for clarity in range calculation. - `package.json` — pin Vite version and bump `vite-plugin-ruby`. - `pnpm-lock.yaml` — lockfile changes from JS dependency updates. - `spec/builders/v2/report_builder_spec.rb` — disable transactional fixtures; truncate tables per example via Rails `truncate_tables` so after_commit callbacks run with clean isolation; keep builder spec metadata minimal. - `spec/builders/v2/reports/label_summary_builder_spec.rb` — disable transactional fixtures + truncate tables via Rails `truncate_tables`; revert to real `resolved!`/`open!`/`resolved!` flow for multiple resolution events; align date range to `Time.zone` to avoid offset gaps; keep builder spec metadata minimal. - `spec/controllers/api/v1/accounts/macros_controller_spec.rb` — assert `assignee_id` instead of activity message to avoid transaction-timing flakes. - `spec/services/telegram/incoming_message_service_spec.rb` — reference the contact tied to the created conversation instead of `Contact.all.first` to avoid order-dependent failures when other specs leave data behind. - `spec/mailers/administrator_notifications/shared/smtp_config_shared.rb` — use `with_modified_env` instead of stubbing mailer internals. - `spec/services/account/sign_up_email_validation_service_spec.rb` — compare error `class.name` for parallel/reload-safe assertions.
71 lines
2.6 KiB
Ruby
71 lines
2.6 KiB
Ruby
# == Schema Information
|
|
#
|
|
# Table name: installation_configs
|
|
#
|
|
# id :bigint not null, primary key
|
|
# locked :boolean default(TRUE), not null
|
|
# name :string not null
|
|
# serialized_value :jsonb not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_installation_configs_on_name (name) UNIQUE
|
|
# index_installation_configs_on_name_and_created_at (name,created_at) UNIQUE
|
|
#
|
|
class InstallationConfig < ApplicationRecord
|
|
# https://stackoverflow.com/questions/72970170/upgrading-to-rails-6-1-6-1-causes-psychdisallowedclass-tried-to-load-unspecif
|
|
# https://discuss.rubyonrails.org/t/cve-2022-32224-possible-rce-escalation-bug-with-serialized-columns-in-active-record/81017
|
|
# FIX ME : fixes breakage of installation config. we need to migrate.
|
|
# Fix configuration in application.rb
|
|
#
|
|
# Note: This whole thing is because we store the installation config serialized in YAML in Database
|
|
# This serialized version stores HashWithIndifferentAccess, We could avoid all this complexity if we store the value as JSONB
|
|
# We could also avoid this issue if we migrate the installation config to JSONB
|
|
# We should do this migration at some point in time.
|
|
serialize :serialized_value, coder: YAML, type: ActiveSupport::HashWithIndifferentAccess
|
|
|
|
before_validation :set_lock
|
|
validates :name, presence: true
|
|
validate :saml_sso_users_check, if: -> { name == 'ENABLE_SAML_SSO_LOGIN' }
|
|
|
|
# TODO: Get rid of default scope
|
|
# https://stackoverflow.com/a/1834250/939299
|
|
default_scope { order(created_at: :desc) }
|
|
scope :editable, -> { where(locked: false) }
|
|
|
|
after_commit :clear_cache
|
|
|
|
def value
|
|
# This is an extra hack again cause of the YAML serialization, in case of new object initialization in super admin
|
|
# It was throwing error as the default value of column '{}' was failing in deserialization.
|
|
return {}.with_indifferent_access if new_record? && @attributes['serialized_value']&.value_before_type_cast == '{}'
|
|
|
|
serialized_value[:value]
|
|
end
|
|
|
|
def value=(value_to_assigned)
|
|
self.serialized_value = {
|
|
value: value_to_assigned
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
private
|
|
|
|
def set_lock
|
|
self.locked = true if locked.nil?
|
|
end
|
|
|
|
def clear_cache
|
|
GlobalConfig.clear_cache
|
|
end
|
|
|
|
def saml_sso_users_check
|
|
return unless value == false || value == 'false'
|
|
return unless User.exists?(provider: 'saml')
|
|
|
|
errors.add(:base, 'Cannot disable SAML SSO login while users are using SAML authentication')
|
|
end
|
|
end
|