Upgrade rails to 7.2.2 so that we can proceed with the rails 8 upgrade afterwards # Changelog - `.circleci/config.yml` — align CI DB setup with GitHub Actions (`db:create` + `db:schema:load`) to avoid trigger-dependent prep steps. - `.rubocop.yml` — add `rubocop-rspec_rails` and disable new cops that don't match existing spec style. - `AGENTS.md` — document that specs should run without `.env` (rename temporarily when present). - `Gemfile` — upgrade to Rails 7.2, switch Azure storage gem, pin `commonmarker`, bump `sidekiq-cron`, add `rubocop-rspec_rails`, and relax some gem pins. - `Gemfile.lock` — dependency lockfile updates from the Rails 7.2 and gem changes. - `app/controllers/api/v1/accounts/integrations/linear_controller.rb` — stringify params before passing to the Linear service to keep key types stable. - `app/controllers/super_admin/instance_statuses_controller.rb` — use `MigrationContext` API for migration status in Rails 7.2. - `app/models/installation_config.rb` — add commentary on YAML serialization and future JSONB migration (no behavior change). - `app/models/integrations/hook.rb` — ensure hook type is set on create only and guard against missing app. - `app/models/user.rb` — update enum syntax for Rails 7.2 deprecation, serialize OTP backup codes with JSON, and use Ruby `alias`. - `app/services/crm/leadsquared/setup_service.rb` — stringify hook settings keys before merge to keep JSON shape consistent. - `app/services/macros/execution_service.rb` — remove macro-specific assignee activity workaround; rely on standard assignment handlers. - `config/application.rb` — load Rails 7.2 defaults. - `config/storage.yml` — update Azure Active Storage service name to `AzureBlob`. - `db/migrate/20230515051424_update_article_image_keys.rb` — use credentials `secret_key_base` with fallback to legacy secrets. - `docker/Dockerfile` — add `yaml-dev` and `pkgconf` packages for native extensions (Ruby 3.4 / psych). - `lib/seeders/reports/message_creator.rb` — add parentheses for clarity in range calculation. - `package.json` — pin Vite version and bump `vite-plugin-ruby`. - `pnpm-lock.yaml` — lockfile changes from JS dependency updates. - `spec/builders/v2/report_builder_spec.rb` — disable transactional fixtures; truncate tables per example via Rails `truncate_tables` so after_commit callbacks run with clean isolation; keep builder spec metadata minimal. - `spec/builders/v2/reports/label_summary_builder_spec.rb` — disable transactional fixtures + truncate tables via Rails `truncate_tables`; revert to real `resolved!`/`open!`/`resolved!` flow for multiple resolution events; align date range to `Time.zone` to avoid offset gaps; keep builder spec metadata minimal. - `spec/controllers/api/v1/accounts/macros_controller_spec.rb` — assert `assignee_id` instead of activity message to avoid transaction-timing flakes. - `spec/services/telegram/incoming_message_service_spec.rb` — reference the contact tied to the created conversation instead of `Contact.all.first` to avoid order-dependent failures when other specs leave data behind. - `spec/mailers/administrator_notifications/shared/smtp_config_shared.rb` — use `with_modified_env` instead of stubbing mailer internals. - `spec/services/account/sign_up_email_validation_service_spec.rb` — compare error `class.name` for parallel/reload-safe assertions.
136 lines
4.0 KiB
Ruby
136 lines
4.0 KiB
Ruby
class Api::V1::Accounts::Integrations::LinearController < Api::V1::Accounts::BaseController
|
|
before_action :fetch_conversation, only: [:create_issue, :link_issue, :unlink_issue, :linked_issues]
|
|
before_action :fetch_hook, only: [:destroy]
|
|
|
|
def destroy
|
|
revoke_linear_token
|
|
@hook.destroy!
|
|
head :ok
|
|
end
|
|
|
|
def teams
|
|
teams = linear_processor_service.teams
|
|
if teams[:error]
|
|
render json: { error: teams[:error] }, status: :unprocessable_entity
|
|
else
|
|
render json: teams[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
def team_entities
|
|
team_id = permitted_params[:team_id]
|
|
team_entities = linear_processor_service.team_entities(team_id)
|
|
if team_entities[:error]
|
|
render json: { error: team_entities[:error] }, status: :unprocessable_entity
|
|
else
|
|
render json: team_entities[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
def create_issue
|
|
issue = linear_processor_service.create_issue(permitted_params.to_h.stringify_keys, Current.user)
|
|
if issue[:error]
|
|
render json: { error: issue[:error] }, status: :unprocessable_entity
|
|
else
|
|
Linear::ActivityMessageService.new(
|
|
conversation: @conversation,
|
|
action_type: :issue_created,
|
|
issue_data: { id: issue[:data][:identifier] },
|
|
user: Current.user
|
|
).perform
|
|
render json: issue[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
def link_issue
|
|
issue_id = permitted_params[:issue_id]
|
|
title = permitted_params[:title]
|
|
issue = linear_processor_service.link_issue(conversation_link, issue_id, title, Current.user)
|
|
if issue[:error]
|
|
render json: { error: issue[:error] }, status: :unprocessable_entity
|
|
else
|
|
Linear::ActivityMessageService.new(
|
|
conversation: @conversation,
|
|
action_type: :issue_linked,
|
|
issue_data: { id: issue_id },
|
|
user: Current.user
|
|
).perform
|
|
render json: issue[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
def unlink_issue
|
|
link_id = permitted_params[:link_id]
|
|
issue_id = permitted_params[:issue_id]
|
|
issue = linear_processor_service.unlink_issue(link_id)
|
|
|
|
if issue[:error]
|
|
render json: { error: issue[:error] }, status: :unprocessable_entity
|
|
else
|
|
Linear::ActivityMessageService.new(
|
|
conversation: @conversation,
|
|
action_type: :issue_unlinked,
|
|
issue_data: { id: issue_id },
|
|
user: Current.user
|
|
).perform
|
|
render json: issue[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
def linked_issues
|
|
issues = linear_processor_service.linked_issues(conversation_link)
|
|
|
|
if issues[:error]
|
|
render json: { error: issues[:error] }, status: :unprocessable_entity
|
|
else
|
|
render json: issues[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
def search_issue
|
|
render json: { error: 'Specify search string with parameter q' }, status: :unprocessable_entity if params[:q].blank? && return
|
|
|
|
term = params[:q]
|
|
issues = linear_processor_service.search_issue(term)
|
|
if issues[:error]
|
|
render json: { error: issues[:error] }, status: :unprocessable_entity
|
|
else
|
|
render json: issues[:data], status: :ok
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def conversation_link
|
|
"#{ENV.fetch('FRONTEND_URL', nil)}/app/accounts/#{Current.account.id}/conversations/#{@conversation.display_id}"
|
|
end
|
|
|
|
def fetch_conversation
|
|
@conversation = Current.account.conversations.find_by!(display_id: permitted_params[:conversation_id])
|
|
end
|
|
|
|
def linear_processor_service
|
|
Integrations::Linear::ProcessorService.new(account: Current.account)
|
|
end
|
|
|
|
def permitted_params
|
|
params.permit(:team_id, :project_id, :conversation_id, :issue_id, :link_id, :title, :description, :assignee_id, :priority, :state_id,
|
|
label_ids: [])
|
|
end
|
|
|
|
def fetch_hook
|
|
@hook = Integrations::Hook.where(account: Current.account).find_by(app_id: 'linear')
|
|
end
|
|
|
|
def revoke_linear_token
|
|
return unless @hook&.access_token
|
|
|
|
begin
|
|
linear_client = Linear.new(@hook.access_token)
|
|
linear_client.revoke_token
|
|
rescue StandardError => e
|
|
Rails.logger.error "Failed to revoke Linear token: #{e.message}"
|
|
end
|
|
end
|
|
end
|