9cd7c4ef89
## Description Handle messages with null content properly in UI and email notifications ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) ## Relevant Screenshots: <img width="688" height="765" alt="Screenshot 2026-01-21 at 4 43 00 PM" src="https://github.com/user-attachments/assets/6a27c22e-2ae6-4377-a05d-cfa44bf181fe" /> ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches notification email templates and message rendering conditions; mistakes could lead to missing content/attachments in emails or incorrect UI visibility, but changes are localized and non-auth/security related. > > **Overview** > Agent notification emails for *assigned* and *participating* new messages now include the actual message details (sender name, rendered text when present, and attachment links) and gracefully fall back when content is unavailable. > > To support this, the mailer now passes `@message` into Liquid via `MessageDrop` (adding `attachments` URLs), and the dashboard message UI now renders failed/external-error messages even when `content` is `null` while tightening retry eligibility to require content or attachments (and still within 1 day). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 475c8cedda54eb5e806990f977faf8098d0b27d8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
60 lines
1.9 KiB
Vue
60 lines
1.9 KiB
Vue
<script setup>
|
|
import { computed } from 'vue';
|
|
import Icon from 'next/icon/Icon.vue';
|
|
import { useI18n } from 'vue-i18n';
|
|
import { useMessageContext } from './provider.js';
|
|
import { hasOneDayPassed } from 'shared/helpers/timeHelper';
|
|
import { ORIENTATION, MESSAGE_STATUS } from './constants';
|
|
|
|
defineProps({
|
|
error: { type: String, required: true },
|
|
});
|
|
|
|
const emit = defineEmits(['retry']);
|
|
|
|
const { orientation, status, createdAt, content, attachments } =
|
|
useMessageContext();
|
|
|
|
const { t } = useI18n();
|
|
|
|
const canRetry = computed(() => {
|
|
const hasContent = content.value !== null;
|
|
const hasAttachments = attachments.value && attachments.value.length > 0;
|
|
return !hasOneDayPassed(createdAt.value) && (hasContent || hasAttachments);
|
|
});
|
|
</script>
|
|
|
|
<template>
|
|
<div class="text-xs text-n-ruby-11 flex items-center gap-1.5">
|
|
<span>{{ t('CHAT_LIST.FAILED_TO_SEND') }}</span>
|
|
<div class="relative group">
|
|
<div
|
|
class="bg-n-alpha-2 rounded-md size-5 grid place-content-center cursor-pointer"
|
|
>
|
|
<Icon
|
|
icon="i-lucide-alert-triangle"
|
|
class="text-n-ruby-11 size-[14px]"
|
|
/>
|
|
</div>
|
|
<div
|
|
class="absolute bg-n-alpha-3 px-4 py-3 border rounded-xl border-n-strong text-n-slate-12 bottom-6 w-52 text-xs backdrop-blur-[100px] shadow-[0px_0px_24px_0px_rgba(0,0,0,0.12)] opacity-0 invisible group-hover:opacity-100 group-hover:visible transition-all break-all"
|
|
:class="{
|
|
'ltr:left-0 rtl:right-0': orientation === ORIENTATION.LEFT,
|
|
'ltr:right-0 rtl:left-0': orientation === ORIENTATION.RIGHT,
|
|
}"
|
|
>
|
|
{{ error }}
|
|
</div>
|
|
</div>
|
|
<button
|
|
v-if="canRetry"
|
|
type="button"
|
|
:disabled="status !== MESSAGE_STATUS.FAILED"
|
|
class="bg-n-alpha-2 rounded-md size-5 grid place-content-center cursor-pointer"
|
|
@click="emit('retry')"
|
|
>
|
|
<Icon icon="i-lucide-refresh-ccw" class="text-n-ruby-11 size-[14px]" />
|
|
</button>
|
|
</div>
|
|
</template>
|