# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
87 lines
2.4 KiB
Vue
87 lines
2.4 KiB
Vue
<script setup>
|
|
import { ref, computed } from 'vue';
|
|
|
|
import wootConstants from 'dashboard/constants/globals';
|
|
import SLAEventItem from './SLAEventItem.vue';
|
|
|
|
const props = defineProps({
|
|
slaMissedEvents: {
|
|
type: Array,
|
|
required: true,
|
|
},
|
|
});
|
|
|
|
const { SLA_MISS_TYPES } = wootConstants;
|
|
|
|
const shouldShowAllNrts = ref(false);
|
|
|
|
const frtMisses = computed(() =>
|
|
props.slaMissedEvents.filter(
|
|
slaEvent => slaEvent.event_type === SLA_MISS_TYPES.FRT
|
|
)
|
|
);
|
|
const nrtMisses = computed(() => {
|
|
const missedEvents = props.slaMissedEvents.filter(
|
|
slaEvent => slaEvent.event_type === SLA_MISS_TYPES.NRT
|
|
);
|
|
return shouldShowAllNrts.value ? missedEvents : missedEvents.slice(0, 6);
|
|
});
|
|
const rtMisses = computed(() =>
|
|
props.slaMissedEvents.filter(
|
|
slaEvent => slaEvent.event_type === SLA_MISS_TYPES.RT
|
|
)
|
|
);
|
|
|
|
const shouldShowMoreNRTButton = computed(() => nrtMisses.value.length > 6);
|
|
const toggleShowAllNRT = () => {
|
|
shouldShowAllNrts.value = !shouldShowAllNrts.value;
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div
|
|
class="absolute flex flex-col items-start bg-white dark:bg-slate-800 z-50 p-4 border border-solid border-slate-75 dark:border-slate-700 w-[384px] rounded-xl gap-4 max-h-96 overflow-auto"
|
|
>
|
|
<span class="text-sm font-medium text-slate-900 dark:text-slate-25">
|
|
{{ $t('SLA.EVENTS.TITLE') }}
|
|
</span>
|
|
<SLAEventItem
|
|
v-if="frtMisses.length"
|
|
:label="$t('SLA.EVENTS.FRT')"
|
|
:items="frtMisses"
|
|
/>
|
|
<SLAEventItem
|
|
v-if="nrtMisses.length"
|
|
:label="$t('SLA.EVENTS.NRT')"
|
|
:items="nrtMisses"
|
|
>
|
|
<template #showMore>
|
|
<div
|
|
v-if="shouldShowMoreNRTButton"
|
|
class="flex flex-col items-end w-full"
|
|
>
|
|
<woot-button
|
|
size="small"
|
|
:icon="!shouldShowAllNrts ? 'plus-sign' : ''"
|
|
variant="link"
|
|
color-scheme="secondary"
|
|
class="hover:!no-underline !gap-1 hover:!bg-transparent dark:hover:!bg-transparent"
|
|
@click="toggleShowAllNRT"
|
|
>
|
|
{{
|
|
shouldShowAllNrts
|
|
? $t('SLA.EVENTS.HIDE', { count: nrtMisses.length })
|
|
: $t('SLA.EVENTS.SHOW_MORE', { count: nrtMisses.length })
|
|
}}
|
|
</woot-button>
|
|
</div>
|
|
</template>
|
|
</SLAEventItem>
|
|
<SLAEventItem
|
|
v-if="rtMisses.length"
|
|
:label="$t('SLA.EVENTS.RT')"
|
|
:items="rtMisses"
|
|
/>
|
|
</div>
|
|
</template>
|