04c456e0a3
## Description Fixes `Avatar::AvatarFromUrlJob` logging 404 errors as ERROR when avatars don't exist ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Small logging-only behavior change that doesn’t affect attachment flow or persisted data beyond existing sync-attribute updates. > > **Overview** > Updates `Avatar::AvatarFromUrlJob` error handling to treat `Down::NotFound` (404/missing avatar URL) as a non-error: it now logs an INFO message instead of logging as ERROR. > > Other `Down::Error` failures continue to be logged as ERROR, and the job still runs `update_avatar_sync_attributes` in `ensure`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 675f41041ae3dd4ead6e0dee5f1586dcad9750cd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
87 lines
2.7 KiB
Ruby
87 lines
2.7 KiB
Ruby
# Downloads and attaches avatar images from a URL.
|
|
# Notes:
|
|
# - For contact objects, we use `additional_attributes` to rate limit the
|
|
# job and track state.
|
|
# - We save the hash of the synced URL to retrigger downloads only when
|
|
# there is a change in the underlying asset.
|
|
# - A 1 minute rate limit window is enforced via `last_avatar_sync_at`.
|
|
class Avatar::AvatarFromUrlJob < ApplicationJob
|
|
include UrlHelper
|
|
queue_as :purgable
|
|
|
|
MAX_DOWNLOAD_SIZE = 15 * 1024 * 1024
|
|
RATE_LIMIT_WINDOW = 1.minute
|
|
|
|
def perform(avatarable, avatar_url)
|
|
return unless avatarable.respond_to?(:avatar)
|
|
return unless url_valid?(avatar_url)
|
|
|
|
return unless should_sync_avatar?(avatarable, avatar_url)
|
|
|
|
avatar_file = Down.download(avatar_url, max_size: MAX_DOWNLOAD_SIZE)
|
|
raise Down::Error, 'Invalid file' unless valid_file?(avatar_file)
|
|
|
|
avatarable.avatar.attach(
|
|
io: avatar_file,
|
|
filename: avatar_file.original_filename,
|
|
content_type: avatar_file.content_type
|
|
)
|
|
|
|
rescue Down::NotFound
|
|
Rails.logger.info "AvatarFromUrlJob: avatar not found at #{avatar_url}"
|
|
rescue Down::Error => e
|
|
Rails.logger.error "AvatarFromUrlJob error for #{avatar_url}: #{e.class} - #{e.message}"
|
|
ensure
|
|
update_avatar_sync_attributes(avatarable, avatar_url)
|
|
end
|
|
|
|
private
|
|
|
|
def should_sync_avatar?(avatarable, avatar_url)
|
|
# Only Contacts are rate-limited and hash-gated.
|
|
return true unless avatarable.is_a?(Contact)
|
|
|
|
attrs = avatarable.additional_attributes || {}
|
|
|
|
return false if within_rate_limit?(attrs)
|
|
return false if duplicate_url?(attrs, avatar_url)
|
|
|
|
true
|
|
end
|
|
|
|
def within_rate_limit?(attrs)
|
|
ts = attrs['last_avatar_sync_at']
|
|
return false if ts.blank?
|
|
|
|
Time.zone.parse(ts) > RATE_LIMIT_WINDOW.ago
|
|
end
|
|
|
|
def duplicate_url?(attrs, avatar_url)
|
|
stored_hash = attrs['avatar_url_hash']
|
|
stored_hash.present? && stored_hash == generate_url_hash(avatar_url)
|
|
end
|
|
|
|
def generate_url_hash(url)
|
|
Digest::SHA256.hexdigest(url)
|
|
end
|
|
|
|
def update_avatar_sync_attributes(avatarable, avatar_url)
|
|
# Only Contacts have sync attributes persisted
|
|
return unless avatarable.is_a?(Contact)
|
|
return if avatar_url.blank?
|
|
|
|
additional_attributes = avatarable.additional_attributes || {}
|
|
additional_attributes['last_avatar_sync_at'] = Time.current.iso8601
|
|
additional_attributes['avatar_url_hash'] = generate_url_hash(avatar_url)
|
|
|
|
# Persist without triggering validations that may fail due to avatar file checks
|
|
avatarable.update_columns(additional_attributes: additional_attributes) # rubocop:disable Rails/SkipsModelValidations
|
|
end
|
|
|
|
def valid_file?(file)
|
|
return false if file.original_filename.blank?
|
|
|
|
true
|
|
end
|
|
end
|