This PR adds a cleaner re-authorization flow to Microsoft. This PR has the following changes 1. Use `reauthorization_required` value for Microsoft Channel 2. Refactor `InboxReconnectionRequired` to reuse the `banner` component 3. Refactor `microsoft/Reauthorize.vue` to reuse `InboxReconnectionRequired` component 4. Update `reauthorizable.rb` to update cache keys if the model has an inbox 5. Update `microsoft/callbacks_controller.rb` to handle the reauthorization case with a redirect to the inbox settings page if the inbox already exists at the time of authorization. ## How Has This Been Tested? - [x] Local Instance - [ ] Staging Instance - [x] Unit tests ## Pending Tasks - [ ] ~Success Toast~ will do this in a follow-up PR with the screen ## Demo The following video shows the whole process of creation and re-authorization of the Microsoft channel https://www.loom.com/share/e5cd9bd4439c4741b0dcfe66d67f88b3?sid=100f3642-43e4-46b3-8123-88a5dd9d8509 --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
91 lines
3.2 KiB
Ruby
91 lines
3.2 KiB
Ruby
# This concern is primarily targeted for business models dependent on external services
|
|
# The auth tokens we obtained on their behalf could expire or becomes invalid.
|
|
# We would be aware of it until we make the API call to the service and it throws error
|
|
|
|
# Example:
|
|
# when a user changes his/her password, the auth token they provided to chatwoot becomes invalid
|
|
|
|
# This module helps to capture the errors into a counter and when threshold is passed would mark
|
|
# the object to be reauthorized. We will also send an email to the owners alerting them of the error.
|
|
|
|
# In the UI, we will check for the reauthorization_required? status and prompt the reauthorization flow
|
|
|
|
module Reauthorizable
|
|
extend ActiveSupport::Concern
|
|
|
|
AUTHORIZATION_ERROR_THRESHOLD = 2
|
|
|
|
# model attribute
|
|
def reauthorization_required?
|
|
::Redis::Alfred.get(reauthorization_required_key).present?
|
|
end
|
|
|
|
# model attribute
|
|
def authorization_error_count
|
|
::Redis::Alfred.get(authorization_error_count_key).to_i
|
|
end
|
|
|
|
# action to be performed when we receive authorization errors
|
|
# Implement in your exception handling logic for authorization errors
|
|
def authorization_error!
|
|
::Redis::Alfred.incr(authorization_error_count_key)
|
|
# we are giving precendence to the authorization error threshhold defined in the class
|
|
# so that channels can override the default value
|
|
prompt_reauthorization! if authorization_error_count >= self.class::AUTHORIZATION_ERROR_THRESHOLD
|
|
end
|
|
|
|
# Performed automatically if error threshold is breached
|
|
# could used to manually prompt reauthorization if auth scope changes
|
|
def prompt_reauthorization!
|
|
::Redis::Alfred.set(reauthorization_required_key, true)
|
|
|
|
mailer = AdministratorNotifications::ChannelNotificationsMailer.with(account: account)
|
|
|
|
case self.class.name
|
|
when 'Integrations::Hook'
|
|
process_integration_hook_reauthorization_emails(mailer)
|
|
when 'Channel::FacebookPage'
|
|
mailer.facebook_disconnect(inbox).deliver_later
|
|
when 'Channel::Whatsapp'
|
|
mailer.whatsapp_disconnect(inbox).deliver_later
|
|
when 'Channel::Email'
|
|
mailer.email_disconnect(inbox).deliver_later
|
|
when 'AutomationRule'
|
|
update!(active: false)
|
|
mailer.automation_rule_disabled(self).deliver_later
|
|
end
|
|
|
|
invalidate_inbox_cache unless instance_of?(::AutomationRule)
|
|
end
|
|
|
|
def process_integration_hook_reauthorization_emails(mailer)
|
|
if slack?
|
|
mailer.slack_disconnect.deliver_later
|
|
elsif dialogflow?
|
|
mailer.dialogflow_disconnect.deliver_later
|
|
end
|
|
end
|
|
|
|
# call this after you successfully Reauthorized the object in UI
|
|
def reauthorized!
|
|
::Redis::Alfred.delete(authorization_error_count_key)
|
|
::Redis::Alfred.delete(reauthorization_required_key)
|
|
|
|
invalidate_inbox_cache unless instance_of?(::AutomationRule)
|
|
end
|
|
|
|
private
|
|
|
|
def invalidate_inbox_cache
|
|
inbox.update_account_cache if inbox.present?
|
|
end
|
|
|
|
def authorization_error_count_key
|
|
format(::Redis::Alfred::AUTHORIZATION_ERROR_COUNT, obj_type: self.class.table_name.singularize, obj_id: id)
|
|
end
|
|
|
|
def reauthorization_required_key
|
|
format(::Redis::Alfred::REAUTHORIZATION_REQUIRED, obj_type: self.class.table_name.singularize, obj_id: id)
|
|
end
|
|
end
|