55315089cf
Deleting large Accounts/Inboxes with object.destroy! can time out and create heavy destroy_async fan-out; this change adds a simple pre-purge that batch-destroys heavy associations first . ``` Account: conversations, contacts Inbox: conversations, contact_inboxes ``` We use find_in_batches(5000), then proceeds with destroy!, reducing DB pressure and race conditions while preserving callbacks and leaving the behavior for non heavy models unchanged. The change is also done in a way to easily add additional objects or relations to the list. fixes: https://linear.app/chatwoot/issue/CW-3106/inbox-deletion-process-update-the-flow
41 lines
1.0 KiB
Ruby
41 lines
1.0 KiB
Ruby
class DeleteObjectJob < ApplicationJob
|
|
queue_as :low
|
|
|
|
BATCH_SIZE = 5_000
|
|
HEAVY_ASSOCIATIONS = {
|
|
Account => %i[conversations contacts inboxes reporting_events],
|
|
Inbox => %i[conversations contact_inboxes reporting_events]
|
|
}.freeze
|
|
|
|
def perform(object, user = nil, ip = nil)
|
|
# Pre-purge heavy associations for large objects to avoid
|
|
# timeouts & race conditions due to destroy_async fan-out.
|
|
purge_heavy_associations(object)
|
|
object.destroy!
|
|
process_post_deletion_tasks(object, user, ip)
|
|
end
|
|
|
|
def process_post_deletion_tasks(object, user, ip); end
|
|
|
|
private
|
|
|
|
def purge_heavy_associations(object)
|
|
klass = HEAVY_ASSOCIATIONS.keys.find { |k| object.is_a?(k) }
|
|
return unless klass
|
|
|
|
HEAVY_ASSOCIATIONS[klass].each do |assoc|
|
|
next unless object.respond_to?(assoc)
|
|
|
|
batch_destroy(object.public_send(assoc))
|
|
end
|
|
end
|
|
|
|
def batch_destroy(relation)
|
|
relation.find_in_batches(batch_size: BATCH_SIZE) do |batch|
|
|
batch.each(&:destroy!)
|
|
end
|
|
end
|
|
end
|
|
|
|
DeleteObjectJob.prepend_mod_with('DeleteObjectJob')
|