# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
96 lines
2.5 KiB
Vue
96 lines
2.5 KiB
Vue
<script>
|
|
import { mapGetters } from 'vuex';
|
|
import { useAdmin } from 'dashboard/composables/useAdmin';
|
|
import accountMixin from 'dashboard/mixins/account';
|
|
import OnboardingView from '../OnboardingView.vue';
|
|
import EmptyStateMessage from './EmptyStateMessage.vue';
|
|
|
|
export default {
|
|
components: {
|
|
OnboardingView,
|
|
EmptyStateMessage,
|
|
},
|
|
mixins: [accountMixin],
|
|
props: {
|
|
isOnExpandedLayout: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
},
|
|
setup() {
|
|
const { isAdmin } = useAdmin();
|
|
return {
|
|
isAdmin,
|
|
};
|
|
},
|
|
computed: {
|
|
...mapGetters({
|
|
currentChat: 'getSelectedChat',
|
|
allConversations: 'getAllConversations',
|
|
inboxesList: 'inboxes/getInboxes',
|
|
uiFlags: 'inboxes/getUIFlags',
|
|
loadingChatList: 'getChatListLoadingStatus',
|
|
}),
|
|
loadingIndicatorMessage() {
|
|
if (this.uiFlags.isFetching) {
|
|
return this.$t('CONVERSATION.LOADING_INBOXES');
|
|
}
|
|
return this.$t('CONVERSATION.LOADING_CONVERSATIONS');
|
|
},
|
|
conversationMissingMessage() {
|
|
if (!this.isOnExpandedLayout) {
|
|
return this.$t('CONVERSATION.SELECT_A_CONVERSATION');
|
|
}
|
|
return this.$t('CONVERSATION.404');
|
|
},
|
|
newInboxURL() {
|
|
return this.addAccountScoping('settings/inboxes/new');
|
|
},
|
|
emptyClassName() {
|
|
if (
|
|
!this.inboxesList.length &&
|
|
!this.uiFlags.isFetching &&
|
|
!this.loadingChatList &&
|
|
this.isAdmin
|
|
) {
|
|
return 'h-full overflow-auto';
|
|
}
|
|
return 'flex-1 min-w-0 px-0 flex flex-col items-center justify-center h-full';
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div :class="emptyClassName">
|
|
<woot-loading-state
|
|
v-if="uiFlags.isFetching || loadingChatList"
|
|
:message="loadingIndicatorMessage"
|
|
/>
|
|
<!-- No inboxes attached -->
|
|
<div
|
|
v-if="!inboxesList.length && !uiFlags.isFetching && !loadingChatList"
|
|
class="clearfix"
|
|
>
|
|
<OnboardingView v-if="isAdmin" />
|
|
<EmptyStateMessage v-else :message="$t('CONVERSATION.NO_INBOX_AGENT')" />
|
|
</div>
|
|
<!-- Show empty state images if not loading -->
|
|
|
|
<div
|
|
v-else-if="!uiFlags.isFetching && !loadingChatList"
|
|
class="flex flex-col items-center justify-center h-full"
|
|
>
|
|
<!-- No conversations available -->
|
|
<EmptyStateMessage
|
|
v-if="!allConversations.length"
|
|
:message="$t('CONVERSATION.NO_MESSAGE_1')"
|
|
/>
|
|
<EmptyStateMessage
|
|
v-else-if="allConversations.length && !currentChat.id"
|
|
:message="conversationMissingMessage"
|
|
/>
|
|
</div>
|
|
</div>
|
|
</template>
|