059506b1db
## Summary This Enterprise-only feature automatically fetches a favicon for companies created with a domain, and adds a batch task to backfill missing avatars for existing companies. The flow only targets companies that do not already have an attached avatar, so existing avatars are left untouched. ## Demo https://github.com/user-attachments/assets/d050334e-769f-4e46-b6e7-f7423727a192 ## What changed - Added `Avatar::AvatarFromFaviconJob` to build a Google favicon URL from the company domain and fetch it through `Avatar::AvatarFromUrlJob` - Triggered favicon fetching from `Company` with `after_create_commit` - Added `Companies::FetchAvatarsJob` to batch existing companies that are missing avatars - Added `companies:fetch_missing_avatars` under `enterprise/lib/tasks` - Kept the company-specific implementation inside the Enterprise boundary - Stubbed the new favicon request in unrelated specs that now hit this callback indirectly - Updated a couple of CI-sensitive specs that were failing due to callback side effects / reload-safe exception assertions ## How to verify 1. Create a company in Enterprise with a valid domain and no avatar. 2. Confirm that a favicon-based avatar gets attached shortly after creation. 3. Create another company with a domain and an avatar already attached. 4. Confirm that the existing avatar is not replaced. 5. Run `companies:fetch_missing_avatars`. 6. Confirm that existing companies without avatars get one, while companies that already have avatars remain unchanged. ## Notes - This change does not refresh or overwrite existing company avatars - Favicon fetching only runs for companies with a present domain - The branch includes the latest `develop` --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Sojan Jose <sojan@pepalo.com>
75 lines
2.9 KiB
Ruby
75 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Account::SignUpEmailValidationService, type: :service do
|
|
let(:service) { described_class.new(email) }
|
|
let(:blocked_domains) { "gmail.com\noutlook.com" }
|
|
let(:valid_email_address) { instance_double(ValidEmail2::Address, valid?: true, disposable?: false) }
|
|
let(:disposable_email_address) { instance_double(ValidEmail2::Address, valid?: true, disposable?: true) }
|
|
let(:invalid_email_address) { instance_double(ValidEmail2::Address, valid?: false) }
|
|
|
|
before do
|
|
allow(GlobalConfigService).to receive(:load).with('BLOCKED_EMAIL_DOMAINS', '').and_return(blocked_domains)
|
|
end
|
|
|
|
describe '#perform' do
|
|
context 'when email is invalid format' do
|
|
let(:email) { 'invalid-email' }
|
|
|
|
it 'raises InvalidEmail with invalid message' do
|
|
allow(ValidEmail2::Address).to receive(:new).with(email).and_return(invalid_email_address)
|
|
expect { service.perform }.to raise_error do |error|
|
|
expect(error.class.name).to eq('CustomExceptions::Account::InvalidEmail')
|
|
expect(error.message).to eq(I18n.t('errors.signup.invalid_email'))
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when domain is blocked' do
|
|
let(:email) { 'test@gmail.com' }
|
|
|
|
it 'raises InvalidEmail with blocked domain message' do
|
|
allow(ValidEmail2::Address).to receive(:new).with(email).and_return(valid_email_address)
|
|
expect { service.perform }.to raise_error do |error|
|
|
expect(error.class.name).to eq('CustomExceptions::Account::InvalidEmail')
|
|
expect(error.message).to eq(I18n.t('errors.signup.blocked_domain'))
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when domain is blocked (case insensitive)' do
|
|
let(:email) { 'test@GMAIL.COM' }
|
|
|
|
it 'raises InvalidEmail with blocked domain message' do
|
|
allow(ValidEmail2::Address).to receive(:new).with(email).and_return(valid_email_address)
|
|
expect { service.perform }.to raise_error do |error|
|
|
expect(error.class.name).to eq('CustomExceptions::Account::InvalidEmail')
|
|
expect(error.message).to eq(I18n.t('errors.signup.blocked_domain'))
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when email is from disposable provider' do
|
|
let(:email) { 'test@mailinator.com' }
|
|
|
|
it 'raises InvalidEmail with disposable message' do
|
|
allow(ValidEmail2::Address).to receive(:new).with(email).and_return(disposable_email_address)
|
|
expect { service.perform }.to raise_error do |error|
|
|
expect(error.class.name).to eq('CustomExceptions::Account::InvalidEmail')
|
|
expect(error.message).to eq(I18n.t('errors.signup.disposable_email'))
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when email is valid business email' do
|
|
let(:email) { 'test@example.com' }
|
|
|
|
it 'returns true' do
|
|
allow(ValidEmail2::Address).to receive(:new).with(email).and_return(valid_email_address)
|
|
expect(service.perform).to be(true)
|
|
end
|
|
end
|
|
end
|
|
end
|