b870a48734
## Linear issue https://linear.app/chatwoot/issue/CW-6289/limit-the-number-of-notifications-per-user-to-300 ## Description Limits the number of notifications per user to 300 by introducing an async trim job that runs after each notification creation. This prevents unbounded notification growth that was causing DB CPU spikes. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] This change requires a documentation update ## How Has This Been Tested? - Added unit tests for TrimUserNotificationsJob ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Implements a dedicated purge job to control notification volume and scheduling. > > - Introduces `Notification::RemoveOldNotificationJob` (queue: `purgable`) to delete notifications older than 1 month and trim each user to the 300 most recent (deterministic by `created_at DESC, id DESC`) > - Adds daily cron (`remove_old_notification_job` at 22:30 UTC, queue `purgable`) in `config/schedule.yml` > - Removes ad-hoc triggering of the purge from `TriggerScheduledItemsJob` > - Adds/updates specs covering enqueue queue, old-notification deletion, per-user trimming, and combined behavior > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9ea2b48e36df96cd15d4119d1dd7dcf5250695de. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Vishnu Narayanan <iamwishnu@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com>
66 lines
2.9 KiB
Ruby
66 lines
2.9 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Notification::RemoveOldNotificationJob do
|
|
let(:account) { create(:account) }
|
|
let(:user) { create(:user, account: account) }
|
|
let(:conversation) { create(:conversation, account: account) }
|
|
|
|
it 'enqueues the job' do
|
|
expect do
|
|
described_class.perform_later
|
|
end.to have_enqueued_job(described_class)
|
|
.on_queue('purgable')
|
|
end
|
|
|
|
describe 'removing old notifications' do
|
|
it 'removes notifications older than 1 month' do
|
|
create(:notification, user: user, notification_type: 'conversation_creation', primary_actor: conversation,
|
|
created_at: 2.months.ago)
|
|
create(:notification, user: user, notification_type: 'conversation_creation', primary_actor: conversation,
|
|
created_at: 1.month.ago)
|
|
create(:notification, user: user, notification_type: 'conversation_creation', primary_actor: conversation,
|
|
created_at: 1.day.ago)
|
|
create(:notification, user: user, notification_type: 'conversation_creation', primary_actor: conversation,
|
|
created_at: 1.hour.ago)
|
|
|
|
described_class.perform_now
|
|
expect(Notification.count).to eq(2)
|
|
end
|
|
end
|
|
|
|
describe 'trimming user notifications' do
|
|
it 'does not delete notifications when user has fewer than 300' do
|
|
create_list(:notification, 50, user: user, account: account, primary_actor: conversation)
|
|
|
|
expect { described_class.perform_now }.not_to(change(Notification, :count))
|
|
end
|
|
|
|
it 'trims to 300 notifications per user keeping the most recent' do
|
|
old_notifications = create_list(:notification, 50, user: user, account: account, primary_actor: conversation,
|
|
created_at: 2.days.ago)
|
|
recent_notifications = create_list(:notification, 300, user: user, account: account, primary_actor: conversation,
|
|
created_at: 1.hour.ago)
|
|
|
|
described_class.perform_now
|
|
|
|
expect(Notification.where(user_id: user.id).count).to eq(300)
|
|
expect(Notification.where(id: old_notifications.map(&:id))).to be_empty
|
|
expect(Notification.where(id: recent_notifications.map(&:id)).count).to eq(300)
|
|
end
|
|
end
|
|
|
|
describe 'combined functionality' do
|
|
it 'removes old notifications and trims user notifications in one job' do
|
|
# User with old and excess notifications
|
|
create_list(:notification, 100, user: user, account: account, primary_actor: conversation, created_at: 2.months.ago)
|
|
create_list(:notification, 250, user: user, account: account, primary_actor: conversation, created_at: 1.day.ago)
|
|
|
|
described_class.perform_now
|
|
|
|
# All old notifications removed, remaining trimmed to 300
|
|
expect(Notification.where(user_id: user.id).count).to eq(250)
|
|
expect(Notification.where('created_at < ?', 1.month.ago)).to be_empty
|
|
end
|
|
end
|
|
end
|