ab93821d2b
This fixes the agent-bot webhook delivery path so transient upstream failures follow the expected delivery lifecycle. Existing fallback behavior is preserved, and fallback actions are applied only after delivery attempts are exhausted. To reproduce, configure an agent-bot webhook endpoint to return 429/500 for message events. Before this fix, failure handling could be applied too early; after this fix, delivery attempts complete first and then existing fallback handling runs. Tested with: - bundle exec rspec spec/jobs/agent_bots/webhook_job_spec.rb spec/lib/webhooks/trigger_spec.rb - bundle exec rubocop spec/jobs/agent_bots/webhook_job_spec.rb spec/lib/webhooks/trigger_spec.rb --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
52 lines
1.7 KiB
Ruby
52 lines
1.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe AgentBots::WebhookJob do
|
|
include ActiveJob::TestHelper
|
|
|
|
subject(:job) { described_class.perform_later(url, payload, webhook_type) }
|
|
|
|
let(:url) { 'https://test.com' }
|
|
let(:payload) { { name: 'test' } }
|
|
let(:webhook_type) { :agent_bot_webhook }
|
|
let(:retryable_error) { RestClient::InternalServerError.new(nil, 500) }
|
|
|
|
before do
|
|
ActiveJob::Base.queue_adapter = :test
|
|
end
|
|
|
|
after do
|
|
clear_enqueued_jobs
|
|
clear_performed_jobs
|
|
end
|
|
|
|
it 'queues the job' do
|
|
expect { job }.to have_enqueued_job(described_class)
|
|
.with(url, payload, webhook_type)
|
|
.on_queue('high')
|
|
end
|
|
|
|
it 'executes perform' do
|
|
expect(Webhooks::Trigger).to receive(:execute).with(url, payload, webhook_type, secret: nil, delivery_id: nil)
|
|
perform_enqueued_jobs { job }
|
|
end
|
|
|
|
it 'configures retry handlers for 429 and 500 errors' do
|
|
handlers = described_class.rescue_handlers.map(&:first)
|
|
|
|
expect(handlers).to include('RestClient::TooManyRequests', 'RestClient::InternalServerError')
|
|
end
|
|
|
|
it 'retries 3 times and handles failure after retries are exhausted' do
|
|
allow(Webhooks::Trigger).to receive(:execute).and_raise(retryable_error)
|
|
trigger_instance = instance_double(Webhooks::Trigger, handle_failure: true)
|
|
allow(Webhooks::Trigger).to receive(:new).and_return(trigger_instance)
|
|
allow(Rails.logger).to receive(:warn)
|
|
|
|
expect(Webhooks::Trigger).to receive(:execute).exactly(3).times
|
|
expect(trigger_instance).to receive(:handle_failure).with(instance_of(RestClient::InternalServerError)).once
|
|
expect(Rails.logger).to receive(:warn).with(/AgentBots::WebhookJob/).exactly(3).times
|
|
|
|
perform_enqueued_jobs { job }
|
|
end
|
|
end
|