2b50909d9b
## Description The RemoveOrphanConversationsService filters orphan conversations by a time window before deleting them. Previously it used created_at, which could miss old conversations that still had recent activity. Switching to last_activity_at ensures the cleanup window reflects actual conversation activity rather than creation time. ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - By running Rake task - Run the job from console ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
35 lines
1.2 KiB
Ruby
35 lines
1.2 KiB
Ruby
class Internal::RemoveOrphanConversationsService
|
|
def initialize(account: nil, days: 1)
|
|
@account = account
|
|
@days = days
|
|
end
|
|
|
|
def perform
|
|
orphan_conversations = build_orphan_conversations_query
|
|
total_deleted = 0
|
|
|
|
Rails.logger.info '[RemoveOrphanConversationsService] Starting removal of orphan conversations'
|
|
|
|
orphan_conversations.find_in_batches(batch_size: 1000) do |batch|
|
|
conversation_ids = batch.map(&:id)
|
|
Conversation.where(id: conversation_ids).destroy_all
|
|
total_deleted += batch.size
|
|
Rails.logger.info "[RemoveOrphanConversationsService] Deleted #{batch.size} orphan conversations (#{total_deleted} total)"
|
|
end
|
|
|
|
Rails.logger.info "[RemoveOrphanConversationsService] Completed. Total deleted: #{total_deleted}"
|
|
total_deleted
|
|
end
|
|
|
|
private
|
|
|
|
def build_orphan_conversations_query
|
|
base = @account ? @account.conversations : Conversation.all
|
|
base = base.where('conversations.last_activity_at > ?', @days.days.ago)
|
|
base = base.left_outer_joins(:contact, :inbox)
|
|
|
|
# Find conversations whose associated contact or inbox record is missing
|
|
base.where(contacts: { id: nil }).or(base.where(inboxes: { id: nil }))
|
|
end
|
|
end
|