# Pull Request Template ## Description captain decides if conversation should be resolved or open Fixes https://linear.app/chatwoot/issue/AI-91/make-captain-resolution-time-configurable Update: Added 2 entries in reporting events: `conversation_captain_handoff` and `conversation_captain_resolved` ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) - [x] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. LLM call decides that conversation is resolved, drops a private note <img width="1228" height="438" alt="image" src="https://github.com/user-attachments/assets/fb2cf1e9-4b2b-458b-a1e2-45c53d6a0158" /> LLM call decides conversation is still open as query was not resolved <img width="1215" height="573" alt="image" src="https://github.com/user-attachments/assets/2d1d5322-f567-487e-954e-11ab0798d11c" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Sojan Jose <sojan@pepalo.com>
243 lines
9.0 KiB
Ruby
243 lines
9.0 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Captain::Tools::HandoffTool, type: :model do
|
|
let(:account) { create(:account) }
|
|
let(:assistant) { create(:captain_assistant, account: account) }
|
|
let(:tool) { described_class.new(assistant) }
|
|
let(:user) { create(:user, account: account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:contact) { create(:contact, account: account) }
|
|
let(:conversation) { create(:conversation, account: account, inbox: inbox, contact: contact) }
|
|
let(:tool_context) { Struct.new(:state).new({ conversation: { id: conversation.id } }) }
|
|
|
|
describe '#description' do
|
|
it 'returns the correct description' do
|
|
expect(tool.description).to eq('Hand off the conversation to a human agent when unable to assist further')
|
|
end
|
|
end
|
|
|
|
describe '#parameters' do
|
|
it 'returns the correct parameters' do
|
|
expect(tool.parameters).to have_key(:reason)
|
|
expect(tool.parameters[:reason].name).to eq(:reason)
|
|
expect(tool.parameters[:reason].type).to eq('string')
|
|
expect(tool.parameters[:reason].description).to eq('The reason why handoff is needed (optional)')
|
|
expect(tool.parameters[:reason].required).to be false
|
|
end
|
|
end
|
|
|
|
describe '#perform' do
|
|
context 'when conversation exists' do
|
|
context 'with reason provided' do
|
|
it 'creates a private note with reason and hands off conversation' do
|
|
reason = 'Customer needs specialized support'
|
|
|
|
expect do
|
|
result = tool.perform(tool_context, reason: reason)
|
|
expect(result).to eq("Conversation handed off to human support team (Reason: #{reason})")
|
|
end.to change(Message, :count).by(1)
|
|
end
|
|
|
|
it 'creates message with correct attributes' do
|
|
reason = 'Customer needs specialized support'
|
|
tool.perform(tool_context, reason: reason)
|
|
|
|
created_message = Message.last
|
|
expect(created_message.content).to eq(reason)
|
|
expect(created_message.message_type).to eq('outgoing')
|
|
expect(created_message.private).to be true
|
|
expect(created_message.sender).to eq(assistant)
|
|
expect(created_message.account).to eq(account)
|
|
expect(created_message.inbox).to eq(inbox)
|
|
expect(created_message.conversation).to eq(conversation)
|
|
end
|
|
|
|
it 'triggers bot handoff on conversation' do
|
|
# The tool finds the conversation by ID, so we need to mock the found conversation
|
|
found_conversation = Conversation.find(conversation.id)
|
|
scoped_conversations = Conversation.where(account_id: assistant.account_id)
|
|
allow(Conversation).to receive(:where).with(account_id: assistant.account_id).and_return(scoped_conversations)
|
|
allow(scoped_conversations).to receive(:find_by).with(id: conversation.id).and_return(found_conversation)
|
|
expect(found_conversation).to receive(:bot_handoff!)
|
|
|
|
tool.perform(tool_context, reason: 'Test reason')
|
|
end
|
|
|
|
it 'creates a conversation_bot_handoff reporting event' do
|
|
create(:captain_inbox, captain_assistant: assistant, inbox: inbox)
|
|
Current.executed_by = assistant
|
|
|
|
perform_enqueued_jobs do
|
|
tool.perform(tool_context, reason: 'Customer needs specialized support')
|
|
end
|
|
|
|
reporting_event = ReportingEvent.find_by(conversation_id: conversation.id, name: 'conversation_bot_handoff')
|
|
expect(reporting_event).to be_present
|
|
ensure
|
|
Current.reset
|
|
end
|
|
|
|
it 'logs tool usage with reason' do
|
|
reason = 'Customer needs help'
|
|
expect(tool).to receive(:log_tool_usage).with(
|
|
'tool_handoff',
|
|
{ conversation_id: conversation.id, reason: reason }
|
|
)
|
|
|
|
tool.perform(tool_context, reason: reason)
|
|
end
|
|
end
|
|
|
|
context 'without reason provided' do
|
|
it 'creates a private note with nil content and hands off conversation' do
|
|
expect do
|
|
result = tool.perform(tool_context)
|
|
expect(result).to eq('Conversation handed off to human support team')
|
|
end.to change(Message, :count).by(1)
|
|
|
|
created_message = Message.last
|
|
expect(created_message.content).to be_nil
|
|
end
|
|
|
|
it 'logs tool usage with default reason' do
|
|
expect(tool).to receive(:log_tool_usage).with(
|
|
'tool_handoff',
|
|
{ conversation_id: conversation.id, reason: 'Agent requested handoff' }
|
|
)
|
|
|
|
tool.perform(tool_context)
|
|
end
|
|
end
|
|
|
|
context 'when handoff fails' do
|
|
before do
|
|
# Mock the conversation lookup and handoff failure
|
|
found_conversation = Conversation.find(conversation.id)
|
|
scoped_conversations = Conversation.where(account_id: assistant.account_id)
|
|
allow(Conversation).to receive(:where).with(account_id: assistant.account_id).and_return(scoped_conversations)
|
|
allow(scoped_conversations).to receive(:find_by).with(id: conversation.id).and_return(found_conversation)
|
|
allow(found_conversation).to receive(:bot_handoff!).and_raise(StandardError, 'Handoff error')
|
|
|
|
exception_tracker = instance_double(ChatwootExceptionTracker)
|
|
allow(ChatwootExceptionTracker).to receive(:new).and_return(exception_tracker)
|
|
allow(exception_tracker).to receive(:capture_exception)
|
|
end
|
|
|
|
it 'returns error message' do
|
|
result = tool.perform(tool_context, reason: 'Test')
|
|
expect(result).to eq('Failed to handoff conversation')
|
|
end
|
|
|
|
it 'captures exception' do
|
|
exception_tracker = instance_double(ChatwootExceptionTracker)
|
|
expect(ChatwootExceptionTracker).to receive(:new).with(instance_of(StandardError)).and_return(exception_tracker)
|
|
expect(exception_tracker).to receive(:capture_exception)
|
|
|
|
tool.perform(tool_context, reason: 'Test')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when conversation does not exist' do
|
|
let(:tool_context) { Struct.new(:state).new({ conversation: { id: 999_999 } }) }
|
|
|
|
it 'returns error message' do
|
|
result = tool.perform(tool_context, reason: 'Test')
|
|
expect(result).to eq('Conversation not found')
|
|
end
|
|
|
|
it 'does not create a message' do
|
|
expect do
|
|
tool.perform(tool_context, reason: 'Test')
|
|
end.not_to change(Message, :count)
|
|
end
|
|
end
|
|
|
|
context 'when conversation state is missing' do
|
|
let(:tool_context) { Struct.new(:state).new({}) }
|
|
|
|
it 'returns error message' do
|
|
result = tool.perform(tool_context, reason: 'Test')
|
|
expect(result).to eq('Conversation not found')
|
|
end
|
|
end
|
|
|
|
context 'when conversation id is nil' do
|
|
let(:tool_context) { Struct.new(:state).new({ conversation: { id: nil } }) }
|
|
|
|
it 'returns error message' do
|
|
result = tool.perform(tool_context, reason: 'Test')
|
|
expect(result).to eq('Conversation not found')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#active?' do
|
|
it 'returns true for public tools' do
|
|
expect(tool.active?).to be true
|
|
end
|
|
end
|
|
|
|
describe 'out of office message after handoff' do
|
|
context 'when outside business hours' do
|
|
before do
|
|
inbox.update!(
|
|
working_hours_enabled: true,
|
|
out_of_office_message: 'We are currently closed. Please leave your email.'
|
|
)
|
|
inbox.working_hours.find_by(day_of_week: Time.current.in_time_zone(inbox.timezone).wday).update!(
|
|
closed_all_day: true,
|
|
open_all_day: false
|
|
)
|
|
end
|
|
|
|
it 'sends out of office message after handoff' do
|
|
expect do
|
|
tool.perform(tool_context, reason: 'Customer needs help')
|
|
end.to change { conversation.messages.template.count }.by(1)
|
|
|
|
ooo_message = conversation.messages.template.last
|
|
expect(ooo_message.content).to eq('We are currently closed. Please leave your email.')
|
|
end
|
|
end
|
|
|
|
context 'when within business hours' do
|
|
before do
|
|
inbox.update!(
|
|
working_hours_enabled: true,
|
|
out_of_office_message: 'We are currently closed.'
|
|
)
|
|
inbox.working_hours.find_by(day_of_week: Time.current.in_time_zone(inbox.timezone).wday).update!(
|
|
open_all_day: true,
|
|
closed_all_day: false
|
|
)
|
|
end
|
|
|
|
it 'does not send out of office message after handoff' do
|
|
expect do
|
|
tool.perform(tool_context, reason: 'Customer needs help')
|
|
end.not_to(change { conversation.messages.template.count })
|
|
end
|
|
end
|
|
|
|
context 'when no out of office message is configured' do
|
|
before do
|
|
inbox.update!(
|
|
working_hours_enabled: true,
|
|
out_of_office_message: nil
|
|
)
|
|
inbox.working_hours.find_by(day_of_week: Time.current.in_time_zone(inbox.timezone).wday).update!(
|
|
closed_all_day: true,
|
|
open_all_day: false
|
|
)
|
|
end
|
|
|
|
it 'does not send out of office message' do
|
|
expect do
|
|
tool.perform(tool_context, reason: 'Customer needs help')
|
|
end.not_to(change { conversation.messages.template.count })
|
|
end
|
|
end
|
|
end
|
|
end
|