c9823d9409
## Linear Link ## Description This PR introduces a new robust auto-assignment system for conversations in Chatwoot. The system replaces the existing round-robin assignment with a more sophisticated service-based architecture that supports multiple assignment strategies, rate limiting, and Enterprise features like capacity-based assignment and balanced distribution. ## Type of change - [ ] New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Unit test cases - Test conversations getting assigned on status change to open - Test the job directly via rails console ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a new service-based auto-assignment system with scheduled jobs, rate limiting, enterprise capacity/balanced selection, and wiring via inbox/handler; includes Redis helpers and comprehensive tests. > > - **Auto-assignment v2 (core services)**: > - Add `AutoAssignment::AssignmentService` with bulk assignment, configurable conversation priority, RR selection, and per-agent rate limiting via `AutoAssignment::RateLimiter`. > - Add `AutoAssignment::RoundRobinSelector` for agent selection. > - **Jobs & scheduling**: > - Add `AutoAssignment::AssignmentJob` (per-inbox bulk assign; env-based limit) and `AutoAssignment::PeriodicAssignmentJob` (batch over accounts/inboxes). > - Schedule periodic run in `config/schedule.yml` (`periodic_assignment_job`). > - **Model/concerns wiring**: > - Include `InboxAgentAvailability` in `Inbox`; add `Inbox#auto_assignment_v2_enabled?`. > - Update `AutoAssignmentHandler` to trigger v2 job when `auto_assignment_v2_enabled?`, else fallback to legacy. > - **Enterprise extensions**: > - Add `Enterprise::InboxAgentAvailability` (capacity-aware filtering) and `Enterprise::Concerns::Inbox` association `inbox_capacity_limits`. > - Extend service via `Enterprise::AutoAssignment::AssignmentService` (policy-driven config, capacity filtering, exclusion rules) and add selectors/services: `BalancedSelector`, `CapacityService`. > - **Infrastructure**: > - Enhance `Redis::Alfred` with `expire`, key scan/count, and extended ZSET helpers (`zadd`, `zcount`, `zcard`, `zrangebyscore`). > - **Tests**: > - Add specs for jobs, core service, rate limiter, RR selector, and enterprise features (capacity, balanced selection, exclusions). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0ebe187c8aea73765b0122a44b18d6f465c2477f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com>
79 lines
2.9 KiB
Ruby
79 lines
2.9 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe AutoAssignment::RoundRobinSelector do
|
|
let(:account) { create(:account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:selector) { described_class.new(inbox: inbox) }
|
|
let(:agent1) { create(:user, account: account, role: :agent, availability: :online) }
|
|
let(:agent2) { create(:user, account: account, role: :agent, availability: :online) }
|
|
let(:agent3) { create(:user, account: account, role: :agent, availability: :online) }
|
|
|
|
let(:round_robin_service) { instance_double(AutoAssignment::InboxRoundRobinService) }
|
|
|
|
let(:member1) do
|
|
allow(AutoAssignment::InboxRoundRobinService).to receive(:new).and_return(round_robin_service)
|
|
allow(round_robin_service).to receive(:add_agent_to_queue)
|
|
create(:inbox_member, inbox: inbox, user: agent1)
|
|
end
|
|
|
|
let(:member2) do
|
|
allow(AutoAssignment::InboxRoundRobinService).to receive(:new).and_return(round_robin_service)
|
|
allow(round_robin_service).to receive(:add_agent_to_queue)
|
|
create(:inbox_member, inbox: inbox, user: agent2)
|
|
end
|
|
|
|
let(:member3) do
|
|
allow(AutoAssignment::InboxRoundRobinService).to receive(:new).and_return(round_robin_service)
|
|
allow(round_robin_service).to receive(:add_agent_to_queue)
|
|
create(:inbox_member, inbox: inbox, user: agent3)
|
|
end
|
|
|
|
before do
|
|
# Mock the round robin service to avoid Redis calls
|
|
allow(AutoAssignment::InboxRoundRobinService).to receive(:new).and_return(round_robin_service)
|
|
allow(round_robin_service).to receive(:add_agent_to_queue)
|
|
allow(round_robin_service).to receive(:reset_queue)
|
|
allow(round_robin_service).to receive(:validate_queue?).and_return(true)
|
|
end
|
|
|
|
describe '#select_agent' do
|
|
context 'when agents are available' do
|
|
let(:available_agents) { [member1, member2, member3] }
|
|
|
|
it 'returns an agent from the available list' do
|
|
allow(round_robin_service).to receive(:available_agent).and_return(agent1)
|
|
|
|
selected_agent = selector.select_agent(available_agents)
|
|
|
|
expect(selected_agent).not_to be_nil
|
|
expect([agent1, agent2, agent3]).to include(selected_agent)
|
|
end
|
|
|
|
it 'uses round robin service for selection' do
|
|
expect(round_robin_service).to receive(:available_agent).with(
|
|
allowed_agent_ids: [agent1.id.to_s, agent2.id.to_s, agent3.id.to_s]
|
|
).and_return(agent1)
|
|
|
|
selected_agent = selector.select_agent(available_agents)
|
|
expect(selected_agent).to eq(agent1)
|
|
end
|
|
end
|
|
|
|
context 'when no agents are available' do
|
|
it 'returns nil' do
|
|
selected_agent = selector.select_agent([])
|
|
expect(selected_agent).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when one agent is available' do
|
|
it 'returns that agent' do
|
|
allow(round_robin_service).to receive(:available_agent).and_return(agent1)
|
|
|
|
selected_agent = selector.select_agent([member1])
|
|
expect(selected_agent).to eq(agent1)
|
|
end
|
|
end
|
|
end
|
|
end
|