61eaa098ae
## Summary This PR reduces duplicate failure noise for audio transcription jobs that fail with permanent HTTP 400 responses, and fixes a file-format edge case causing intermittent 400s. Sentry issue: [CHATWOOT-99E / 6660541334](https://chatwoot-p3.sentry.io/issues/6660541334/) ## Confirmed root cause For some attachments, the stored filename had no extension (example: `speech`, content type `audio/mpeg`). When the temporary transcription upload file was created without an extension, OpenAI returned: `Unrecognized file format` (HTTP 400). ## Scope of changes 1. `Messages::AudioTranscriptionJob` - Keeps `discard_on Faraday::BadRequestError` to avoid retry storms on permanent request errors. - Adds explicit Rails warning logs for discarded jobs with attachment/job/status context. 2. `Messages::AudioTranscriptionService` - Keeps guaranteed temp file cleanup via `ensure`. - Ensures temp upload files include an extension when the original filename has none, derived from blob `content_type`. - This addresses intermittent failures like extensionless `audio/mpeg` files. ## Reproduction Enable audio transcription for an account and process an audio attachment whose stored filename has no extension (for example `speech`) but valid audio content type (`audio/mpeg`). Before this fix, OpenAI transcription could return HTTP 400 `Unrecognized file format` for that attachment while similar attachments with extensions succeeded. ## Testing Ran: `bundle exec rubocop enterprise/app/jobs/messages/audio_transcription_job.rb enterprise/app/services/messages/audio_transcription_service.rb` Result: both modified files pass lint with no offenses.
88 lines
3.0 KiB
Ruby
88 lines
3.0 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Messages::AudioTranscriptionService, type: :service do
|
|
let(:account) { create(:account, audio_transcriptions: true) }
|
|
let(:conversation) { create(:conversation, account: account) }
|
|
let(:message) { create(:message, conversation: conversation) }
|
|
let(:attachment) { message.attachments.create!(account: account, file_type: :audio) }
|
|
|
|
before do
|
|
# Create required installation configs
|
|
InstallationConfig.find_or_create_by!(name: 'CAPTAIN_OPEN_AI_API_KEY') { |config| config.value = 'test-api-key' }
|
|
InstallationConfig.find_or_create_by!(name: 'CAPTAIN_OPEN_AI_MODEL') { |config| config.value = 'gpt-4o-mini' }
|
|
|
|
# Mock usage limits for transcription to be available
|
|
allow(account).to receive(:usage_limits).and_return({ captain: { responses: { current_available: 100 } } })
|
|
end
|
|
|
|
describe '#perform' do
|
|
let(:service) { described_class.new(attachment) }
|
|
|
|
context 'when captain_integration feature is not enabled' do
|
|
before do
|
|
account.disable_features!('captain_integration')
|
|
end
|
|
|
|
it 'returns transcription limit exceeded' do
|
|
expect(service.perform).to eq({ error: 'Transcription limit exceeded' })
|
|
end
|
|
end
|
|
|
|
context 'when transcription is successful' do
|
|
before do
|
|
# Mock can_transcribe? to return true and transcribe_audio method
|
|
allow(service).to receive(:can_transcribe?).and_return(true)
|
|
allow(service).to receive(:transcribe_audio).and_return('Hello world transcription')
|
|
end
|
|
|
|
it 'returns successful transcription' do
|
|
result = service.perform
|
|
expect(result).to eq({ success: true, transcriptions: 'Hello world transcription' })
|
|
end
|
|
end
|
|
|
|
context 'when audio transcriptions are disabled' do
|
|
before do
|
|
account.update!(audio_transcriptions: false)
|
|
end
|
|
|
|
it 'returns error for transcription limit exceeded' do
|
|
result = service.perform
|
|
expect(result).to eq({ error: 'Transcription limit exceeded' })
|
|
end
|
|
end
|
|
|
|
context 'when attachment already has transcribed text' do
|
|
before do
|
|
attachment.update!(meta: { transcribed_text: 'Existing transcription' })
|
|
allow(service).to receive(:can_transcribe?).and_return(true)
|
|
end
|
|
|
|
it 'returns existing transcription without calling API' do
|
|
result = service.perform
|
|
expect(result).to eq({ success: true, transcriptions: 'Existing transcription' })
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#fetch_audio_file' do
|
|
let(:service) { described_class.new(attachment) }
|
|
|
|
before do
|
|
attachment.file.attach(
|
|
io: File.open(Rails.public_path.join('audio/widget/ding.mp3')),
|
|
filename: 'speech',
|
|
content_type: 'audio/mpeg'
|
|
)
|
|
end
|
|
|
|
it 'adds extension from content type when filename has no extension' do
|
|
temp_file_path = service.send(:fetch_audio_file)
|
|
|
|
expect(File.extname(temp_file_path)).to eq('.mpeg')
|
|
ensure
|
|
FileUtils.rm_f(temp_file_path) if temp_file_path.present?
|
|
end
|
|
end
|
|
end
|