d48503bdcf
This PR improves the voice call creation flow by simplifying configuration and automating setup with Twilio APIs. references: #11602 , #11481 ## Key changes - Removed the requirement for twiml_app_sid – provisioning is now automated through APIs. - Auto-configured webhook URLs for: - Voice number callbacks - Status callbacks - twiML callbacks - Disabled business hours, help center, and related options until voice inbox is fully supported. - Added a configuration tab in the voice inbox to display the required Twilio URLs (to make verification easier in Twilio console). ## Test Cases - Provisioning - Create a new voice inbox → verify that Twilio app provisioning happens automatically. - Verify twiML callback - Webhook configuration - Check that both voice number callback and status callback URLs are auto-populated in Twilio. - Disabled features - Confirm that business hours and help center options are hidden/disabled for voice inbox. - Configuration tab - Open the voice inbox configuration tab → verify that the displayed Twilio URLs match what’s set in Twilio.
80 lines
2.8 KiB
Ruby
80 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Channel::Voice do
|
|
let(:twiml_app_sid) { 'AP1234567890abcdef' }
|
|
let(:channel) { create(:channel_voice) }
|
|
|
|
before do
|
|
allow(Twilio::VoiceWebhookSetupService).to receive(:new).and_return(instance_double(Twilio::VoiceWebhookSetupService, perform: twiml_app_sid))
|
|
end
|
|
|
|
it 'has a valid factory' do
|
|
expect(channel).to be_valid
|
|
end
|
|
|
|
describe 'validations' do
|
|
it 'validates presence of provider_config' do
|
|
channel.provider_config = nil
|
|
expect(channel).not_to be_valid
|
|
expect(channel.errors[:provider_config]).to include("can't be blank")
|
|
end
|
|
|
|
it 'validates presence of account_sid in provider_config' do
|
|
channel.provider_config = { auth_token: 'token' }
|
|
expect(channel).not_to be_valid
|
|
expect(channel.errors[:provider_config]).to include('account_sid is required for Twilio provider')
|
|
end
|
|
|
|
it 'validates presence of auth_token in provider_config' do
|
|
channel.provider_config = { account_sid: 'sid' }
|
|
expect(channel).not_to be_valid
|
|
expect(channel.errors[:provider_config]).to include('auth_token is required for Twilio provider')
|
|
end
|
|
|
|
it 'validates presence of api_key_sid in provider_config' do
|
|
channel.provider_config = { account_sid: 'sid', auth_token: 'token' }
|
|
expect(channel).not_to be_valid
|
|
expect(channel.errors[:provider_config]).to include('api_key_sid is required for Twilio provider')
|
|
end
|
|
|
|
it 'validates presence of api_key_secret in provider_config' do
|
|
channel.provider_config = { account_sid: 'sid', auth_token: 'token', api_key_sid: 'key' }
|
|
expect(channel).not_to be_valid
|
|
expect(channel.errors[:provider_config]).to include('api_key_secret is required for Twilio provider')
|
|
end
|
|
|
|
it 'validates presence of twiml_app_sid in provider_config' do
|
|
channel.provider_config = { account_sid: 'sid', auth_token: 'token', api_key_sid: 'key', api_key_secret: 'secret' }
|
|
expect(channel).not_to be_valid
|
|
expect(channel.errors[:provider_config]).to include('twiml_app_sid is required for Twilio provider')
|
|
end
|
|
|
|
it 'is valid with all required provider_config fields' do
|
|
channel.provider_config = {
|
|
account_sid: 'test_sid',
|
|
auth_token: 'test_token',
|
|
api_key_sid: 'test_key',
|
|
api_key_secret: 'test_secret',
|
|
twiml_app_sid: 'test_app_sid'
|
|
}
|
|
expect(channel).to be_valid
|
|
end
|
|
end
|
|
|
|
describe '#name' do
|
|
it 'returns Voice with phone number' do
|
|
expect(channel.name).to include('Voice')
|
|
expect(channel.name).to include(channel.phone_number)
|
|
end
|
|
end
|
|
|
|
describe 'provisioning on create' do
|
|
it 'stores twiml_app_sid in provider_config' do
|
|
ch = create(:channel_voice)
|
|
expect(ch.provider_config.with_indifferent_access[:twiml_app_sid]).to eq(twiml_app_sid)
|
|
end
|
|
end
|
|
end
|