f89d9a4401
Introduces a new bulk action `delete` for contacts ref: https://github.com/chatwoot/chatwoot/pull/12763 ## Screens <img width="1492" height="973" alt="Screenshot 2025-10-31 at 6 27 21 PM" src="https://github.com/user-attachments/assets/30dab1bb-2c2c-4168-9800-44e0eb5f8e3a" /> <img width="1492" height="985" alt="Screenshot 2025-10-31 at 6 27 32 PM" src="https://github.com/user-attachments/assets/5be610c4-b19e-4614-a164-103b22337382" />
274 lines
10 KiB
Ruby
274 lines
10 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe 'Api::V1::Accounts::BulkActionsController', type: :request do
|
|
include ActiveJob::TestHelper
|
|
let(:account) { create(:account) }
|
|
let(:agent_1) { create(:user, account: account, role: :agent) }
|
|
let(:agent_2) { create(:user, account: account, role: :agent) }
|
|
let(:team_1) { create(:team, account: account) }
|
|
|
|
before do
|
|
create(:conversation, account_id: account.id, status: :open, team_id: team_1.id)
|
|
create(:conversation, account_id: account.id, status: :open, team_id: team_1.id)
|
|
create(:conversation, account_id: account.id, status: :open)
|
|
create(:conversation, account_id: account.id, status: :open)
|
|
Conversation.all.find_each do |conversation|
|
|
create(:inbox_member, inbox: conversation.inbox, user: agent_1)
|
|
create(:inbox_member, inbox: conversation.inbox, user: agent_2)
|
|
end
|
|
end
|
|
|
|
describe 'POST /api/v1/accounts/{account.id}/bulk_action' do
|
|
context 'when it is an unauthenticated user' do
|
|
let!(:agent) { create(:user) }
|
|
|
|
it 'returns unauthorized' do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: { type: 'Conversation', fields: { status: 'open' }, ids: [1, 2, 3] }
|
|
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context 'when it is an authenticated user' do
|
|
let!(:agent) { create(:user, account: account, role: :agent) }
|
|
|
|
it 'Ignores bulk_actions for wrong type' do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: { type: 'Test', fields: { status: 'snoozed' }, ids: %w[1 2 3] }
|
|
|
|
expect(response).to have_http_status(:unprocessable_entity)
|
|
end
|
|
|
|
it 'Bulk update conversation status' do
|
|
expect(Conversation.first.status).to eq('open')
|
|
expect(Conversation.last.status).to eq('open')
|
|
expect(Conversation.first.assignee_id).to be_nil
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: { type: 'Conversation', fields: { status: 'snoozed' }, ids: Conversation.first(3).pluck(:display_id) }
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.status).to eq('snoozed')
|
|
expect(Conversation.last.status).to eq('open')
|
|
expect(Conversation.first.assignee_id).to be_nil
|
|
end
|
|
|
|
it 'Bulk update conversation team id to none' do
|
|
params = { type: 'Conversation', fields: { team_id: 0 }, ids: Conversation.first(1).pluck(:display_id) }
|
|
expect(Conversation.first.team).not_to be_nil
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.team).to be_nil
|
|
|
|
last_activity_message = Conversation.first.messages.activity.last
|
|
|
|
expect(last_activity_message.content).to eq("Unassigned from #{team_1.name} by #{agent.name}")
|
|
end
|
|
|
|
it 'Bulk update conversation team id to team' do
|
|
params = { type: 'Conversation', fields: { team_id: team_1.id }, ids: Conversation.last(2).pluck(:display_id) }
|
|
expect(Conversation.last.team_id).to be_nil
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.last.team).to eq(team_1)
|
|
|
|
last_activity_message = Conversation.last.messages.activity.last
|
|
|
|
expect(last_activity_message.content).to eq("Assigned to #{team_1.name} by #{agent.name}")
|
|
end
|
|
|
|
it 'Bulk update conversation assignee id' do
|
|
params = { type: 'Conversation', fields: { assignee_id: agent_1.id }, ids: Conversation.first(3).pluck(:display_id) }
|
|
|
|
expect(Conversation.first.status).to eq('open')
|
|
expect(Conversation.first.assignee_id).to be_nil
|
|
expect(Conversation.second.assignee_id).to be_nil
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.assignee_id).to eq(agent_1.id)
|
|
expect(Conversation.second.assignee_id).to eq(agent_1.id)
|
|
expect(Conversation.first.status).to eq('open')
|
|
end
|
|
|
|
it 'Bulk remove assignee id from conversations' do
|
|
Conversation.first.update(assignee_id: agent_1.id)
|
|
Conversation.second.update(assignee_id: agent_2.id)
|
|
params = { type: 'Conversation', fields: { assignee_id: nil }, ids: Conversation.first(3).pluck(:display_id) }
|
|
|
|
expect(Conversation.first.status).to eq('open')
|
|
expect(Conversation.first.assignee_id).to eq(agent_1.id)
|
|
expect(Conversation.second.assignee_id).to eq(agent_2.id)
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.assignee_id).to be_nil
|
|
expect(Conversation.second.assignee_id).to be_nil
|
|
expect(Conversation.first.status).to eq('open')
|
|
end
|
|
|
|
it 'Do not bulk update status to nil' do
|
|
Conversation.first.update(assignee_id: agent_1.id)
|
|
Conversation.second.update(assignee_id: agent_2.id)
|
|
params = { type: 'Conversation', fields: { status: nil }, ids: Conversation.first(3).pluck(:display_id) }
|
|
|
|
expect(Conversation.first.status).to eq('open')
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.status).to eq('open')
|
|
end
|
|
|
|
it 'Bulk update conversation status and assignee id' do
|
|
params = { type: 'Conversation', fields: { assignee_id: agent_1.id, status: 'snoozed' }, ids: Conversation.first(3).pluck(:display_id) }
|
|
|
|
expect(Conversation.first.status).to eq('open')
|
|
expect(Conversation.second.assignee_id).to be_nil
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.assignee_id).to eq(agent_1.id)
|
|
expect(Conversation.second.assignee_id).to eq(agent_1.id)
|
|
expect(Conversation.first.status).to eq('snoozed')
|
|
expect(Conversation.second.status).to eq('snoozed')
|
|
end
|
|
|
|
it 'Bulk update conversation labels' do
|
|
params = { type: 'Conversation', ids: Conversation.first(3).pluck(:display_id), labels: { add: %w[support priority_customer] } }
|
|
|
|
expect(Conversation.first.labels).to eq([])
|
|
expect(Conversation.second.labels).to eq([])
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.label_list).to contain_exactly('support', 'priority_customer')
|
|
expect(Conversation.second.label_list).to contain_exactly('support', 'priority_customer')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST /api/v1/accounts/{account.id}/bulk_actions' do
|
|
context 'when it is an authenticated user' do
|
|
let!(:agent) { create(:user, account: account, role: :agent) }
|
|
|
|
it 'Bulk delete conversation labels' do
|
|
Conversation.first.add_labels(%w[support priority_customer])
|
|
Conversation.second.add_labels(%w[support priority_customer])
|
|
Conversation.third.add_labels(%w[support priority_customer])
|
|
|
|
params = { type: 'Conversation', ids: Conversation.first(3).pluck(:display_id), labels: { remove: %w[support] } }
|
|
|
|
expect(Conversation.first.label_list).to contain_exactly('support', 'priority_customer')
|
|
expect(Conversation.second.label_list).to contain_exactly('support', 'priority_customer')
|
|
|
|
perform_enqueued_jobs do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: params
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
expect(Conversation.first.label_list).to contain_exactly('priority_customer')
|
|
expect(Conversation.second.label_list).to contain_exactly('priority_customer')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'POST /api/v1/accounts/{account.id}/bulk_actions (contacts)' do
|
|
context 'when it is an authenticated user' do
|
|
let!(:agent) { create(:user, account: account, role: :agent) }
|
|
|
|
it 'enqueues Contacts::BulkActionJob with permitted params' do
|
|
contact_one = create(:contact, account: account)
|
|
contact_two = create(:contact, account: account)
|
|
|
|
expect do
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: {
|
|
type: 'Contact',
|
|
ids: [contact_one.id, contact_two.id],
|
|
labels: { add: %w[vip support] },
|
|
extra: 'ignored'
|
|
}
|
|
end.to have_enqueued_job(Contacts::BulkActionJob).with(
|
|
account.id,
|
|
agent.id,
|
|
hash_including(
|
|
'ids' => [contact_one.id.to_s, contact_two.id.to_s],
|
|
'labels' => hash_including('add' => %w[vip support])
|
|
)
|
|
)
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'returns unauthorized for delete action when user is not admin' do
|
|
contact = create(:contact, account: account)
|
|
|
|
post "/api/v1/accounts/#{account.id}/bulk_actions",
|
|
headers: agent.create_new_auth_token,
|
|
params: {
|
|
type: 'Contact',
|
|
ids: [contact.id],
|
|
action_name: 'delete'
|
|
}
|
|
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
end
|
|
end
|