# Pull Request Template ## Description Unconfirmed agents (pending email verification) were incorrectly appearing in the "assign agent" dropdown for macros and automations. This fix filters out unconfirmed agents from these dropdowns and adds backend validation to prevent assignment of unconfirmed agents. Fixes #13223 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? **Backend tests:** ```bash docker compose run --rm rails bundle exec rspec spec/services/action_service_spec.rb ``` - Added tests for confirmed agent assignment (should succeed) - Added tests for unconfirmed agent assignment (should be skipped) **Frontend tests:** ```bash docker compose run --rm rails pnpm test app/javascript/dashboard/composables/spec/useMacros.spec.js ``` - Updated mocks to use `getVerifiedAgents` getter **Manual testing:** 1. Create an unconfirmed agent via platform 2. Navigate to Settings → Macros → New Macro → Add "Assign Agent" action 3. Verify unconfirmed agent does NOT appear in dropdown 4. Navigate to Settings → Automations → New Automation → Add "Assign Agent" action 5. Verify unconfirmed agent does NOT appear in dropdown ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Sojan Jose <sojan@pepalo.com>
153 lines
4.4 KiB
JavaScript
153 lines
4.4 KiB
JavaScript
import { computed } from 'vue';
|
|
import { useI18n } from 'vue-i18n';
|
|
import languages from 'dashboard/components/widgets/conversation/advancedFilterItems/languages';
|
|
import countries from 'shared/constants/countries';
|
|
import { useStoreGetters, useMapGetter } from 'dashboard/composables/store';
|
|
|
|
import {
|
|
getActionOptions,
|
|
getConditionOptions,
|
|
} from 'dashboard/helper/automationHelper';
|
|
import {
|
|
MESSAGE_CONDITION_VALUES,
|
|
PRIORITY_CONDITION_VALUES,
|
|
} from 'dashboard/constants/automation';
|
|
|
|
/**
|
|
* This is a shared composables that holds utilities used to build dropdown and file options
|
|
* @returns {Object} An object containing various automation-related functions and computed properties.
|
|
*/
|
|
export default function useAutomationValues() {
|
|
const getters = useStoreGetters();
|
|
const { t } = useI18n();
|
|
const agents = useMapGetter('agents/getVerifiedAgents');
|
|
const campaigns = useMapGetter('campaigns/getAllCampaigns');
|
|
const contacts = useMapGetter('contacts/getContacts');
|
|
const inboxes = useMapGetter('inboxes/getInboxes');
|
|
const labels = useMapGetter('labels/getLabels');
|
|
const teams = useMapGetter('teams/getTeams');
|
|
const slaPolicies = useMapGetter('sla/getSLA');
|
|
|
|
const booleanFilterOptions = computed(() => [
|
|
{ id: true, name: t('FILTER.ATTRIBUTE_LABELS.TRUE') },
|
|
{ id: false, name: t('FILTER.ATTRIBUTE_LABELS.FALSE') },
|
|
]);
|
|
|
|
const statusFilterItems = computed(() => {
|
|
return {
|
|
open: {
|
|
TEXT: t('CHAT_LIST.CHAT_STATUS_FILTER_ITEMS.open.TEXT'),
|
|
},
|
|
resolved: {
|
|
TEXT: t('CHAT_LIST.CHAT_STATUS_FILTER_ITEMS.resolved.TEXT'),
|
|
},
|
|
pending: {
|
|
TEXT: t('CHAT_LIST.CHAT_STATUS_FILTER_ITEMS.pending.TEXT'),
|
|
},
|
|
snoozed: {
|
|
TEXT: t('CHAT_LIST.CHAT_STATUS_FILTER_ITEMS.snoozed.TEXT'),
|
|
},
|
|
all: {
|
|
TEXT: t('CHAT_LIST.CHAT_STATUS_FILTER_ITEMS.all.TEXT'),
|
|
},
|
|
};
|
|
});
|
|
|
|
const statusFilterOptions = computed(() => {
|
|
const statusFilters = statusFilterItems.value;
|
|
return [
|
|
...Object.keys(statusFilters).map(status => ({
|
|
id: status,
|
|
name: statusFilters[status].TEXT,
|
|
})),
|
|
{ id: 'all', name: t('CHAT_LIST.FILTER_ALL') },
|
|
];
|
|
});
|
|
|
|
const messageTypeOptions = computed(() =>
|
|
MESSAGE_CONDITION_VALUES.map(item => ({
|
|
id: item.id,
|
|
name: t(`AUTOMATION.MESSAGE_TYPES.${item.i18nKey}`),
|
|
}))
|
|
);
|
|
|
|
const priorityOptions = computed(() =>
|
|
PRIORITY_CONDITION_VALUES.map(item => ({
|
|
id: item.id,
|
|
name: t(`AUTOMATION.PRIORITY_TYPES.${item.i18nKey}`),
|
|
}))
|
|
);
|
|
|
|
/**
|
|
* Adds a translated "None" option to the beginning of a list
|
|
* @param {Array} list - The list to add "None" to
|
|
* @returns {Array} A new array with "None" option at the beginning
|
|
*/
|
|
const addNoneToList = list => [
|
|
{
|
|
id: 'nil',
|
|
name: t('AUTOMATION.NONE_OPTION') || 'None',
|
|
},
|
|
...(list || []),
|
|
];
|
|
|
|
/**
|
|
* Gets the condition dropdown values for a given type.
|
|
* @param {string} type - The type of condition.
|
|
* @returns {Array} An array of condition dropdown values.
|
|
*/
|
|
const getConditionDropdownValues = type => {
|
|
return getConditionOptions({
|
|
agents: agents.value,
|
|
booleanFilterOptions: booleanFilterOptions.value,
|
|
campaigns: campaigns.value,
|
|
contacts: contacts.value,
|
|
customAttributes: getters['attributes/getAttributes'].value,
|
|
inboxes: inboxes.value,
|
|
labels: labels.value,
|
|
statusFilterOptions: statusFilterOptions.value,
|
|
priorityOptions: priorityOptions.value,
|
|
messageTypeOptions: messageTypeOptions.value,
|
|
teams: teams.value,
|
|
languages,
|
|
countries,
|
|
type,
|
|
});
|
|
};
|
|
|
|
/**
|
|
* Gets the action dropdown values for a given type.
|
|
* @param {string} type - The type of action.
|
|
* @returns {Array} An array of action dropdown values.
|
|
*/
|
|
const getActionDropdownValues = type => {
|
|
return getActionOptions({
|
|
agents: agents.value,
|
|
labels: labels.value,
|
|
teams: teams.value,
|
|
slaPolicies: slaPolicies.value,
|
|
languages,
|
|
type,
|
|
addNoneToListFn: addNoneToList,
|
|
priorityOptions: priorityOptions.value,
|
|
});
|
|
};
|
|
|
|
return {
|
|
booleanFilterOptions,
|
|
statusFilterItems,
|
|
statusFilterOptions,
|
|
priorityOptions,
|
|
messageTypeOptions,
|
|
getConditionDropdownValues,
|
|
getActionDropdownValues,
|
|
agents,
|
|
campaigns,
|
|
contacts,
|
|
inboxes,
|
|
labels,
|
|
teams,
|
|
slaPolicies,
|
|
};
|
|
}
|