# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
107 lines
2.6 KiB
Vue
107 lines
2.6 KiB
Vue
<script>
|
|
import EditContact from 'dashboard/routes/dashboard/conversation/contact/EditContact.vue';
|
|
import NewConversation from 'dashboard/routes/dashboard/conversation/contact/NewConversation.vue';
|
|
import AddCustomAttribute from 'dashboard/modules/contact/components/AddCustomAttribute.vue';
|
|
import ContactIntro from './ContactIntro.vue';
|
|
import ContactFields from './ContactFields.vue';
|
|
|
|
export default {
|
|
components: {
|
|
AddCustomAttribute,
|
|
ContactFields,
|
|
ContactIntro,
|
|
EditContact,
|
|
NewConversation,
|
|
},
|
|
props: {
|
|
contact: {
|
|
type: Object,
|
|
default: () => ({}),
|
|
},
|
|
},
|
|
data() {
|
|
return {
|
|
showCustomAttributeModal: false,
|
|
showEditModal: false,
|
|
showConversationModal: false,
|
|
};
|
|
},
|
|
computed: {
|
|
enableNewConversation() {
|
|
return this.contact && this.contact.id;
|
|
},
|
|
},
|
|
methods: {
|
|
toggleCustomAttributeModal() {
|
|
this.showCustomAttributeModal = !this.showCustomAttributeModal;
|
|
},
|
|
toggleEditModal() {
|
|
this.showEditModal = !this.showEditModal;
|
|
},
|
|
toggleConversationModal() {
|
|
this.showConversationModal = !this.showConversationModal;
|
|
},
|
|
createCustomAttribute(data) {
|
|
const { id } = this.contact;
|
|
const { attributeValue, attributeName } = data;
|
|
const updatedFields = {
|
|
id,
|
|
custom_attributes: {
|
|
[attributeName]: attributeValue,
|
|
},
|
|
};
|
|
this.updateContact(updatedFields);
|
|
},
|
|
updateField(data) {
|
|
const { id } = this.contact;
|
|
const updatedFields = {
|
|
id,
|
|
...data,
|
|
};
|
|
this.updateContact(updatedFields);
|
|
},
|
|
updateContact(contactItem) {
|
|
this.$store.dispatch('contacts/update', contactItem);
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div class="panel">
|
|
<ContactIntro
|
|
:contact="contact"
|
|
@message="toggleConversationModal"
|
|
@edit="toggleEditModal"
|
|
/>
|
|
<ContactFields
|
|
:contact="contact"
|
|
@update="updateField"
|
|
@createAttribute="toggleCustomAttributeModal"
|
|
/>
|
|
<EditContact
|
|
v-if="showEditModal"
|
|
:show="showEditModal"
|
|
:contact="contact"
|
|
@cancel="toggleEditModal"
|
|
/>
|
|
<NewConversation
|
|
v-if="enableNewConversation"
|
|
:show="showConversationModal"
|
|
:contact="contact"
|
|
@cancel="toggleConversationModal"
|
|
/>
|
|
<AddCustomAttribute
|
|
:show="showCustomAttributeModal"
|
|
@cancel="toggleCustomAttributeModal"
|
|
@create="createCustomAttribute"
|
|
/>
|
|
</div>
|
|
</template>
|
|
|
|
<style scoped lang="scss">
|
|
.panel {
|
|
padding: var(--space-normal) var(--space-normal);
|
|
}
|
|
</style>
|