# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
115 lines
2.6 KiB
Vue
115 lines
2.6 KiB
Vue
<script>
|
|
import Attribute from './ContactAttribute.vue';
|
|
|
|
export default {
|
|
components: { Attribute },
|
|
props: {
|
|
contact: {
|
|
type: Object,
|
|
default: () => ({}),
|
|
},
|
|
},
|
|
|
|
computed: {
|
|
additionalAttributes() {
|
|
return this.contact.additional_attributes || {};
|
|
},
|
|
company() {
|
|
const { company = {} } = this.contact;
|
|
return company;
|
|
},
|
|
customAttributes() {
|
|
const { custom_attributes: customAttributes = {} } = this.contact;
|
|
return customAttributes;
|
|
},
|
|
customAttributekeys() {
|
|
return Object.keys(this.customAttributes).filter(key => {
|
|
const value = this.customAttributes[key];
|
|
return value !== null && value !== undefined;
|
|
});
|
|
},
|
|
},
|
|
methods: {
|
|
onEmailUpdate(value) {
|
|
this.$emit('update', { email: value });
|
|
},
|
|
onPhoneUpdate(value) {
|
|
this.$emit('update', { phone_number: value });
|
|
},
|
|
onLocationUpdate(value) {
|
|
this.$emit('update', { location: value });
|
|
},
|
|
handleCustomCreate() {
|
|
this.$emit('createAttribute');
|
|
},
|
|
onCustomAttributeUpdate(key, value) {
|
|
this.$emit('update', { custom_attributes: { [key]: value } });
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div class="contact-fields">
|
|
<h3 class="text-lg title">
|
|
{{ $t('CONTACTS_PAGE.FIELDS') }}
|
|
</h3>
|
|
<Attribute
|
|
:label="$t('CONTACT_PANEL.EMAIL_ADDRESS')"
|
|
icon="mail"
|
|
emoji=""
|
|
:value="contact.email"
|
|
show-edit
|
|
@update="onEmailUpdate"
|
|
/>
|
|
<Attribute
|
|
:label="$t('CONTACT_PANEL.PHONE_NUMBER')"
|
|
icon="call"
|
|
emoji=""
|
|
:value="contact.phone_number"
|
|
show-edit
|
|
@update="onPhoneUpdate"
|
|
/>
|
|
<Attribute
|
|
v-if="additionalAttributes.location"
|
|
:label="$t('CONTACT_PANEL.LOCATION')"
|
|
icon="map"
|
|
emoji="🌍"
|
|
:value="additionalAttributes.location"
|
|
show-edit
|
|
@update="onLocationUpdate"
|
|
/>
|
|
<div
|
|
v-for="attribute in customAttributekeys"
|
|
:key="attribute"
|
|
class="custom-attribute--row"
|
|
>
|
|
<Attribute
|
|
:label="attribute"
|
|
icon="chevron-right"
|
|
:value="customAttributes[attribute]"
|
|
show-edit
|
|
@update="value => onCustomAttributeUpdate(attribute, value)"
|
|
/>
|
|
</div>
|
|
<woot-button
|
|
size="small"
|
|
variant="link"
|
|
icon="add"
|
|
@click="handleCustomCreate"
|
|
>
|
|
{{ $t('CUSTOM_ATTRIBUTES.ADD.TITLE') }}
|
|
</woot-button>
|
|
</div>
|
|
</template>
|
|
|
|
<style scoped lang="scss">
|
|
.contact-fields {
|
|
margin-top: var(--space-medium);
|
|
}
|
|
|
|
.title {
|
|
margin-bottom: var(--space-normal);
|
|
}
|
|
</style>
|