# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
91 lines
2.2 KiB
Vue
91 lines
2.2 KiB
Vue
<script>
|
|
import { useAlert } from 'dashboard/composables';
|
|
import MergeContact from 'dashboard/modules/contact/components/MergeContact.vue';
|
|
|
|
import ContactAPI from 'dashboard/api/contacts';
|
|
|
|
import { mapGetters } from 'vuex';
|
|
import { CONTACTS_EVENTS } from '../../helper/AnalyticsHelper/events';
|
|
|
|
export default {
|
|
components: { MergeContact },
|
|
props: {
|
|
primaryContact: {
|
|
type: Object,
|
|
required: true,
|
|
},
|
|
show: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
},
|
|
data() {
|
|
return {
|
|
isSearching: false,
|
|
searchResults: [],
|
|
};
|
|
},
|
|
computed: {
|
|
...mapGetters({
|
|
uiFlags: 'contacts/getUIFlags',
|
|
}),
|
|
},
|
|
|
|
methods: {
|
|
onClose() {
|
|
this.$emit('close');
|
|
},
|
|
async onContactSearch(query) {
|
|
this.isSearching = true;
|
|
this.searchResults = [];
|
|
|
|
try {
|
|
const {
|
|
data: { payload },
|
|
} = await ContactAPI.search(query);
|
|
this.searchResults = payload.filter(
|
|
contact => contact.id !== this.primaryContact.id
|
|
);
|
|
} catch (error) {
|
|
useAlert(this.$t('MERGE_CONTACTS.SEARCH.ERROR_MESSAGE'));
|
|
} finally {
|
|
this.isSearching = false;
|
|
}
|
|
},
|
|
async onMergeContacts(parentContactId) {
|
|
this.$track(CONTACTS_EVENTS.MERGED_CONTACTS);
|
|
try {
|
|
await this.$store.dispatch('contacts/merge', {
|
|
childId: this.primaryContact.id,
|
|
parentId: parentContactId,
|
|
});
|
|
useAlert(this.$t('MERGE_CONTACTS.FORM.SUCCESS_MESSAGE'));
|
|
this.onClose();
|
|
} catch (error) {
|
|
useAlert(this.$t('MERGE_CONTACTS.FORM.ERROR_MESSAGE'));
|
|
}
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<!-- eslint-disable vue/no-mutating-props -->
|
|
<template>
|
|
<woot-modal :show.sync="show" :on-close="onClose">
|
|
<woot-modal-header
|
|
:header-title="$t('MERGE_CONTACTS.TITLE')"
|
|
:header-content="$t('MERGE_CONTACTS.DESCRIPTION')"
|
|
/>
|
|
|
|
<MergeContact
|
|
:primary-contact="primaryContact"
|
|
:is-searching="isSearching"
|
|
:is-merging="uiFlags.isMerging"
|
|
:search-results="searchResults"
|
|
@search="onContactSearch"
|
|
@cancel="onClose"
|
|
@submit="onMergeContacts"
|
|
/>
|
|
</woot-modal>
|
|
</template>
|