656ae41b24
When an IMAP server returns malformed or partial protocol responses, Inboxes::FetchImapEmailsJob can raise Net::IMAP::ResponseParseError, Net::IMAP::ResponseReadError, or Net::IMAP::ResponseTooLargeError. Previously these errors fell through to the generic StandardError handler and were captured repeatedly in Sentry. This PR updates app/jobs/inboxes/fetch_imap_emails_job.rb to treat those parser/read exceptions as handled IMAP failures by adding them to the existing IMAP/network rescue block, so they are logged and retried on the next scheduled run without exception tracking noise. fixes: https://chatwoot-p3.sentry.io/issues/7132037793/events/104fb9b4d80a4fb6ba3861c44c6c9b83/ How to reproduce: - Use an IMAP server/inbox that intermittently returns malformed or truncated protocol responses during search/fetch. - Run Inboxes::FetchImapEmailsJob for that channel and observe the raised parser/read exception. How this was tested: - bundle exec ruby -c app/jobs/inboxes/fetch_imap_emails_job.rb - bundle exec rubocop app/jobs/inboxes/fetch_imap_emails_job.rb
55 lines
2.2 KiB
Ruby
55 lines
2.2 KiB
Ruby
require 'net/imap'
|
|
|
|
class Inboxes::FetchImapEmailsJob < MutexApplicationJob
|
|
queue_as :scheduled_jobs
|
|
|
|
def perform(channel, interval = 1)
|
|
return unless should_fetch_email?(channel)
|
|
|
|
key = format(::Redis::Alfred::EMAIL_MESSAGE_MUTEX, inbox_id: channel.inbox.id)
|
|
|
|
with_lock(key, 5.minutes) do
|
|
process_email_for_channel(channel, interval)
|
|
end
|
|
rescue *ExceptionList::IMAP_EXCEPTIONS => e
|
|
Rails.logger.error "Authorization error for email channel - #{channel.inbox.id} : #{e.message}"
|
|
rescue EOFError, OpenSSL::SSL::SSLError, Net::IMAP::NoResponseError, Net::IMAP::BadResponseError, Net::IMAP::InvalidResponseError,
|
|
Net::IMAP::ResponseParseError, Net::IMAP::ResponseReadError, Net::IMAP::ResponseTooLargeError => e
|
|
Rails.logger.error "Error for email channel - #{channel.inbox.id} : #{e.message}"
|
|
rescue LockAcquisitionError
|
|
Rails.logger.error "Lock failed for #{channel.inbox.id}"
|
|
rescue StandardError => e
|
|
ChatwootExceptionTracker.new(e, account: channel.account).capture_exception
|
|
end
|
|
|
|
private
|
|
|
|
def should_fetch_email?(channel)
|
|
channel.imap_enabled? && !channel.reauthorization_required?
|
|
end
|
|
|
|
def process_email_for_channel(channel, interval)
|
|
inbound_emails = if channel.microsoft?
|
|
Imap::MicrosoftFetchEmailService.new(channel: channel, interval: interval).perform
|
|
elsif channel.google?
|
|
Imap::GoogleFetchEmailService.new(channel: channel, interval: interval).perform
|
|
else
|
|
Imap::FetchEmailService.new(channel: channel, interval: interval).perform
|
|
end
|
|
inbound_emails.map do |inbound_mail|
|
|
process_mail(inbound_mail, channel)
|
|
end
|
|
rescue OAuth2::Error => e
|
|
Rails.logger.error "Error for email channel - #{channel.inbox.id} : #{e.message}"
|
|
channel.authorization_error!
|
|
end
|
|
|
|
def process_mail(inbound_mail, channel)
|
|
Imap::ImapMailbox.new.process(inbound_mail, channel)
|
|
rescue StandardError => e
|
|
ChatwootExceptionTracker.new(e, account: channel.account).capture_exception
|
|
Rails.logger.error("
|
|
#{channel.provider} Email dropped: #{inbound_mail.from} and message_source_id: #{inbound_mail.message_id}")
|
|
end
|
|
end
|