11826e2a21
## Description Reduces the frequency of update_presence WebSocket calls from the live chat widget and fixes agents appearing offline when the dashboard is in a background tab. ## Fixes # (issue) https://github.com/chatwoot/chatwoot/issues/13720 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
58 lines
2.7 KiB
Ruby
58 lines
2.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe OnlineStatusTracker do
|
|
let!(:account) { create(:account) }
|
|
let!(:user1) { create(:user, account: account) }
|
|
let!(:user2) { create(:user, account: account) }
|
|
let!(:user3) { create(:user, account: account) }
|
|
|
|
context 'when get_available_users' do
|
|
before do
|
|
described_class.update_presence(account.id, 'User', user1.id)
|
|
described_class.update_presence(account.id, 'User', user2.id)
|
|
end
|
|
|
|
it 'returns only the online user ids with presence' do
|
|
expect(described_class.get_available_users(account.id).keys).to contain_exactly(user1.id.to_s, user2.id.to_s)
|
|
expect(described_class.get_available_users(account.id).values).not_to include(user3.id)
|
|
end
|
|
|
|
it 'returns agents who have auto offline configured false' do
|
|
user2.account_users.first.update(auto_offline: false)
|
|
expect(described_class.get_available_users(account.id).keys).to contain_exactly(user1.id.to_s, user2.id.to_s)
|
|
end
|
|
|
|
it 'returns the availability from the db if it is not present in redis and set it in redis' do
|
|
user2.account_users.find_by(account_id: account.id).update!(availability: 'offline')
|
|
# clear the redis cache to ensure values are fetched from db
|
|
Redis::Alfred.delete(format(Redis::Alfred::ONLINE_STATUS, account_id: account.id))
|
|
expect(described_class.get_available_users(account.id)[user1.id.to_s]).to eq('online')
|
|
expect(described_class.get_available_users(account.id)[user2.id.to_s]).to eq('offline')
|
|
# ensure online status is also set
|
|
expect(Redis::Alfred.hmget(format(Redis::Alfred::ONLINE_STATUS, account_id: account.id),
|
|
[user1.id.to_s, user2.id.to_s])).to eq(%w[online offline])
|
|
end
|
|
end
|
|
|
|
context 'when get_available_contacts' do
|
|
let(:online_contact) { create(:contact, account: account) }
|
|
let(:offline_contact) { create(:contact, account: account) }
|
|
|
|
before do
|
|
described_class.update_presence(account.id, 'Contact', online_contact.id)
|
|
# creating a stale record for offline contact presence
|
|
Redis::Alfred.zadd(format(Redis::Alfred::ONLINE_PRESENCE_CONTACTS, account_id: account.id),
|
|
(Time.zone.now - (OnlineStatusTracker::CONTACT_PRESENCE_DURATION + 20)).to_i, offline_contact.id)
|
|
end
|
|
|
|
it 'returns only the online contact ids with presence' do
|
|
expect(described_class.get_available_contacts(account.id).keys).to contain_exactly(online_contact.id.to_s)
|
|
end
|
|
|
|
it 'flushes the stale records from sorted set after the duration' do
|
|
described_class.get_available_contacts(account.id)
|
|
expect(Redis::Alfred.zscore(format(Redis::Alfred::ONLINE_PRESENCE_CONTACTS, account_id: account.id), offline_contact.id)).to be_nil
|
|
end
|
|
end
|
|
end
|