9967101b48
## PR#1: Reporting events rollup — model and write path Reporting queries currently hit the `reporting_events` table directly. This works, but the table grows linearly with event volume, and aggregation queries (counts, averages over date ranges) get progressively slower as accounts age. This PR introduces a pre-aggregated `reporting_events_rollups` table that stores daily per-metric, per-dimension (account/agent/inbox) totals. The write path is intentionally decoupled from the read path — rollup rows are written inline from the event listener via upsert, and a backfill service exists to rebuild historical data from raw events. Nothing reads from this table yet. The write path activates when an account has a `reporting_timezone` set (new account setting). The `reporting_events_rollup` feature flag controls only the future read path, not writes — so rollup data accumulates silently once timezone is configured. A `MetricRegistry` maps raw event names to rollup column semantics in one place, keeping the write and (future) read paths aligned. ### What changed - Migration for `reporting_events_rollups` with a unique composite index for upsert - `ReportingEventsRollup` model - `reporting_timezone` account setting with IANA timezone validation - `MetricRegistry` — single source of truth for event-to-metric mappings - `RollupService` — real-time upsert from event listener - `BackfillService` — rebuilds rollups for a given account + date from raw events - Rake tasks for interactive backfill and timezone setup - `reporting_events_rollup` feature flag (disabled by default) ### How to test 1. Set a `reporting_timezone` on an account (`Account.first.update!(reporting_timezone: 'Asia/Kolkata')`) 2. Resolve a conversation or trigger a first response 3. Check `ReportingEventsRollup.where(account_id: ...)` — rows should appear 4. Run backfill: `bundle exec rake reporting_events_rollup:backfill` and verify historical data populates --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
126 lines
3.4 KiB
Ruby
126 lines
3.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe ReportingEvents::EventMetricRegistry do
|
|
describe '.event_names' do
|
|
it 'returns the supported raw event names' do
|
|
expect(described_class.event_names).to eq(
|
|
%w[
|
|
conversation_resolved
|
|
first_response
|
|
reply_time
|
|
conversation_bot_resolved
|
|
conversation_bot_handoff
|
|
]
|
|
)
|
|
end
|
|
end
|
|
|
|
describe '.metrics_for' do
|
|
it 'returns the emitted rollup metrics for conversation_resolved' do
|
|
event = instance_double(ReportingEvent, name: 'conversation_resolved', value: 120, value_in_business_hours: 45)
|
|
|
|
expect(described_class.metrics_for(event)).to eq(
|
|
resolutions_count: {
|
|
count: 1,
|
|
sum_value: 0,
|
|
sum_value_business_hours: 0
|
|
},
|
|
resolution_time: {
|
|
count: 1,
|
|
sum_value: 120.0,
|
|
sum_value_business_hours: 45.0
|
|
}
|
|
)
|
|
end
|
|
|
|
it 'returns the emitted rollup metrics for first_response' do
|
|
event = instance_double(ReportingEvent, name: 'first_response', value: 80, value_in_business_hours: 20)
|
|
|
|
expect(described_class.metrics_for(event)).to eq(
|
|
first_response: {
|
|
count: 1,
|
|
sum_value: 80.0,
|
|
sum_value_business_hours: 20.0
|
|
}
|
|
)
|
|
end
|
|
|
|
it 'returns the emitted rollup metrics for reply_time' do
|
|
event = instance_double(ReportingEvent, name: 'reply_time', value: 40, value_in_business_hours: 15)
|
|
|
|
expect(described_class.metrics_for(event)).to eq(
|
|
reply_time: {
|
|
count: 1,
|
|
sum_value: 40.0,
|
|
sum_value_business_hours: 15.0
|
|
}
|
|
)
|
|
end
|
|
|
|
it 'returns the emitted rollup metrics for conversation_bot_resolved' do
|
|
event = instance_double(ReportingEvent, name: 'conversation_bot_resolved')
|
|
|
|
expect(described_class.metrics_for(event)).to eq(
|
|
bot_resolutions_count: {
|
|
count: 1,
|
|
sum_value: 0,
|
|
sum_value_business_hours: 0
|
|
}
|
|
)
|
|
end
|
|
|
|
it 'returns the emitted rollup metrics for conversation_bot_handoff' do
|
|
event = instance_double(ReportingEvent, name: 'conversation_bot_handoff')
|
|
|
|
expect(described_class.metrics_for(event)).to eq(
|
|
bot_handoffs_count: {
|
|
count: 1,
|
|
sum_value: 0,
|
|
sum_value_business_hours: 0
|
|
}
|
|
)
|
|
end
|
|
|
|
it 'returns an empty hash for unsupported events' do
|
|
event = instance_double(ReportingEvent, name: 'conversation_created')
|
|
|
|
expect(described_class.metrics_for(event)).to eq({})
|
|
end
|
|
end
|
|
|
|
describe '.metrics_for_aggregate' do
|
|
it 'returns aggregated rollup metrics for conversation_resolved groups' do
|
|
expect(
|
|
described_class.metrics_for_aggregate(
|
|
'conversation_resolved',
|
|
count: 3,
|
|
sum_value: 420,
|
|
sum_value_business_hours: 210
|
|
)
|
|
).to eq(
|
|
resolutions_count: {
|
|
count: 3,
|
|
sum_value: 0,
|
|
sum_value_business_hours: 0
|
|
},
|
|
resolution_time: {
|
|
count: 3,
|
|
sum_value: 420.0,
|
|
sum_value_business_hours: 210.0
|
|
}
|
|
)
|
|
end
|
|
|
|
it 'returns an empty hash for unsupported grouped events' do
|
|
expect(
|
|
described_class.metrics_for_aggregate(
|
|
'conversation_created',
|
|
count: 2,
|
|
sum_value: 100,
|
|
sum_value_business_hours: 50
|
|
)
|
|
).to eq({})
|
|
end
|
|
end
|
|
end
|