# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
150 lines
3.9 KiB
Vue
150 lines
3.9 KiB
Vue
<script>
|
|
import Modal from 'dashboard/components/Modal.vue';
|
|
import { useVuelidate } from '@vuelidate/core';
|
|
import { useAlert } from 'dashboard/composables';
|
|
import { required } from '@vuelidate/validators';
|
|
import allLocales from 'shared/constants/locales.js';
|
|
import { PORTALS_EVENTS } from '../../../../helper/AnalyticsHelper/events';
|
|
|
|
export default {
|
|
components: {
|
|
Modal,
|
|
},
|
|
props: {
|
|
show: {
|
|
type: Boolean,
|
|
default: true,
|
|
},
|
|
portal: {
|
|
type: Object,
|
|
default: () => ({}),
|
|
},
|
|
},
|
|
setup() {
|
|
return { v$: useVuelidate() };
|
|
},
|
|
data() {
|
|
return {
|
|
selectedLocale: '',
|
|
isUpdating: false,
|
|
};
|
|
},
|
|
computed: {
|
|
addedLocales() {
|
|
const { allowed_locales: allowedLocales } = this.portal.config;
|
|
return allowedLocales.map(locale => locale.code);
|
|
},
|
|
locales() {
|
|
const addedLocales = this.portal.config.allowed_locales.map(
|
|
locale => locale.code
|
|
);
|
|
return Object.keys(allLocales)
|
|
.map(key => {
|
|
return {
|
|
id: key,
|
|
name: allLocales[key],
|
|
code: key,
|
|
};
|
|
})
|
|
.filter(locale => {
|
|
return !addedLocales.includes(locale.code);
|
|
});
|
|
},
|
|
},
|
|
validations: {
|
|
selectedLocale: {
|
|
required,
|
|
},
|
|
},
|
|
methods: {
|
|
async onCreate() {
|
|
this.v$.$touch();
|
|
if (this.v$.$invalid) {
|
|
return;
|
|
}
|
|
const updatedLocales = this.addedLocales;
|
|
updatedLocales.push(this.selectedLocale);
|
|
this.isUpdating = true;
|
|
try {
|
|
await this.$store.dispatch('portals/update', {
|
|
portalSlug: this.portal.slug,
|
|
config: { allowed_locales: updatedLocales },
|
|
});
|
|
this.alertMessage = this.$t(
|
|
'HELP_CENTER.PORTAL.ADD_LOCALE.API.SUCCESS_MESSAGE'
|
|
);
|
|
this.onClose();
|
|
this.$track(PORTALS_EVENTS.CREATE_LOCALE, {
|
|
localeAdded: this.selectedLocale,
|
|
totalLocales: updatedLocales.length,
|
|
from: this.$route.name,
|
|
});
|
|
} catch (error) {
|
|
this.alertMessage =
|
|
error?.message ||
|
|
this.$t('HELP_CENTER.PORTAL.ADD_LOCALE.API.ERROR_MESSAGE');
|
|
} finally {
|
|
useAlert(this.alertMessage);
|
|
this.isUpdating = false;
|
|
}
|
|
},
|
|
onClose() {
|
|
this.$emit('cancel');
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<!-- eslint-disable vue/no-mutating-props -->
|
|
<template>
|
|
<Modal :show.sync="show" :on-close="onClose">
|
|
<woot-modal-header
|
|
:header-title="$t('HELP_CENTER.PORTAL.ADD_LOCALE.TITLE')"
|
|
:header-content="$t('HELP_CENTER.PORTAL.ADD_LOCALE.SUB_TITLE')"
|
|
/>
|
|
<form class="w-full" @submit.prevent="onCreate">
|
|
<div class="w-full">
|
|
<label :class="{ error: v$.selectedLocale.$error }">
|
|
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.LOCALE.LABEL') }}
|
|
<select v-model="selectedLocale">
|
|
<option
|
|
v-for="locale in locales"
|
|
:key="locale.name"
|
|
:value="locale.id"
|
|
>
|
|
{{ locale.name }}-{{ locale.code }}
|
|
</option>
|
|
</select>
|
|
<span v-if="v$.selectedLocale.$error" class="message">
|
|
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.LOCALE.ERROR') }}
|
|
</span>
|
|
</label>
|
|
|
|
<div class="w-full">
|
|
<div class="flex flex-row justify-end w-full gap-2 px-0 py-2">
|
|
<woot-button class="button clear" @click.prevent="onClose">
|
|
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.BUTTONS.CANCEL') }}
|
|
</woot-button>
|
|
<woot-button>
|
|
{{ $t('HELP_CENTER.PORTAL.ADD_LOCALE.BUTTONS.CREATE') }}
|
|
</woot-button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</form>
|
|
</Modal>
|
|
</template>
|
|
|
|
<style scoped lang="scss">
|
|
.input-container::v-deep {
|
|
margin: 0 0 var(--space-normal);
|
|
|
|
input {
|
|
margin-bottom: 0;
|
|
}
|
|
.message {
|
|
margin-top: 0;
|
|
}
|
|
}
|
|
</style>
|