### What Forces `account_id` to be applied consistently in queries and message creation paths. ### Why Some queries were missing `account_id`, leading to cross-account scans and slow performance in large datasets. ### Changes * Added `account_id` to the relevant query columns. * Ensured messages are always created within the correct account scope. * Updated `created_at` handling where required for consistency. ### Impact * Prevents cross-account queries. * Improves query performance. * Reduces risk of incorrect data access across accounts. ### Notes No functional behavior change for end users. This is a performance and safety fix.
71 lines
1.8 KiB
Ruby
71 lines
1.8 KiB
Ruby
class Conversations::MessageWindowService
|
|
MESSAGING_WINDOW_24_HOURS = 24.hours
|
|
MESSAGING_WINDOW_7_DAYS = 7.days
|
|
|
|
def initialize(conversation)
|
|
@conversation = conversation
|
|
end
|
|
|
|
def can_reply?
|
|
return true if messaging_window.blank?
|
|
|
|
last_message_in_messaging_window?(messaging_window)
|
|
end
|
|
|
|
private
|
|
|
|
def messaging_window
|
|
case @conversation.inbox.channel_type
|
|
when 'Channel::Api'
|
|
api_messaging_window
|
|
when 'Channel::FacebookPage'
|
|
messenger_messaging_window
|
|
when 'Channel::Instagram'
|
|
instagram_messaging_window
|
|
when 'Channel::Tiktok'
|
|
tiktok_messaging_window
|
|
when 'Channel::Whatsapp'
|
|
MESSAGING_WINDOW_24_HOURS
|
|
when 'Channel::TwilioSms'
|
|
twilio_messaging_window
|
|
end
|
|
end
|
|
|
|
def last_message_in_messaging_window?(time)
|
|
return false if last_incoming_message.nil?
|
|
|
|
Time.current < last_incoming_message.created_at + time
|
|
end
|
|
|
|
def api_messaging_window
|
|
return if @conversation.inbox.channel.additional_attributes['agent_reply_time_window'].blank?
|
|
|
|
@conversation.inbox.channel.additional_attributes['agent_reply_time_window'].to_i.hours
|
|
end
|
|
|
|
# Check medium of the inbox to determine the messaging window
|
|
def twilio_messaging_window
|
|
@conversation.inbox.channel.medium == 'whatsapp' ? MESSAGING_WINDOW_24_HOURS : nil
|
|
end
|
|
|
|
def messenger_messaging_window
|
|
meta_messaging_window('ENABLE_MESSENGER_CHANNEL_HUMAN_AGENT')
|
|
end
|
|
|
|
def instagram_messaging_window
|
|
meta_messaging_window('ENABLE_INSTAGRAM_CHANNEL_HUMAN_AGENT')
|
|
end
|
|
|
|
def tiktok_messaging_window
|
|
48.hours
|
|
end
|
|
|
|
def meta_messaging_window(config_key)
|
|
GlobalConfigService.load(config_key, nil) ? MESSAGING_WINDOW_7_DAYS : MESSAGING_WINDOW_24_HOURS
|
|
end
|
|
|
|
def last_incoming_message
|
|
@last_incoming_message ||= @conversation.messages.where(account_id: @conversation.account_id).incoming&.last
|
|
end
|
|
end
|