aa7e3c2d38
Langfuse logging improvements ## Description Please include a summary of the change and issue(s) fixed. Also, mention relevant motivation, context, and any dependencies that this change requires. Fixes # (issue) For reply suggestion: the errors are being stored inside output field, but observations should be marked as errors. For assistant: add credit_used metadata to filter handoffs from ai-replies For langfuse tool call: add `observation_type=tool` ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. before: <img width="1028" height="57" alt="image" src="https://github.com/user-attachments/assets/70f6a36e-6c33-444c-a083-723c7c9e823a" /> after: <img width="872" height="69" alt="image" src="https://github.com/user-attachments/assets/1b6b6f5f-5384-4e9c-92ba-f56748fec6dd" /> `credit_used` to filter handoffs from AI replies that cause credit usage <img width="1082" height="672" alt="image" src="https://github.com/user-attachments/assets/90914227-553a-4c03-bc43-56b2018ac7c1" /> set `observation_type` to `tool` <img width="726" height="1452" alt="image" src="https://github.com/user-attachments/assets/e639cc9b-1c6c-4427-887e-23e5523bf64f" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
76 lines
2.0 KiB
Ruby
76 lines
2.0 KiB
Ruby
module Captain::ChatResponseHelper
|
|
include Integrations::LlmInstrumentationConstants
|
|
|
|
private
|
|
|
|
def build_response(response)
|
|
Rails.logger.debug { "#{self.class.name} Assistant: #{@assistant.id}, Received response #{response}" }
|
|
|
|
parsed = parse_json_response(response.content)
|
|
apply_credit_usage_metadata(parsed)
|
|
|
|
persist_message(parsed, 'assistant')
|
|
parsed
|
|
end
|
|
|
|
def parse_json_response(content)
|
|
content = content.gsub('```json', '').gsub('```', '')
|
|
content = content.strip
|
|
JSON.parse(content)
|
|
rescue JSON::ParserError => e
|
|
Rails.logger.error "#{self.class.name} Assistant: #{@assistant.id}, Error parsing JSON response: #{e.message}"
|
|
{ 'content' => content }
|
|
end
|
|
|
|
def apply_credit_usage_metadata(parsed_response)
|
|
return unless captain_v1_assistant?
|
|
|
|
OpenTelemetry::Trace.current_span.set_attribute(
|
|
format(ATTR_LANGFUSE_METADATA, 'credit_used'),
|
|
credit_used_for_response?(parsed_response).to_s
|
|
)
|
|
rescue StandardError => e
|
|
Rails.logger.warn "#{self.class.name} Assistant: #{@assistant.id}, Failed to set credit usage metadata: #{e.message}"
|
|
end
|
|
|
|
def credit_used_for_response?(parsed_response)
|
|
response = parsed_response['response']
|
|
response.present? && response != 'conversation_handoff'
|
|
end
|
|
|
|
def captain_v1_assistant?
|
|
feature_name == 'assistant' && !@assistant.account.feature_enabled?('captain_integration_v2')
|
|
end
|
|
|
|
def persist_thinking_message(tool_call)
|
|
return if @copilot_thread.blank?
|
|
|
|
tool_name = tool_call.name.to_s
|
|
|
|
persist_message(
|
|
{
|
|
'content' => "Using #{tool_name}",
|
|
'function_name' => tool_name
|
|
},
|
|
'assistant_thinking'
|
|
)
|
|
end
|
|
|
|
def persist_tool_completion
|
|
return if @copilot_thread.blank?
|
|
|
|
tool_call = @pending_tool_calls&.pop
|
|
return unless tool_call
|
|
|
|
tool_name = tool_call.name.to_s
|
|
|
|
persist_message(
|
|
{
|
|
'content' => "Completed #{tool_name}",
|
|
'function_name' => tool_name
|
|
},
|
|
'assistant_thinking'
|
|
)
|
|
end
|
|
end
|