LeadMagnet/leadchat
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix: captain json parsing (#13708)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Shivam Mishra <scm.mymail@gmail.com>
This commit is contained in:
Aakash Bakhle
2026-03-05 15:43:21 +05:30
committed by GitHub
parent 3ea5f258a4
commit fd69b4c8f2
8 changed files with 60 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
enterprise/app/services/captain/llm/contact_attributes_service.rb
View File

@@ -1,5 +1,6 @@
class Captain::Llm::ContactAttributesService < Llm::BaseAiService
include Integrations::LlmInstrumentation
def initialize(assistant, conversation)
super()
@assistant = assistant
@@ -52,7 +53,7 @@ class Captain::Llm::ContactAttributesService < Llm::BaseAiService
def parse_response(content)
return [] if content.nil?
JSON.parse(content.strip).fetch('attributes', [])
JSON.parse(sanitize_json_response(content)).fetch('attributes', [])
rescue JSON::ParserError => e
Rails.logger.error "Error in parsing GPT processed response: #{e.message}"
[]

3
enterprise/app/services/captain/llm/contact_notes_service.rb
View File

@@ -1,5 +1,6 @@
class Captain::Llm::ContactNotesService < Llm::BaseAiService
include Integrations::LlmInstrumentation
def initialize(assistant, conversation)
super()
@assistant = assistant
@@ -55,7 +56,7 @@ class Captain::Llm::ContactNotesService < Llm::BaseAiService
def parse_response(response)
return [] if response.nil?
JSON.parse(response.strip).fetch('notes', [])
JSON.parse(sanitize_json_response(response)).fetch('notes', [])
rescue JSON::ParserError => e
Rails.logger.error "Error in parsing GPT processed response: #{e.message}"
[]

3
enterprise/app/services/captain/llm/conversation_faq_service.rb
View File

@@ -1,5 +1,6 @@
class Captain::Llm::ConversationFaqService < Llm::BaseAiService
include Integrations::LlmInstrumentation
DISTANCE_THRESHOLD = 0.3
def initialize(assistant, conversation)
@@ -118,7 +119,7 @@ class Captain::Llm::ConversationFaqService < Llm::BaseAiService
def parse_response(response)
return [] if response.nil?
JSON.parse(response.strip).fetch('faqs', [])
JSON.parse(sanitize_json_response(response)).fetch('faqs', [])
rescue JSON::ParserError => e
Rails.logger.error "Error in parsing GPT processed response: #{e.message}"
[]

2
enterprise/app/services/captain/llm/faq_generator_service.rb
View File

@@ -47,7 +47,7 @@ class Captain::Llm::FaqGeneratorService < Llm::BaseAiService
def parse_response(content)
return [] if content.nil?
JSON.parse(content.strip).fetch('faqs', [])
JSON.parse(sanitize_json_response(content)).fetch('faqs', [])
rescue JSON::ParserError => e
Rails.logger.error "Error in parsing GPT processed response: #{e.message}"
[]

4
enterprise/app/services/captain/llm/paginated_faq_generator_service.rb
View File

@@ -163,7 +163,7 @@ class Captain::Llm::PaginatedFaqGeneratorService < Llm::LegacyBaseOpenAiService
content = response.dig('choices', 0, 'message', 'content')
return [] if content.nil?
JSON.parse(content.strip).fetch('faqs', [])
JSON.parse(sanitize_json_response(content)).fetch('faqs', [])
rescue JSON::ParserError => e
Rails.logger.error "Error parsing response: #{e.message}"
[]
@@ -173,7 +173,7 @@ class Captain::Llm::PaginatedFaqGeneratorService < Llm::LegacyBaseOpenAiService
content = response.dig('choices', 0, 'message', 'content')
return { 'faqs' => [], 'has_content' => false } if content.nil?
JSON.parse(content.strip)
JSON.parse(sanitize_json_response(content))
rescue JSON::ParserError => e
Rails.logger.error "Error parsing chunk response: #{e.message}"
{ 'faqs' => [], 'has_content' => false }