Chore: Added tests for conversations_controller (#508)

* Chore: Added tests for conversations_controller
* Chore: Remove get_messages function from conversations
This commit is contained in:
Tim Lange
2020-02-17 11:27:57 +01:00
committed by GitHub
parent 44a3977f5c
commit fc23a10a99
4 changed files with 114 additions and 28 deletions

View File

@@ -1,11 +1,5 @@
class Api::V1::ConversationsController < Api::BaseController
before_action :set_conversation, except: [:index, :get_messages]
# TODO: move this to public controller
skip_before_action :authenticate_user!, only: [:get_messages]
skip_before_action :set_current_user, only: [:get_messages]
skip_before_action :check_subscription, only: [:get_messages]
skip_around_action :handle_with_exception, only: [:get_messages]
before_action :set_conversation, except: [:index]
def index
result = conversation_finder.perform
@@ -27,11 +21,6 @@ class Api::V1::ConversationsController < Api::BaseController
head :ok
end
def get_messages
@conversation = Conversation.find(params[:id])
@messages = messages_finder.perform
end
private
def parsed_last_seen_at

View File

@@ -1,15 +0,0 @@
json.payload do
json.array! @messages do |message|
json.id message.id
json.content message.content
json.inbox_id message.inbox_id
json.conversation_id message.conversation.display_id
json.message_type message.message_type_before_type_cast
json.created_at message.created_at.to_i
json.private message.private
json.source_id message.source_id
json.attachment message.attachment.push_event_data if message.attachment
json.sender message.user.push_event_data if message.user
json.contact message.contact
end
end