From f8ae6cd95c5e6f8701561845ca8f64b8afb05c36 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Wed, 26 Jul 2023 17:40:41 +0530
Subject: [PATCH] fix: no method error when conversation is nil (#7566)

---
 .../conversation/conversation/LabelSuggestion.vue        | 9 ++-------
 app/javascript/dashboard/mixins/aiMixin.js               | 2 ++
 .../enterprise/integrations/openai_processor_service.rb  | 9 ++++++---
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/javascript/dashboard/components/widgets/conversation/conversation/LabelSuggestion.vue b/app/javascript/dashboard/components/widgets/conversation/conversation/LabelSuggestion.vue
index 1dc859b90..8c5e918c6 100644
--- a/app/javascript/dashboard/components/widgets/conversation/conversation/LabelSuggestion.vue
+++ b/app/javascript/dashboard/components/widgets/conversation/conversation/LabelSuggestion.vue
@@ -8,7 +8,7 @@
     <div class="wrap">
       <div class="label-suggestion--container">
         <h6 class="label-suggestion--title">Suggested labels</h6>
-        <div v-if="!fetchingSuggestions" class="label-suggestion--options">
+        <div class="label-suggestion--options">
           <button
             v-for="label in preparedLabels"
             :key="label.title"
@@ -123,7 +123,6 @@ export default {
   data() {
     return {
       isDismissed: false,
-      fetchingSuggestions: false,
       isHovered: false,
       selectedLabels: [],
     };
@@ -160,11 +159,7 @@ export default {
       if (this.isDismissed) return false;
       if (!this.isAIIntegrationEnabled) return false;
 
-      return (
-        !this.fetchingSuggestions &&
-        this.preparedLabels.length &&
-        this.chatLabels.length === 0
-      );
+      return this.preparedLabels.length && this.chatLabels.length === 0;
     },
   },
   watch: {
diff --git a/app/javascript/dashboard/mixins/aiMixin.js b/app/javascript/dashboard/mixins/aiMixin.js
index fb6d63611..e0488f99d 100644
--- a/app/javascript/dashboard/mixins/aiMixin.js
+++ b/app/javascript/dashboard/mixins/aiMixin.js
@@ -50,6 +50,8 @@ export default {
       }
     },
     async fetchLabelSuggestions({ conversationId }) {
+      if (!conversationId) return [];
+
       try {
         const result = await OpenAPI.processEvent({
           type: 'label_suggestion',
diff --git a/enterprise/lib/enterprise/integrations/openai_processor_service.rb b/enterprise/lib/enterprise/integrations/openai_processor_service.rb
index 4ef6bec6d..d081a5e92 100644
--- a/enterprise/lib/enterprise/integrations/openai_processor_service.rb
+++ b/enterprise/lib/enterprise/integrations/openai_processor_service.rb
@@ -23,14 +23,17 @@ module Enterprise::Integrations::OpenaiProcessorService
   end
 
   def labels_with_messages
-    labels = hook.account.labels.pluck(:title).join(', ')
-
-    character_count = labels.length
     conversation = find_conversation
 
+    # return nil if conversation is not present
+    return nil if conversation.nil?
+
     # return nil if conversation has less than 3 incoming messages
     return nil if conversation.messages.incoming.count < 3
 
+    labels = hook.account.labels.pluck(:title).join(', ')
+    character_count = labels.length
+
     messages = init_messages_body(false)
     add_messages_until_token_limit(conversation, messages, false, character_count)