diff --git a/app/services/account_deletion_service.rb b/app/services/account_deletion_service.rb index 62bce601b..ab9555efb 100644 --- a/app/services/account_deletion_service.rb +++ b/app/services/account_deletion_service.rb @@ -1,4 +1,6 @@ class AccountDeletionService + SOFT_DELETE_EMAIL_DOMAIN = '@chatwoot-deleted.invalid'.freeze + attr_reader :account, :soft_deleted_users def initialize(account:) @@ -25,15 +27,11 @@ class AccountDeletionService def soft_delete_orphaned_users account.users.each do |user| - # Find all account_users for this user excluding the current account - other_accounts = user.account_users.where.not(account_id: account.id).count + # Skip users who are still associated with another account. + next if user.account_users.where.not(account_id: account.id).exists? - # If user has no other accounts, soft delete them - next unless other_accounts.zero? - - # Soft delete user by appending -deleted.com to email original_email = user.email - user.email = "#{original_email}-deleted.com" + user.email = soft_deleted_email_for(user) user.skip_reconfirmation! user.save! @@ -47,4 +45,8 @@ class AccountDeletionService Rails.logger.info("Soft deleted user #{user.id} with email #{original_email}") end end + + def soft_deleted_email_for(user) + "#{user.id}#{SOFT_DELETE_EMAIL_DOMAIN}" + end end diff --git a/spec/services/account_deletion_service_spec.rb b/spec/services/account_deletion_service_spec.rb index 6b263c5b3..bd1dc88ee 100644 --- a/spec/services/account_deletion_service_spec.rb +++ b/spec/services/account_deletion_service_spec.rb @@ -46,7 +46,8 @@ RSpec.describe AccountDeletionService do # Reload the user to get the updated email user_with_one_account.reload - expect(user_with_one_account.email).to eq("#{original_email}-deleted.com") + expect(user_with_one_account.email).to eq("#{user_with_one_account.id}@chatwoot-deleted.invalid") + expect(user_with_one_account.email).not_to eq(original_email) end it 'does not modify emails for users belonging to multiple accounts' do