diff --git a/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb b/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb index 382584bc8..379693e89 100644 --- a/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb +++ b/enterprise/app/jobs/enterprise/sentiment_analysis_job.rb @@ -1,5 +1,5 @@ class Enterprise::SentimentAnalysisJob < ApplicationJob - queue_as :default + queue_as :low def perform(message) return if message.account.locale != 'en' @@ -27,11 +27,11 @@ class Enterprise::SentimentAnalysisJob < ApplicationJob # Model initializes OnnxRuntime::Model, with given file for inference session and to create the tensor def model - model = save_and_open_sentiment_file + model_file = save_and_open_sentiment_file - return if File.empty?(model) + return if File.empty?(model_file) - Informers::SentimentAnalysis.new(model) + Informers::SentimentAnalysis.new(model_file) end def label_val(sentiment) diff --git a/enterprise/app/models/enterprise/message.rb b/enterprise/app/models/enterprise/message.rb index 30c49da3d..4f72d8c19 100644 --- a/enterprise/app/models/enterprise/message.rb +++ b/enterprise/app/models/enterprise/message.rb @@ -1,5 +1,5 @@ module Enterprise::Message def update_message_sentiments - ::Enterprise::SentimentAnalysisJob.perform_later(self) + ::Enterprise::SentimentAnalysisJob.perform_later(self) if ENV.fetch('SENTIMENT_FILE_PATH', nil) end end diff --git a/spec/enterprise/models/message_spec.rb b/spec/enterprise/models/message_spec.rb index 4da7e6947..5fd423163 100644 --- a/spec/enterprise/models/message_spec.rb +++ b/spec/enterprise/models/message_spec.rb @@ -8,11 +8,13 @@ RSpec.describe Message do let(:message) { build(:message, message_type: :incoming, content_type: nil, account: create(:account)) } it 'calls SentimentAnalysisJob' do - allow(Enterprise::SentimentAnalysisJob).to receive(:perform_later).and_return(:perform_later).with(message) + with_modified_env SENTIMENT_FILE_PATH: 'sentiment-analysis.onnx' do + allow(Enterprise::SentimentAnalysisJob).to receive(:perform_later).and_return(:perform_later).with(message) - message.save! + message.save! - expect(Enterprise::SentimentAnalysisJob).to have_received(:perform_later) + expect(Enterprise::SentimentAnalysisJob).to have_received(:perform_later) + end end end end