From f0538b25ed43ca7a983f0f2c97280daf805e0673 Mon Sep 17 00:00:00 2001 From: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Date: Tue, 25 Nov 2025 18:47:18 +0530 Subject: [PATCH] fix: Reactive assistantId issue in Captain Inbox after route changes (#12939) --- .../routes/dashboard/captain/assistants/inboxes/Index.vue | 5 +++-- .../routes/dashboard/captain/responses/Pending.vue | 8 ++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/app/javascript/dashboard/routes/dashboard/captain/assistants/inboxes/Index.vue b/app/javascript/dashboard/routes/dashboard/captain/assistants/inboxes/Index.vue index f270af3d7..62db5e495 100644 --- a/app/javascript/dashboard/routes/dashboard/captain/assistants/inboxes/Index.vue +++ b/app/javascript/dashboard/routes/dashboard/captain/assistants/inboxes/Index.vue @@ -13,6 +13,8 @@ import InboxPageEmptyState from 'dashboard/components-next/captain/pageComponent const store = useStore(); const dialogType = ref(''); const route = useRoute(); + +const assistantId = computed(() => route.params.assistantId); const assistantUiFlags = useMapGetter('captainAssistants/getUIFlags'); const uiFlags = useMapGetter('captainInboxes/getUIFlags'); const isFetchingAssistant = computed(() => assistantUiFlags.value.fetchingItem); @@ -47,10 +49,9 @@ const handleCreateClose = () => { selectedInbox.value = null; }; -const assistantId = Number(route.params.assistantId); onMounted(() => store.dispatch('captainInboxes/get', { - assistantId: assistantId, + assistantId: assistantId.value, }) ); diff --git a/app/javascript/dashboard/routes/dashboard/captain/responses/Pending.vue b/app/javascript/dashboard/routes/dashboard/captain/responses/Pending.vue index f702387e6..b26658f9c 100644 --- a/app/javascript/dashboard/routes/dashboard/captain/responses/Pending.vue +++ b/app/javascript/dashboard/routes/dashboard/captain/responses/Pending.vue @@ -34,7 +34,7 @@ const selectedResponse = ref(null); const deleteDialog = ref(null); const bulkDeleteDialog = ref(null); -const selectedAssistantId = Number(route.params.assistantId); +const selectedAssistantId = computed(() => route.params.assistantId); const dialogType = ref(''); const searchQuery = ref(''); const { t } = useI18n(); @@ -45,7 +45,7 @@ const backUrl = computed(() => ({ name: 'captain_assistants_responses_index', params: { accountId: route.params.accountId, - assistantId: selectedAssistantId, + assistantId: selectedAssistantId.value, }, })); @@ -125,8 +125,8 @@ const updateURLWithFilters = (page, search) => { const fetchResponses = (page = 1) => { const filterParams = { page, status: 'pending' }; - if (selectedAssistantId) { - filterParams.assistantId = selectedAssistantId; + if (selectedAssistantId.value) { + filterParams.assistantId = selectedAssistantId.value; } if (searchQuery.value) { filterParams.search = searchQuery.value;