diff --git a/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue b/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue index aa1def9e9..5ae0cec2f 100644 --- a/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue +++ b/app/javascript/dashboard/routes/dashboard/settings/inbox/Settings.vue @@ -206,7 +206,8 @@ export default { this.isASmsInbox || this.isAWhatsAppChannel || this.isAFacebookInbox || - this.isAPIInbox + this.isAPIInbox || + this.isATelegramChannel ); }, inboxNameLabel() { diff --git a/app/services/telegram/incoming_message_service.rb b/app/services/telegram/incoming_message_service.rb index 6eeb192f2..897db29c3 100644 --- a/app/services/telegram/incoming_message_service.rb +++ b/app/services/telegram/incoming_message_service.rb @@ -77,7 +77,13 @@ class Telegram::IncomingMessageService end def set_conversation - @conversation = @contact_inbox.conversations.first + # if lock to single conversation is disabled, we will create a new conversation if previous conversation is resolved + @conversation = if @inbox.lock_to_single_conversation + @contact_inbox.conversations.last + else + @contact_inbox.conversations + .where.not(status: :resolved).last + end return if @conversation @conversation = ::Conversation.create!(conversation_params) diff --git a/spec/services/telegram/incoming_message_service_spec.rb b/spec/services/telegram/incoming_message_service_spec.rb index ef43dbe24..528161afe 100644 --- a/spec/services/telegram/incoming_message_service_spec.rb +++ b/spec/services/telegram/incoming_message_service_spec.rb @@ -411,4 +411,75 @@ describe Telegram::IncomingMessageService do end end end + + context 'when lock to single conversation is enabled' do + before do + # ensure message_params exists in this context and has from.id + message_params[:from] ||= {} + message_params[:from][:id] ||= 23 + end + + it 'reopens last conversation if last conversation is resolved' do + telegram_channel.inbox.update!(lock_to_single_conversation: true) + contact_inbox = ContactInbox.find_or_create_by(inbox: telegram_channel.inbox, source_id: message_params[:from][:id]) do |ci| + ci.contact = create(:contact) + end + resolved_conversation = create(:conversation, inbox: telegram_channel.inbox, contact_inbox: contact_inbox, status: :resolved) + + params = { + 'update_id' => 2_342_342_343_242, + 'message' => { 'text' => 'test' }.merge(message_params) + }.with_indifferent_access + + described_class.new(inbox: telegram_channel.inbox, params: params).perform + + expect(telegram_channel.inbox.conversations.count).to eq(1) + expect(resolved_conversation.reload.messages.last.content).to eq('test') + end + end + + context 'when lock to single conversation is disabled' do + before do + # ensure message_params exists in this context and has from.id + message_params[:from] ||= {} + message_params[:from][:id] ||= 23 + end + + it 'creates new conversation if last conversation is resolved' do + telegram_channel.inbox.update!(lock_to_single_conversation: false) + contact_inbox = ContactInbox.find_or_create_by(inbox: telegram_channel.inbox, source_id: message_params[:from][:id]) do |ci| + ci.contact = create(:contact) + end + _resolved_conversation = create(:conversation, inbox: telegram_channel.inbox, contact_inbox: contact_inbox, status: :resolved) + + params = { + 'update_id' => 2_342_342_343_242, + 'message' => { 'text' => 'test' }.merge(message_params) + }.with_indifferent_access + + described_class.new(inbox: telegram_channel.inbox, params: params).perform + + expect(telegram_channel.inbox.conversations.count).to eq(2) + expect(telegram_channel.inbox.conversations.last.messages.first.content).to eq('test') + expect(telegram_channel.inbox.conversations.last.status).to eq('open') + end + + it 'appends to last conversation if last conversation is not resolved' do + telegram_channel.inbox.update!(lock_to_single_conversation: false) + contact_inbox = ContactInbox.find_or_create_by(inbox: telegram_channel.inbox, source_id: message_params[:from][:id]) do |ci| + ci.contact = create(:contact) + end + open_conversation = create(:conversation, inbox: telegram_channel.inbox, contact_inbox: contact_inbox, status: :open) + + params = { + 'update_id' => 2_342_342_343_242, + 'message' => { 'text' => 'test' }.merge(message_params) + }.with_indifferent_access + + described_class.new(inbox: telegram_channel.inbox, params: params).perform + + expect(telegram_channel.inbox.conversations.count).to eq(1) + expect(open_conversation.reload.messages.last.content).to eq('test') + end + end end