fix: Update inline image processing logic to fix missing images when multiple inline images present (#7861)

spec/mailboxes/mailbox_helper_spec.rb

@@ -0,0 +1,51 @@
+require 'rails_helper'
+
+RSpec.describe MailboxHelper do
+  include ActionMailbox::TestHelper
+
+  # Setup anonymous class
+  let(:mailbox_helper_obj) do
+    Class.new do
+      include MailboxHelper
+      attr_accessor :conversation, :processed_mail
+
+      def initialize(conversation, processed_mail)
+        @conversation = conversation
+        @processed_mail = processed_mail
+      end
+    end
+  end
+
+  let(:mail) { create_inbound_email_from_fixture('welcome.eml').mail }
+  let(:processed_mail) { MailPresenter.new(mail) }
+  let(:conversation) { create(:conversation) }
+  let(:dummy_message) { create(:message) }
+
+  describe '#create_message' do
+    before do
+      create_list(:message, 5, conversation: conversation)
+    end
+
+    context 'when message already exist' do
+      it 'creates a new message' do
+        helper_instance = mailbox_helper_obj.new(conversation, processed_mail)
+
+        expect(conversation.messages).to receive(:find_by).with(source_id: processed_mail.message_id).and_return(dummy_message)
+        expect(conversation.messages).not_to receive(:create!)
+
+        helper_instance.send(:create_message)
+      end
+    end
+
+    context 'when message does not exist' do
+      it 'creates a new message' do
+        helper_instance = mailbox_helper_obj.new(conversation, processed_mail)
+
+        expect(conversation.messages).to receive(:find_by).with(source_id: processed_mail.message_id).and_return(nil)
+        expect(conversation.messages).to receive(:create!)
+
+        helper_instance.send(:create_message)
+      end
+    end
+  end
+end

spec/mailboxes/reply_mailbox_spec.rb

@@ -86,6 +86,9 @@ RSpec.describe ReplyMailbox do
 
         html_full_content = conversation.messages.last.content_attributes[:email][:html_content][:full]
         expect(html_full_content).to include('img')
+        expect(html_full_content).not_to include('cid:ii_lm7fuura0')
+        expect(html_full_content).not_to include('cid:ii_lm7fuuvm1')
+        expect(html_full_content).not_to include('cid:ii_lm7fuuwn2')
       end
     end
 
@@ -105,6 +108,9 @@ RSpec.describe ReplyMailbox do
         text_full_content = conversation.messages.last.content_attributes[:email][:text_content][:full]
 
         expect(text_full_content).to include('img')
+        expect(text_full_content).not_to include('[image: poster (8).jpg]')
+        expect(text_full_content).not_to include('[image: poster (7).jpg]')
+        expect(text_full_content).not_to include('[image: poster (1).jpg]')
         expect(conversation.messages.last.content).to include("Let's add no HTML content here, just plain text and images")
         expect(conversation.messages.last.attachments.count).to eq(0)
       end