chore: Fix contact model silently discarding invalid attributes (#4994)

fixes: #4775
This commit is contained in:
Sojan Jose
2022-07-08 10:28:09 +02:00
committed by GitHub
parent bca347149a
commit e4b159dd54
6 changed files with 38 additions and 24 deletions

View File

@@ -44,41 +44,29 @@ RSpec.describe Contact do
end
end
# rubocop:disable Rails/SkipsModelValidations
context 'when phone number format' do
it 'will not throw error for existing invalid phone number' do
it 'will throw error for existing invalid phone number' do
contact = create(:contact)
contact.update_column(:phone_number, '344234')
contact.reload
expect(contact.update!(name: 'test')).to eq true
expect(contact.phone_number).to eq '344234'
expect { contact.update!(phone_number: '123456789') }.to raise_error(ActiveRecord::RecordInvalid)
end
it 'updates phone number when adding valid phone number' do
contact = create(:contact)
contact.update_column(:phone_number, '344234')
contact.reload
expect(contact.update!(phone_number: '+12312312321')).to eq true
expect(contact.phone_number).to eq '+12312312321'
end
end
context 'when email format' do
it 'will not throw error for existing invalid email' do
it 'will throw error for existing invalid email' do
contact = create(:contact)
contact.update_column(:email, 'ssfdasdf <test@test')
contact.reload
expect(contact.update!(name: 'test')).to eq true
expect(contact.email).to eq 'ssfdasdf <test@test'
expect { contact.update!(email: '<2324234234') }.to raise_error(ActiveRecord::RecordInvalid)
end
it 'updates email when adding valid email' do
contact = create(:contact)
contact.update_column(:email, 'ssfdasdf <test@test')
contact.reload
expect(contact.update!(email: 'test@test.com')).to eq true
expect(contact.email).to eq 'test@test.com'
end
end
# rubocop:enable Rails/SkipsModelValidations
end