Fix #58 - Refactor inbox_members_controller (#109)

app/controllers/api/v1/inbox_members_controller.rb

@@ -1,23 +1,20 @@
-class Api::V1::InboxMembersController < Api::BaseController
+module Api
-
+  module V1
+    class InboxMembersController < Api::BaseController
       before_action :fetch_inbox, only: [:create, :show]
       before_action :current_agents_ids, only: [:create]
 
-  def create #update also done via same action
+      def create
-    #get all the user_ids which the inbox currently has as members.
+        # update also done via same action
-    #get the list of  user_ids from params
-    #the missing ones are the agents which are to be deleted from the inbox
-    # the new ones are the agents which are to be added to the inbox
         if @inbox
           begin
-        add_agents
+            update_agents_list
-        remove_agents
             head :ok
-      rescue => e
+          rescue StandardError
-        render_could_not_create_error("Could not add agents to inbox")
+            render_could_not_create_error('Could not add agents to inbox')
           end
         else
-      render_not_found_error("Agents or inbox not found")
+          render_not_found_error('Agents or inbox not found')
         end
       end
 
@@ -27,16 +24,14 @@ class Api::V1::InboxMembersController < Api::BaseController
 
       private
 
-  def add_agents
+      def update_agents_list
-    agents_to_be_added_ids.each do |user_id|
+        # get all the user_ids which the inbox currently has as members.
-      @inbox.add_member(user_id)
+        # get the list of  user_ids from params
-    end
+        # the missing ones are the agents which are to be deleted from the inbox
-  end
+        # the new ones are the agents which are to be added to the inbox
 
-  def remove_agents
+        agents_to_be_added_ids.each { |user_id| @inbox.add_member(user_id) }
-    agents_to_be_removed_ids.each do |user_id|
+        agents_to_be_removed_ids.each { |_user_id| @inbox.remove_member(user) }
-      @inbox.remove_member(user)
-    end
       end
 
       def agents_to_be_added_ids
@@ -55,3 +50,5 @@ class Api::V1::InboxMembersController < Api::BaseController
         @inbox = current_account.inboxes.find(params[:inbox_id])
       end
     end
+  end
+end