chore: Fix conversation status in webhooks (#3364)

- fix the wrong conversation status being sent in webhooks
- additional information in websocket events
- refactor activity messaging code
- move activity message generation to background job to stop the callback loop
This commit is contained in:
Sojan Jose
2021-11-12 16:17:59 +05:30
committed by GitHub
parent b119d9e729
commit d78cb67a2a
13 changed files with 219 additions and 136 deletions

View File

@@ -43,35 +43,4 @@ module AssignmentHandler
create_assignee_change_activity(user_name)
end
end
def generate_team_change_activity_key
key = team_id ? 'assigned' : 'removed'
key += '_with_assignee' if key == 'assigned' && saved_change_to_assignee_id? && assignee
key
end
def create_team_change_activity(user_name)
return unless user_name
key = generate_team_change_activity_key
params = { assignee_name: assignee&.name, team_name: team&.name, user_name: user_name }
if key == 'removed'
previous_team_id = previous_changes[:team_id][0]
params[:team_name] = Team.find_by(id: previous_team_id)&.name if previous_team_id.present?
end
content = I18n.t("conversations.activity.team.#{key}", **params)
messages.create(activity_message_params(content))
end
def create_assignee_change_activity(user_name)
return unless user_name
params = { assignee_name: assignee&.name, user_name: user_name }.compact
key = assignee_id ? 'assigned' : 'removed'
key = 'self_assigned' if self_assign? assignee_id
content = I18n.t("conversations.activity.assignee.#{key}", **params)
messages.create(activity_message_params(content))
end
end